Goto Skip Problem

[CosminPerRam]

Hello there, i have this code and at the part with encrypt (goto) it cout first line and skipp all and return, i dont know how to fix this, can ya help me? Thanks in advance!

For more exact info, compile and run it, after chose/type encrypt and you can see my problem, i hope i will fix it!

#include <iostream>
#include <string>
#include "encry loop.h"
#include <stdlib.h>

int a = 0;
std::string w;
char b = w.length();

int main()
{
    std::cout<<"What to you want to do?"<<endl;
    std::string k;
    std::cin >> k;
    if(k=="Encrypt" || k=="encrypt")
    {
        system("cls");
        goto encrypt;
    }

    if(k=="Decrypt" || k=="decrypt")
    {
        system("cls");
        goto decrypt;
    }

    return 0;

    encrypt:
    std::cout << "Sentence to be encrypted: "<<endl<<endl;
    std::getline (std::cin,w);

    cout<<" "<<endl;
    for (int i = 0; i < b; i++)
    {
    char c = w[a];
    eloop(c);
    a = a + 1;
    }

    cout<<" "<<endl<<endl;
    return 0;

    decrypt:
    std::cout<<"Decrypt is coming soon!"<<endl;

    return 0;
}

[48T7M4Gy]

replace it with a function call and corresponding function is one possibility.

[Duthomhas]

Formatted vs Unformatted I/O
You are mixing formatted and unformatted input, which is causing your problem.

On line 14 you use formatted input to get a space-delimited string from the user. This leaves the newline (Enter key) in the input.

Then on line 31 you ask for unformatted input, but that newline (Enter key) is still waiting to be read, so it is and that's what you get.

To see better what is happening, try entering something like "encrypt my dear aunt sally" and see what happens.

Goto
Why are you using goto?

Either use a function, or perform the proper thing in the if..else branches:

    if(k=="Encrypt" || k=="encrypt")
    {
        ask_for_and_encrypt_user_input();
    }
    if(k=="Decrypt" || k=="decrypt")
    {
        ask_for_and_decrypt_user_input();
    }

    if(k=="Encrypt" || k=="encrypt")
    {
        std::string string_to_encrypt;
        std::cout << "Sentence to be encrypted: \n\n";
        std::getline(std::cin, string_to_encrypt);
        ...
    }
    if(k=="Decrypt" || k=="decrypt")
    {
        ...
    }

Hope this helps.

[Naughty Albatross]

Could you please show us what your function eloop() is?

[CosminPerRam]

eloop() is another file with:

#include <iostream>
#include "encry loop.h"
#include <string>

using namespace std;

void eloop(char c)
{
    //letters

    if(c=='a' || c=='A')
{
cout<<"00100"<<endl;
}
    if(c=='b'||c=='B')
{
...
}
......
......

I try now and i will tell you back if it worked! thanks for answering!

[CosminPerRam]

Hello, im back, there is the same problem but now i have this code:
*I still not understand how to fix it*

#include <iostream>
#include <string>
#include "encry loop.h"

int a = 0;
std::string w;
char b = w.length();

int main()
{
    std::cout<<"What to you want to do?"<<endl;
    std::string k;
    std::cin >> k;
    if(k=="Encrypt" || k=="encrypt")
    {
        std::cout << "Sentence to be encrypted: "<<endl<<endl;
        std::getline (std::cin,w);

        std::cout<<" "<<endl;
        for (int i = 0; i < b; i++)
        {
            char c = w[a];
            eloop(c);
            a = a + 1;
        }

        cout<<" "<<endl<<endl;
        return 0;
    }

    if(k=="Decrypt" || k=="decrypt")
    {
        std::cout<<"Decrypt is coming soon!"<<endl;
        return 0;
    }

    return 0;
}

[Naughty Albatross]

What exactly is your problem? What do you want to achieve?

[48T7M4Gy]

Have you made sure your .h file and this file are in the same project directory or linked appropriately? (in Xcode this is not often straightforward)

Also the "encry loop.h" file name shouldn't have a space.

[Naughty Albatross]

You didn't measure the length of w after inputting.
std::getline (std::cin,w); b = w.length();

[CosminPerRam]

+closed account 5a8Ym39o6
http://puu.sh/pSbGi/12ceefd491.png
There, where you see at my program "Sentence to be encrypted".
It needed to be:
*Insert text* (Random text)
*Show text* (something like 01012 00101 ...)

But it give white space and skip the insert (and after) part and go to the return.
I hope i explained good

+kemort
Im sure, look at the image.

+closed account 5a8Ym39o6
I change it, same problem.

[48T7M4Gy]

Cosmin, You're using codeblocks, not XCode.

If you have a mac then you are better off with xcode if you can.

[Naughty Albatross]

The program did tell you to input something but you didn't seem to be inputting it and simply pressing Enter. Should it be "Hello World", "Homeland", etc

If the function getline happens not to work, use cin >> w; instead.

[Naughty Albatross]

Use this :
std::cout << "Enter sentence to be encrypted : ";

[CosminPerRam]

+kemort
Yeah, is this a bad thing?

Also, there's a fix for my problem? :(

[CosminPerRam]

I found the problem,
at std::getline (std::cin,w); if i change it with cin >> w; it will solve the problem, but after, it will not take the complete sentence, only first word.

[48T7M4Gy]

Yeah, is this a bad thing?

No, if you like CodeBlocks its OK. It works.

Also, there's a fix for my problem?

Which problem? There are a few subplots going on here.

[Naughty Albatross]

Then you use this :

char tmp[1024];
cin.getline(tmp, 1024, '\n');
w = tmp;

[48T7M4Gy]

std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); //prepare for following getline() after a cin

See the following if this is the problem you're talking about and you want a good long explanation http://stackoverflow.com/questions/11835226/program-skips-cin-getline

[CosminPerRam]

i writed cin.ignore(); before std::getline (std::cin,w); and it solved my problem, thank you guys so much!

[Naughty Albatross]

Glad, this makes me happy too :)