how to get out a loop after user enter the correct answer

[jojojojo95]

Salam, i have a school project to submit by this week, basically my project is about crytographic games where the user input the letter to guess what are the real word that combine to become a sentences. I want to ask how to get out a loop after user enter the correct answer , well the maximum tries is five, i mean if user get the correct before using the five tries, it won't get out of the loop and the statement congratulations will not appear. How to make the statement congratulations appear after the user succesfully insert the correct letter.
here are my codes , as you can see, I have try many ways to make this thing happen but I had no more ideas on how to fix this.
please somebody help me

  #include <iostream>
#include <iomanip>
#include <string>
#include <cstdlib>
#include <ctime>
#include <string.h>
#include <stdio.h>
void Movie ();
void Idiom ();
void Country ();
void generator(char& teka, char answer[], char output[],bool& penentu,int& cubaan);
int penentuan(char output[],char answer[]);
using namespace std;
const int size = 30;
int main ()
{
	cout<<setw(55)<<"WELCOME TO CRYTOPGRAPHIC QUIZ GAMES!"<<endl;
	cout<<setw(73)<<"You must try to guess which alphabet represents the other alphabet.";
	cout<<endl<<endl;
    cout<<setw(45)<<"You are currently in"<<endl<<setw(38)<<"LEVEL 1"<<endl;

    const int MIN_VALUE = 1;
    const int MAX_VALUE = 3;

    int x;
    char option,again;

    unsigned seed = time(0);
    srand (seed);


    cout<<setw(58)<<"Your category have been choosen by computer :"<<endl;
    x = (rand() % (MAX_VALUE - MIN_VALUE + 1)) + MIN_VALUE;

    do
    {
        switch (x)
	{
		case 1: cout<<setw(38)<<"MOVIES"<<endl;
                Movie ();
		         break;
		case 2: cout<<setw(38)<<"IDIOMS"<<endl;
                Idiom ();
		         break;
		case 3: cout<<setw(38)<<"COUNTRY"<<endl;
                Country ();
		         break;
		default :;
	}
	cout<<endl<<setw(48)<<"Do you want to play again?"<<endl;
	cout<<setw(53)<<"Press Y if yes, press any key if no"<<endl;
	cout<<setw(35)<<" ";
	cin>>again;

    }while(again == 'Y'||again == 'y');

	return 0;
}
void Movie ()
{

	//system("COLOR D");


	char answer[size] = "THE SHAWSHANK REDEMPTION";
	char cipher[size] = "GSV HSZDHSZMP IVWVNKGRLM";
	char output[size] = "___ _________ __________";
	char tekaan; bool penentu = false;
	int TrueFalse, cubaan = 1;

	cout <<endl<<setw(53)<< "Guess the following cipher by letter" << endl <<setw(47)<< "You have maximum 5 tries" << endl;

	 do
    {
		//system("CLS");


		cout <<endl<<setw(47)<<"GSV HSZDHSZMP IVWVNKGRLM" << endl <<setw(47)<< "_ _ _ _ _ _ _ _ _ _ _" << endl;
		cout << endl;
		cout <<setw(47)<< output << endl <<endl;


		cout << "Your try - " << cubaan << " : ";
		cin >> tekaan;
		tekaan = toupper(tekaan);
		generator(tekaan, answer, output, penentu, cubaan);
		cout << endl;

        TrueFalse = penentuan(output, cipher);

        if(TrueFalse == 1)
        {
            break;
        }
        else
        {

        }


	}while(cubaan < 6);



	if (TrueFalse == 1)
	{

		cout << " CONGRATULATION ! YOU'VE GOT IT ALL CORRECT ! " << endl;
	}
	else
	{
		cout <<setw(45)<< " Sorry, you're WRONG! " << endl;
		cout <<setw(35)<< " The right answer : " << answer << endl;
	}
	//system("PAUSE");
}
void generator(char& teka, char answer[], char output[],bool& penentu,int& cubaan)
{

	for (int i = 0; i < size; i++)
	{

		if (teka == answer[i])
		{
			output[i] = teka;
			penentu = true;
		}

	}

	if (!penentu)
	{

		cubaan++;
	}
	else
	{
		penentu = false;
	}



}
int penentuan(char output[],char answer[])
{
    int TrueFalse;
	if (strcmp(output, answer) == 0)
	{
	    TrueFalse = 1;
		return TrueFalse;
	}
    else
    {
        TrueFalse = 0;
        return TrueFalse;
    }

}
void Idiom ()
{
	//system("COLOR D");


	char answer[size] = "CURIOSITY KILLS THE CAT";
	char cipher[size] = "XFIRLHRGB PROOH GSV XZG";
	char output[size] = "_________ _____ ___ ___";
	char tekaan; bool penentu = false;
	int cubaan = 1;

	cout <<endl<<setw(53)<< "Guess the following cipher by letter" << endl <<setw(47)<< "You have maximum 5 tries" << endl;

	while (cubaan < 6)
	{
		//system("CLS");

		cout <<endl<<setw(46)<< "XFIRLHRGB PROOH GSV XZG" << endl <<setw(58)<<"_ _ _ _ _ _ _ _ _  _ _ _ _ _  _ _ _  _ _ _ " << endl;
		cout << endl;
		cout <<setw(46)<< output << endl <<endl;


		cout << "try - " << cubaan << " : ";
		cin >> tekaan;
		tekaan = toupper(tekaan);
		generator(tekaan, answer, output, penentu, cubaan);
		cout << endl;



	}

	if (penentuan(output, cipher))
	{

		cout << " CONGRATULATION ! YOU'VE GOT IT ALL CORRECT ! " << endl;
	}
	else
	{
		cout <<setw(45)<< " Sorry, you're WRONG! " << endl;
		cout <<setw(33)<< " The right answer : " << answer << endl;
	}
	//system("PAUSE");
}
void Country ()
{
	//system("COLOR D");


	char answer[size] = "CROATIA";
	char cipher[size] = "ZYVIEWI";
	char output[size] = "_______";
	char tekaan; bool penentu = false;
	int cubaan = 1;

    cout <<endl<<setw(53)<< "Guess the following cipher by letter" << endl <<setw(47)<< "You have maximum 5 tries" << endl;

	while (cubaan < 6)
	{
		//system("CLS");


		cout <<setw(38)<< "ZYVIEWI" << endl <<setw(42)<< "_ _ _ _ _ _ _ " << endl;
		cout << endl;
		cout <<setw(38)<< output << endl <<endl;


		cout << "Your try - " << cubaan << " : ";
		cin >> tekaan;
		tekaan = toupper(tekaan);
		generator(tekaan, answer, output, penentu, cubaan);
		cout << endl;



	}

	if (penentuan(output, cipher))
	{

		cout << " CONGRATULATION ! YOU'VE GOT IT ALL CORRECT ! " << endl;
	}
	else
	{
		cout <<setw(45)<< " Sorry, you're WRONG! " << endl;
		cout <<setw(40)<< " The right answer : " << answer << endl;
	}
	//system("PAUSE");
}

[jolm1x]

I believe your problem is at

do
{
...
if(TrueFalse == 1)
{
      break;
}
else
{

}
...
}while(cubaan < 6);

To my knowledge the break; only exits the if statement, not the loop

[MikeyBoy]

jolm1x wrote:

To my knowledge the break; only exits the if statement, not the loop

No. break has no interaction with if blocks at all. It will exit the innermost loop that it's in, and if statements are not loops.

@OP I'd recommend stepping through your code with a debugger, so that you can see exactly where the logic in the execution differs from what you expect.