Simple Menu Program

[daisy8]

Hi everyone

I'm very new to C++ but I am learning !

I have written a program to give the user a menu with choices and interaction, however, I have a problem with it. The aim was to teach myself how functions and global variables work.

The problem is that if the user enters a username and password and then logs in with it a selection of exit shows the login lines again and I can't work out why !! Seems like it goes to the login function again ?? Any help ??

#include <iostream>
#include <string>

using namespace std;

    int selection = 0;
    string username = "0";
    string password = "0";
    int launchcode = 1;

    void menu ();
    void setpassword ();
    void setlaunch ();
    void login();
    void launch ();
    void exit ();

int main()
{
   cout << endl;
   menu ();

}

void menu ()
   {
        cout << endl;
        selection = 0;
        cout << " Please choose from the following options - \n";
        cout << " 1. Set username and password.\n";
        cout << " 2. Set launch codes.\n";
        cout << " 3. Login.\n";
        cout << " 4. Enter launch codes.\n";
        cout << " 5. Exit.\n";
        cout << "\t";
        cin >> selection;

   if (selection == 1)
   {
       setpassword ();
   }
   else if (selection == 2)
   {
       setlaunch ();
   }
   else if (selection == 3)
   {
       login();
   }
   else if (selection == 4)
    {
       launch();
    }
   else if (selection == 5)
    {
      exit ();
    }
   }

void setpassword()
   {
       cout << " Please enter new username - ";
       cin >> username;
       cout << " Please enter new password - ";
       cin >> password;
       menu ();
   }

void setlaunch()
   {
       cout << " Please enter a 4 digit launch code - ";
       cin >> launchcode;
       menu ();
   }

void login()
   {
        string usertest;
        string passtest;

       if (username != "0" | password != "0" ) //make sure a username/password has been set
       {
           for ( int i = 0; i < 5; i++)
           {
               cout << " Please enter username - ";
               cin >> usertest;
               cout << " Please enter password - ";
               cin >> passtest;

               if ( username != usertest | password != passtest)
               {
                   cout << " USERNAME OR PASSWORD NOT RECOGNISED\n";
               }
               else
                {
                   cout << " Credentials Accepted\n";
                   menu ();
                }
            }
            menu ();
        }


       else
       {
        cout << " NO USERNAME OR PASSWORD SET.";
        menu ();
        }
   }

void launch ()
{
    int launchtest;

    if (launchcode != 1)
    {
        cout << " Please enter launch code - ";
        cin >> launchtest;


            if (launchtest == launchcode)
            {
            cout << " MISSILES LAUNCHED";
            menu ();
            }
            else
            {
                cout << " Launch code incorrect";
                menu ();
            }
    }
        else
        {
            cout << " NO LAUNCH CODE SET\n";
        menu ();
        }

}
    void exit ()
    {
       cout << " See ya !\n";
    }

[chicofeo]

Take a look again at how to use functions:

http://www.cplusplus.com/doc/tutorial/functions/

[daisy8]

Thanks chicofeo

I came up with this that seems to work. Anything I'm doing wrong here ?

#include <iostream>
#include <string>

using namespace std;

    int k = 0;
    int selection = 0;
    string username = "0";
    string password = "0";
    int launchcode = 1;

    void menu ();
    void setpassword ();
    void setlaunch ();
    void login();
    void launch ();
    void exit ();

void menu ()
   {
        cout << endl;
        cout << " Please choose from the following options - \n";
        cout << " 1. Set username and password.\n";
        cout << " 2. Set launch codes.\n";
        cout << " 3. Login.\n";
        cout << " 4. Enter launch codes.\n";
        cout << " 5. Exit.\n";
        cout << " ";
        cin >> selection;

   if (selection == 1)
   {
       setpassword ();
   }
   else if (selection == 2)
   {
       setlaunch ();
   }
   else if (selection == 3)
   {
       login();
   }
   else if (selection == 4)
    {
       launch();
    }
   else if (selection == 5)
    {
      exit ();
    }
   }

void setpassword()
   {
       cout << " Please enter new username - ";
       cin >> username;
       cout << " Please enter new password - ";
       cin >> password;
       cout << endl;
       cout << " ** NEW USER CREDENTIALS ACCEPTED **\n";
   }

void setlaunch()
   {
       cout << " Please enter a new launch code - ";
       cin >> launchcode;
       cout << endl;
       cout << " ** NEW LAUNCH CODE ACCEPTED **\n";
   }

void login()
   {
        string usertest;
        string passtest;

       if (username != "0" | password != "0" ) //make sure a username/password has been set
       {
           for ( int i = 0; i < 5; i++)
           {
               cout << " Please enter username - ";
               cin >> usertest;
               cout << " Please enter password - ";
               cin >> passtest;

               if ( username != usertest | password != passtest)
               {
                   cout << endl;
                   cout << " USERNAME OR PASSWORD NOT RECOGNISED\n";
               }
               else
                {
                   cout << endl;
                   cout << " Credentials Accepted\n";
                   break;
                }
            }
        }

       else
       {
        cout << endl;
        cout << " NO USERNAME OR PASSWORD SET.\n";
        }
   }

void launch ()
{
    int launchtest;

    if (launchcode != 1)
    {
        cout << endl;
        cout << " Please enter launch code - ";
        cin >> launchtest;

            if (launchtest == launchcode)
            {
            cout << endl;
            cout << " ** MISSILES LAUNCHED **\n";
            }
            else
            {
                cout << endl;
                cout << " Launch code incorrect\n";
            }
    }
        else
        {
            cout << endl;
            cout << " NO LAUNCH CODE SET\n";
        }

}
    void exit ()
    {
       cout << endl;
       cout << " See ya !\n";
       k = 1;
    }

int main()
{
    while (true)
    {
        cout << endl;
        if (k == 1)
        {
            break;
        }
        menu ();
    }
   return 0;
}

[1vD3vCM9]

Just noticed you used a bit wise OR.
At line 76
Was it your intention?

[daisy8]

I just wanted to ask if either of the 2 arguments is false. Should I use something else here?

[whitenite1]

@daisy8

Yes. On lines 76 and 85, you should use || which means OR, as in this or that. A single | is what oren drobitsky said, a bit wise OR which is not what you want.

[daisy8]

Thanks for that !