displayText problem with loop

[aerichsen]

I'm writing a program to read from a file ex: 1 2 3 and display it backwards. Everything is working fine, except for my displayText function. Any suggestion on why that function is not working?

Thanks,

#include <iostream>
#include <fstream>
using namespace std;



void readFile(char filename[])
{
   ifstream fin(filename);
   
   if (fin.fail())
      cout << "you fail\n";
   

   char text[256];
      
      while (!fin.eof())
      {
         fin >> text;
      }
   
   fin.close();
}

void displayText(char text[256])
{
   int i = 0;
   while (text[i])
      i++;
   for (i--; i >= 0; i--)
      cout << text[i] << endl;


}

int main()
{
   
   char filename[256];
   cout << "Please enter file name: ";
   cin >> filename;
   char text[256];
   readFile(filename);
   displayText(text);

   return 0;
}

[coder777]

Line 19: Your are filling a local variable that does not exist outside readFile(...)

So instead of having a local variable (on line 15) pass this as a parameter:

#include <iostream>
#include <fstream>
using namespace std;



void readFile(char text[256], char filename[]) // Note
{
   ifstream fin(filename);
   
   if (fin.fail())
      cout << "you fail\n";
   

   char text[256]; // Note
      
      while (!fin.eof())
      {
         fin >> text;
      }
   
   fin.close();
}

void displayText(char text[256])
{
   int i = 0;
   while (text[i])
      i++;
   for (i--; i >= 0; i--)
      cout << text[i] << endl;


}

int main()
{
   
   char filename[256];
   cout << "Please enter file name: ";
   cin >> filename;
   char text[256];
   readFile(text, filename); // Note
   displayText(text);

   return 0;
}

[aerichsen]

Thanks for pointing that out.

I was able to do what I wanted.