Issue with stack program

so first off I am having issues with passing the T value cause for some reason im getting errors saying it cant resolve identifiers for T data or even in my constructors(same issue in stack class)secondly I also have to implement a destructor where I threw the stack underflow. its suppose to loop until stack is empty which I figure I should use a while loop and call my pop function but I am not quite sure. and lastly I am not sure if I wrote my push algorithm correctly. I am still a novice so please be patient with me try and go easy on me, I can use all the help I can get. thank you for time and help!

  template<typename T>

class node
{
	private: 
	node<T>* next;
	T data;
	

	public:
		node(T data, node<T>* next)
		{
			data= newdata;
			next=thenext;
		}


	void getdata()
        {
		return data;
	}
	void getnext()
        {
		return next;
	}
};



#include "node.h"

template <typename T>

class stack

	{
	
	private:
	
	int count;
	node<T> *topnode;

	
	public:
			 gettop()
			 {
				if(!isempty()){
				
				int result;
				
				result= gettop->getdata();
			
				return result;
			}
				else {
					throw<< stackunderflow()
				}
			}
			
			bool isempty()
			{
				return==0;
			}
			
			void pop(){
				
				
				node<T>*temp= gettop;
				
				T result= gettop();
				
				gettop=gettop->getnext();
				
				delete temp;
				
				count--;
			}
	
	
			void push(T data){
				
 				node<T>* newnode;
 				
  				newnode= newdata;
  				
 				newdata->thenext = gettop;
 				
  				newnode = gettop;
  				
				count++;
				
			
			}
			
			int getsize(){
				return count;
			}
};



#include <cstdlib>
#include <iostream>
#include"stack.h"

using namespace std;

int main(int argc, char** argv) {

  stack<int> stack;

  for (int i=0; i<5; ++i) stack.push(i);

  cout << "Popping out elements";
  while (!stack.empty())
  {
     cout << ' ' << mystack.gettop();
     mystack.pop();
  }
  cout <<endl<<getsize();

coder777 (8444)

Line 62: return==0; must be return (count==0);

		node(T data newdata, node<T>* next thenext)
		{
			data= newdata;
			next=thenext;
		}

gettop is needless. Instead check it in pop():

			void pop(){

	if(topnode) // Note
	{				
				node<T>*temp= topnode;
				
				T result= gettop(); // No result
				
				topnode=topnode->getnext();
				
				delete temp;
				
				count--;
}
	else  // Note
	  throw stackunderflow();
			}

push():

			void push(T data){
				
 				topnode = new node<T>(data, topnode);
 				
  				newnode= newdata;
  				
 				newdata->thenext = gettop;
 				
  				newnode = gettop;
  				
				count++;
				
			
			}

Trigguy (11)

Thank you for the reply and help! my node stack seems to be ok now. but the only thing is that I need that I need the top function this is the pseudo code that I need to implement so is there a way I can do it with the top function

T top()
1. If the stack is not empty
1.1. Set the result to the top node’s data
2. Else
2.1. Throw a stack underflow exception
3. End if
4. Return result

Topic archived. No new replies allowed.

C++

Forum

Issue with stack program