What's wrong with my code?

[DL30RXSz]

I made a program to calculate powers. The program just stops running after counter is initialized. I have to force quit it through the exit button. Why is doing this? Also, any style suggestions?

#include <iostream>
using namespace std;

int main()
{
	int base;
	int power;
	int result;

	cout << "What is the base? ";
	cin >> base;
	result = base;

	cout << endl << "What is the power? ";
	cin >> power;
	
	int counter = 1;
	//program doesn't get passed here
	if(counter==power)
	{
		result=base;
	}
	else if(power==0)
	{
		result=0;
	}
	else
	{
		while(counter<power);
		{
			result *= base;
			counter++;
		}
	}
		
	cout << endl << "The result is: ";
	cout << result << endl;

	bool again;
	cout << "Go again? 1=yes/0=no: ";
	cin >> again;
	if(again==1)
		main();
	else
		return 0;
}

[helios]

First of all, x⁰=1 for all values of x, not 0.
Second, there's a semicolon immediately after the while condition on line 29, making the while an empty loop.

[DL30RXSz]

Haha, thanks I had no idea I missed something stupid like that.

[Disch]

also:

You can't call main() like that.

Never ever do that.

Put main in a loop. But don't call it again.

[brokenbot]

how do you put main in a loop disch????

also:

You can't call main() like that.

Never ever do that.

Put main in a loop. But don't call it again.

[Disch]

int main()
{
  bool repeat = true;
  while(repeat)
  {
    // ...
    // stuff you want to repeat
    // ...

    if( dont_want_to_repeat_anymore )
      repeat = false;
  }
}

[DL30RXSz]

I made a few revisions. How's this?

#include <iostream>
using namespace std;

int main()
{
	int base;
	int power;
	int Power(int, int);

	bool again=true;
	while(again)
	{
		cout << endl << "What is the base? ";
		cin >> base;

		cout << endl << "What is the power? ";
		cin >> power;

		cout << endl << "Result is: " << Power(base, power) << endl;

		cout << "Go again? 1=yes 0=no ";
		cin >> again;
	}

	return 0;
}

int Power(int base, int power)
{
	int result=base;
	int counter=1;

	if(base==1)
	{
		result=base;
	}
	else if(power==0)
	{
		result=1;
	}
	else
	{
		while(counter<power)
		{
			result *= base;
			counter++;
		}
	}

	return result;
}

[blackcoder41]

i'd say use for loop

[gcampton]

How's this?

Much better, There's no need for a "for" loop this is fine.
Nice indentation, good structure.
1 crititsism, is validation. But this is something you can learn to add to future projects. The yes is pretty redundant in the output as it loops anyway... Also user could have typed a letter or some gibberish.

What I mean about the output is you could say:

bool again=true;
int i;
while (again)   // or do while
{
   cout <<  "\nWould you like to continue? press 1 for Yes: ";
   cin >> i;
   again = false;
   if ( i == 1)
      again = true;
}

this way if the user wants to continue it does, otherwise it exits.
your code runs an infinite loop on bad input.

using a do while you can set to false to start with:

int i;
do
{
   bool again=false; // necessary in loop for reset.
   cout <<  "\nWould you like to continue? press 1 for Yes: ";
   cin >> i;
   if ( i == 1)
      again = true;
} while (again);

[blackcoder41]

what about if 0 is raised to 0, it's not equal to 1..
0⁰

or a number is raised to a negative?
N^-M

[gcampton]

I thought you were referring to user input you didn't specify.

[blackcoder41]

LOL, i mean using for loop for calculating powers..

[gcampton]

Anyway, I replied to this post, then read this post : http://cplusplus.com/forum/beginner/18518/

you should follow Duoas examples in that for better validation. However it can be complicated for begineers.

edit: personally, I don't think it matters too much. I typically use responses as posted above, as they are much easier to write and still unbreakable.
"Would you like to continue Y/N? " process 'y' and ignore everything else is my motto "TOO BAD! if user makes a typo eh."

[helios]

what about if 0 is raised to 0, it's not equal to 1..

Yes, it is.

or a number is raised to a negative?

x^-y = (1/x)^y

[mcleano]

Somebody clearly hasn't done differentiation/integration!