Array with Deep Copy& Copy Constructor

[LibLife]

Hi, I am trying to get my code to run, and I can't figure out the problem.
This program is suppose ask the user to enter and array and then print out the array while using the assignment operator, shallow copy, and copy constructor.
I think the problem is with the SetAll and Print functions definitions.

Please help me make it run!

//PointerData.h file

#ifndef POINTERDATA_H
#define POINTERDATA_H

class PointerDataClass
{
private:
    int x;
    int lenp;
    int *p;
public:
    void SetAll( int num, int sizeP, int *ptr);
    PointerDataClass(int sizeP = 10);       //constructor
    ~PointerDataClass();                    //destructor
    void print();
    const PointerDataClass & operator=(const PointerDataClass & right);     //Assignment operator function
    void destroyP();            //Destructor function
    PointerDataClass(const PointerDataClass &);     //copy constructor
};


#endif // POINTERDATA_H


//PointerData.cpp
#include "pointerData.h"
#include<iostream>
using namespace std;

//constructor
PointerDataClass::PointerDataClass(int sizeP)
{
    int x=0;
    if(sizeP > 0)
        lenp = sizeP;
    else
        lenp = 10;

    p = new int[lenp];
}

PointerDataClass::~PointerDataClass()
{
    delete [] p;
}

void PointerDataClass::destroyP()
{
    x= 0;
    lenp = 0;
    delete[] p;
    p = NULL;
}

const PointerDataClass & PointerDataClass::operator=(const PointerDataClass & right)
{
    if(this != &right)
    {
        destroyP();
        x= right.x;
        lenp= right.lenp;

        if(lenp > 0)
        {
            p= new int[lenp];
            for(int i = 0; i< lenp; i++)
                p[i] = right.p[i];
        }

        return *this;
    }
}

PointerDataClass::PointerDataClass(const PointerDataClass & right)
{
    x = right.x;
    lenp = right.lenp;

    if(lenp > 0)
    {
        p = new int[lenp];
        for(int i= 0; i< lenp; i++)
        {
            p[i]= right.p[i];
        }

        p= NULL;
    }

}

void PointerDataClass::print()
{
    cout << "These are the numbers you entered. \n";
    for(int i = 0; i < lenp; i++)
        cout << p[i] <<" ";

    cout << endl;
}


void PointerDataClass::SetAll( int num, int sizeP, int *ptr)
{
    //int x=0;
    if(sizeP > 0)
        lenp = sizeP;
    else
        lenp = 10;
    p = new int[lenp];
    
    cout << "Please enter 10 numbers. \n";
    for(int i= 0; i< lenp; i++)
    {
        cout << "# "<<i+1 <<": ";
        cin >> p[i];
    }
}


//main.cpp

#include "pointerData.h"
#include<iostream>
using namespace std;



int main()
{

    PointerDataClass *arr, *arr2;
    arr = new PointerDataClass[10];

    *arr->SetAll(arr, 10)
    arr->print();

    arr2= new PointerDataClass[10];
    for(int i= 0; i < 10; i++)
    {
        arr[i] = arr2[i];
    }

    cout << " These are the numbers for the second array (arr2). \n";
    *arr2.print();

    cout << endl;



    return 0;
}

[coder777]

Please use code tags: [code]Your code[/code]
Read this: http://www.cplusplus.com/articles/z13hAqkS/


The problem with SetAll(...) is that you provide the wrong parameter. Why does it require three parameter and what are the meanings?
In other words: Use more descriptive names.

This

*arr->SetAll(arr, 10)
arr->print();

can impossibly be right.

array while using the assignment operator, shallow copy, and copy constructor

Is this really correct? I would think it is deep copy.

http://www.learncpp.com/cpp-tutorial/912-shallow-vs-deep-copying/

[LibLife]

Quite frankly, I don't know what I am doing in the SetAll function. I want to set the array and the array's size from the main function. That's why I thought I needed three parameters.

Is there can specific suggestion as to what I can do to fix the problem?

And yes, I meant to say "Deep Copy."

[coder777]

I don't know what's the meaning of int num in SetAll(...), but you don't use it.

You may change it like so:

void PointerDataClass::SetAll( int num, int sizeP, int *ptr)
{
    //int x=0;
    if(sizeP > 0)
        lenp = sizeP;
    else
        lenp = 10;
    p = new int[lenp]; // call destroyP(); before this in order to avoid memory leak
    
    if(sizeP > 0) // Note: copy the values provided
    {
        for(int i= 0; i< lenp; i++)
        {
            p[i] = ptr[i];
        }
    }
    else // It seems that it is not necessary to provide data
    {
        cout << "Please enter 10 numbers. \n";
        for(int i= 0; i< lenp; i++)
        {
            cout << "# "<<i+1 <<": ";
            cin >> p[i];
        }
    }
}

...


int main()
{

    PointerDataClass *arr, *arr2;
    arr = new PointerDataClass[10];

    int num[] = { 1, 2, 3, ... }; // Note: ... -> fill with as many numbers as you want

    // Note: sizeof(num) / sizeof(num[0]) -> The number of values of the array
    arr[0].SetAll(sizeof(num) / sizeof(num[0]), num); // Note: arr[0]
    arr[0].print();
...