Problems with my calculator

[YvngSavage]

I keep getting errors in the following code (I will be posting the errors at the bottom of the code):

  #include <iostream>
#include <stdlib.h>
#include <conio.h>


using namespace std;

int main()
{
    int n1;
    int n2;
    int choice;
    int  sign;

    cout << "Welcome To My Calculator!" << endl;
    cout << "Would you like to continue the program?" << endl;
    cout << "Enter Yes, or No" << endl;
    cin >> choice;

    getch();

    if (choice = 'Yes') {

    system("cls");

    cout << "To use this application you will: ";
    cout << "Press 1 for addition" << endl << endl;
    cout << "Press 2 for subtraction" << endl << endl;
    cout << "Press 3 for multiplication" << endl << endl;
    cout << "Press 4 for division" << endl << endl;
    cout << "You can now choose your desired operation:";

    cin >> sign;

    cout << "Press ENTER twice to be prompted to select two numbers:";

    getch ();

    cout << "Enter your first number:";

    cin >> n1;

    cout << endl;
    cout << "Enter your second number:";

    cin >> n2;

    cout << endl;

   switch (sign) {
   case 1:
       cout << n1 + n2 "=" << endl;
       break;

   case 2:
   cout << n1 - n2 "=" << endl;
   break;

    case 3:
        cout << n1 * n2 "=" << endl;
        break;

    case 4:
        cout << n1 / n2 "=" << endl;
        break;}

    /*cout << "Press ENTER twice to be prompted to select two numbers:"

    getch ();

    cout << "Enter your first number:";

    cin >> n1;

    cout << endl;
    cout << "Enter your second number:"

    cin >> n2;

    cout << endl;*/
    }



}

||=== Build: Debug in Project 1 (compiler: GNU GCC Compiler) ===|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|22|warning: multi-character character constant [-Wmultichar]|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp||In function 'int main()':|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|22|warning: suggest parentheses around assignment used as truth value [-Wparentheses]|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|52|error: expected ';' before string constant|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|56|error: expected ';' before string constant|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|60|error: expected ';' before string constant|
D:\My Documents\Code Blocks Projects\Project 1\main.cpp|64|error: expected ';' before string constant|
||=== Build failed: 4 error(s), 2 warning(s) (0 minute(s), 2 second(s)) ===|

there are alot of errors in this code im trying to sort through them as i go, looking up what i need, but i cannot seem to find whats wrong. Any help is much appreciated. Any pointers on how to improve my code, or anything i need to change would also be helpful...

I have the bottom commented out because i was experimenting with something by the way...

[newbiee999]

Lines 52, 56, 60 and 64 have syntax errors.

They should look like:

cout << n1 + n2 << "=" << endl;

cout << n1 - n2 << "=" << endl;

cout << n1 * n2 << "=" << endl;

cout << n1 / n2 << "=" << endl;

Hope this helps!

[YvngSavage]

Thanks for the help! I have now run into another problem, whenever I compile it, sometimes it work i'd sat 1/10 times, it just prints everything out ignoring every cin >> i use. Any help is appreciated.

#include <iostream>
#include <stdlib.h>
#include <conio.h>


using namespace std;

int main()
{
    int n1;
    int n2;
    int choice;
    int  sign;

    cout << "Welcome To My Calculator!" << endl;
    cout << "Would you like to continue the program?" << endl;
    cout << "Enter Yes, or No" << endl;
    cin >> choice;

    

    if (choice = 'Yes') {

    system("cls");

    cout << "To use this application you will:" << endl;;
    cout << "Press 1 for addition" << endl << endl;
    cout << "Press 2 for subtraction" << endl << endl;
    cout << "Press 3 for multiplication" << endl << endl;
    cout << "Press 4 for division" << endl << endl;
    cout << "You can now choose your desired operation:";
    cout << endl << endl;

    cin >> sign;

    

    cout << "Press ENTER twice to be prompted to select two numbers:" << endl;
    
   getch ();


    cout << "Enter your first number:";

    cin >> n1;

    cout << endl;
    cout << "Enter your second number:";

    cin >> n2;

    cout << endl;

   switch (sign) {
   case 1:
       cout << n1 + n2  << endl;
       break;

   case 2:
   cout << n1 - n2  << endl;
   break;

    case 3:
        cout << n1 * n2  << endl;
        break;

    case 4:
        cout << n1 / n2  << endl;
        break;}



    }



}

[MaBunny]

Both n1 n n2 are int types try using this :

cout<<(float)(n1/n2)<<endl;

And you should check if the denominator isnt zero.Computers are a badaaas with infinity.
Also making n1 and n2 signed might help in minus operator if n2 is greator thn n1.