Your problem is that non of your if statements will ever come true. The reason being that std::cin >> uses white-space as seperator. Meaning it will stop reading once it finds a space. So it can never read "Pounds to piasters". You want to use std::getline -
I would also like to mention, having the user typing "Pounds to piasters" or "Piasters to pounds"
is kinda absurd. Because lowercase and uppercase letters matter. Perhaps make a menu with the numbers 1 and 2, or a and b.
Edit:
elseif (ans == "Piasters to pounds"); // remove the semicolon.