hey ...
Post the error messages, at first sight I see lines like
which most likely wrong.
And please edit your (quote?) tags to [code][/code] tags.
|
|
which most likely wrong.
And please edit your (quote?) tags to [code][/code] tags.
Last edited on
| i have error in lines: 10,11,12,14,14,44,60,62,65,70,71,75,78,79,80,81 |
What errors? Could you please post the compiler output (aka error messages)?
You just wrote this without any testing? You should test your code whilst coding.
Now, go from error to error, figure out what it means then try to fix it. If there is anything more specific, then we can help.
Now, go from error to error, figure out what it means then try to fix it. If there is anything more specific, then we can help.
closed account (S6k9GNh0)
It's not always that simple R0mai. Generally a good way to go about things is make a framework, implement that framework, and then fix what is broken inside of the implementation, leaving the outline the same at all times. It becomes more inconvenient just to make sure different parts of the code works at any given time.
I will admit that almost ALL of your functions are completely useless and would almost be made fun of. I would suggest you look at the STD libraries and / or STL to figure out what to use instead of implementing functions that do a crap job of what your wanting.
Also, you don't seem to know much about C or C++ or coding in general for that matter. I advise you go to the cplusplus.com tutorials section to learn the basics of C++ and then revise your code by yourself. I could go down the long list of errors but I refuse to since they are errors that even the beginning of beginners could fix. That tells me that you slapped us with your code because you don't wanna do it or you can't figure out how to do the most basic operations but you can figure out how to use more advanced STL classes. That tells me you copy and pasted everwhere without know of what it does actually. Who knows? It's hard to tell...
I will admit that almost ALL of your functions are completely useless and would almost be made fun of. I would suggest you look at the STD libraries and / or STL to figure out what to use instead of implementing functions that do a crap job of what your wanting.
Also, you don't seem to know much about C or C++ or coding in general for that matter. I advise you go to the cplusplus.com tutorials section to learn the basics of C++ and then revise your code by yourself. I could go down the long list of errors but I refuse to since they are errors that even the beginning of beginners could fix. That tells me that you slapped us with your code because you don't wanna do it or you can't figure out how to do the most basic operations but you can figure out how to use more advanced STL classes. That tells me you copy and pasted everwhere without know of what it does actually. Who knows? It's hard to tell...
Last edited on
| It's not always that simple R0mai. [...] |
Of course, but as far as I can see OP, is not yet enough experienced to write a lot of code without testing. As you get more experienced, you 1: make less mistakes, 2: find the source of the errors more easily. cppbeg should have tested every line which he is not 100% sure what it does. This way he can avoid lines like
if (cin == 'Y' ), which is really far from the desired result.cppbeg: I recommend rewriting the whole program from scratch, making sure everything compiles, and has the desired functionality before going to the next statement/function.
Well, the errors I see are quite simple.
10,11,81: You didn't declare ch or ch_1 (
12: The function perform doesn't exist. You misspelled it in its definition as
14: I don't really understand what you meant to do there. choice() is a function. Hell, it's a void function, so it doesn't even return anything. What did you mean by
60: You declared a variable value, which creates a name conflict with the function's argument, which already contains a variable value. On a side note, #DEFINE in the middle of a function is considered very bad form. And I'm pretty sure it's wrong for what you're trying to do.
62: The compiler gets confused due to the name conflict
66: Not sure. Haven't initialized a MD array in a while.
70: Read up on how to use fopen(). You're doing it wrong.
71,70 again,55: You're declaration of fd is within a for() loop. This in-and-of-itself will cause problems, but in this particular case, since you didn't limit the for() loop with { }, it assumes that only the very next command is included in it. Therefore, when it leaves the for() loop, FILE* fd is out of scope and is deleted, making
78: You want to use ==, not =. And your if wouldn't do anything anyways, since it's closed by a semi-colon.
79: Wait, what?!
80: Related to error 78
80: Calling a function needs to have the argument list. Even if it's an empty list.
Notice how the last error is basically the computer giving up. These are all pretty big, beginner mistakes. You should take a look at a few of the tutorials on the site.
10,11,81: You didn't declare ch or ch_1 (
char ch,ch_1;) before making use of them as variables. Same for res in 81.12: The function perform doesn't exist. You misspelled it in its definition as
void preform. This is also error 44. perform is a function, and as such must have a list of parameters attached to it. If there are no parameters, then it should be void perform(void)14: I don't really understand what you meant to do there. choice() is a function. Hell, it's a void function, so it doesn't even return anything. What did you mean by
choice()!='Q'? If you meant that ch!='Q', then use that.60: You declared a variable value, which creates a name conflict with the function's argument, which already contains a variable value. On a side note, #DEFINE in the middle of a function is considered very bad form. And I'm pretty sure it's wrong for what you're trying to do.
62: The compiler gets confused due to the name conflict
66: Not sure. Haven't initialized a MD array in a while.
70: Read up on how to use fopen(). You're doing it wrong.
71,70 again,55: You're declaration of fd is within a for() loop. This in-and-of-itself will cause problems, but in this particular case, since you didn't limit the for() loop with { }, it assumes that only the very next command is included in it. Therefore, when it leaves the for() loop, FILE* fd is out of scope and is deleted, making
if(NULL==fd) have an error, since it tries to use the char fd in the function's argument list. Oh, and yeah, that's a name conflict. Again.78: You want to use ==, not =. And your if wouldn't do anything anyways, since it's closed by a semi-colon.
79: Wait, what?!
80: Related to error 78
80: Calling a function needs to have the argument list. Even if it's an empty list.
else menu();Notice how the last error is basically the computer giving up. These are all pretty big, beginner mistakes. You should take a look at a few of the tutorials on the site.
Topic archived. No new replies allowed.