Stockmarket Portfolio code issues

[SiliconPatriot]

Here's the directions: I'll note the code where I'm currently having issues. I haven't tested the calculations because I missed something with the first half of the code and I don't know what I'm missing. I'm sorry if this is a headache Thanks for the help.

In this assignment, you will develop a C++ program that calculates gain or loss of a stock you purchased. Go to the website “Yahoo! Finance” and select a technology stock for your assignment. Some examples of technology stocks include Apple, Cisco, IBM, Teradata, etc….

In your program, the user will enter the following pieces of information:

• the name of the stock
• the stock symbol
• the number of shares purchased
• the purchase price
• the commission paid

Requirements for Your Program:

Here are additional requirements for your program:

1. Have the user enter the company name and stock symbol
2. Have the user enter the number of shares purchased
3. Have the user enter the price per share, sharePrice.
4. Calculate the sharesCost which is the number of shares * price per share
5. When you purchase stock you need to pay a commission based on the number of shares purchased times the purchase price. Multiply the commission rate times shareCost.
6. Add the sharesCost to the commission to calculate total cost of purchase
7. After holding the stock for a period of time you may want to sell. Use a random number generator to simulate a percentage change in your sale price. The generator will generate a number between 1 and 100 but since you want a percentage, divide the number generated by 100. See pages 127-129 for how to create a random number and do not forget to seed the random number generator.
8. To determine if the change in the stock value is positive or negative (the stock market can go down or up), toss a coin to generate a random outcome (gain or loss). Below is the code for flipping a coin.
9. Multiply percentage from step 7 by the profitLoss which will make the percentage positive or negative.
10. Multiple percentage from step 9 by the sharePrice and add it back to the sharePrice. Your formula will look like this NewSharePrice = (percentGain * sharePrice) + sharePrice. percentGain was calculated in step 9.
11. Calculate the new value of your shares multiple the newSharePrice times the number of shares.
12. Now you are going to sell your shares. When you sell stock you need to pay commission to your broker. The commission on the sale needs to be recalculated (commission times the new value of your stock). The profit (or loss) you make will be what you paid for the stock (including the commission) minus what you netted from the sale (the new value of your shares minus the commission).
13. Did you make money or lose money on your stock purchase? Calculate your gain or loss.
14. Your rate of return is your profit divided by the original cost. This percentage could be negative (if your stock decreased in value) or positive (if your stock increased in value).

 #include <iostream>
#include <string>
#include <cmath>
#include <iomanip>
#include <cstdlib>
#include <ctime>

using namespace std;

int main()

{
	double stockSymbol, shares, sharePrice, commissionRate, shareCost, totalCost, commission;
	double percentGain, newSharePrice, newValue, sellCommission, profit, returnRate;
	int percentChange, profitLoss, flip;
	string companyName;
	const int MAX = 100, MIN = 1;
	

	cout << "\nPurchase Transaction: ";

	cout << "\nEnter company name: ";
	cin.ignore();
	getline(cin, companyName);

	cout << "\nEnter stock symbol: ";
	cin >> stockSymbol;

//The program won't allow me to enter any in for price per share and number of shares
	cout << "\nEnter the number of shares purchased: ";
	cin >> shares;

	cout << "\nEnter purchase price per share: ";      

	cin >> sharePrice;

	cout << "\nEnter commission rate ex 1% as 0.01";
	cin >> commissionRate;
	commission = commissionRate * sharePrice;
	shareCost = shares * sharePrice;
	totalCost = (commission * shareCost) + shareCost;
	
	cout << setprecision(1) << fixed; 
	cout << "\nCost of shares = $" << shareCost;
	cout << "\nCommission rate = " << commissionRate;
	cout << "\nCommission charged = $" << commission;
	cout << "\nTotal cost of purchase = $" << totalCost;

// I'm not sure if I'm entering the percentChange in correctly
	unsigned seed = time(0);
	srand(seed);
	percentChange = (rand() % (MAX - MIN + 1)) + MIN / 100;

//I entered the flip code verbatim what the directions said (I'm not sure that looks correct)
	 flip = rand() % 2 + 1;
	if (flip == 1)profitLoss = 1;
	else profitLoss = -1;

	percentGain = percentChange * profitLoss;

	newSharePrice = (percentGain * sharePrice) + sharePrice;

	newValue = newSharePrice * shares;


	sellCommission = commission * newValue;

//#12 The profit ,loss> section of the directions is confusing, I'm not sure what my professor is asking for.

	profit = 

	returnRate = profit / sharePrice;
	cout << "\nThe simulated projected profit <loss> of the sale of your shares is";

	cout << "\nNew share price is $" << newSharePrice;
	cout << "\nNew value of your stock is $" << newValue;

	cout << "\nAfter selling " << companyName << "\nyou recieved $" << sellCommission;

	cout << "\nThe profit <loss> is $" << 


	system("pause");
	return (0);
}

[TheIdeasMan]

Hi,

Use // for comments.

I added some cin.ignore(100,'\n'); after the cin statements. The code compiled and ran but didn't give a good answer.

I had trouble to start with, I didn't realise from the prompts that stockSymbol was a double. Should that be a std::string?

With your variables, delay the declaration of them until you have a value to assign to them. This helps avoid uninitialised variables and is easier to read.

Edit:

Should use cin.ignore(std::numeric_limits<std::streamsize>::max() ) Remeber to #include <limits>

[SiliconPatriot]

@TheIdeasMan yes stockSymbols should be a string I missed that. Thanks for the assistance and the suggestions.

[dhayden]

You declare percentChange as a in int but then you compute the value as a fraction on line 52. You should declare it as a double. Also line 52 is wrong. The compiler sees:
percentChange = (rand() % (MAX - MIN + 1)) + MIN / 100; which is the same as
percentChange = (rand() % (MAX - MIN + 1)) + (MIN / 100);
So as a first step it should be
percentChange = (rand() % (MAX - MIN + 1) + MIN) / 100;
This is still wrong because it does integer division, which will always round the fraction down to 0. You need to cast one of the arguments to a double so it should be:
percentChange = (rand() % (MAX - MIN + 1) + MIN) / 100.0;

Part of the problem you're having with the profit is that you need another variable. Create a new double called totalSaleAmt and store in it the net amount that the investor receives after selling the stock. Then line 70 will be
profit = totalCost - totalSaleAmt;

To help with your testing, temporarily make the percentGain a constant. You can do this by adding at line 53:
percentGain = 0.25;

There are several other problems with your math but I'll let you figure those out. With percentGain fixed at 25%, and a few more lines of output, here is what you should get:

Purchase Transaction:
Enter company name: Netflix

Enter stock symbol: NFLX

Enter the number of shares purchased: 100

Enter purchase price per share: 15

Enter commission rate ex 1% as 0.01: 0.1

Cost of shares = $1500.0
Commission rate = 0.1
Commission charged = $150.0
Total cost of purchase = $1650.0

The simulated projected profit <loss> of the sale of your shares is
Simulated gain is 25.0%
New share price is $18.8
New value of your stock is $1875.0
The sales commission is $187.5
After selling Netflix
you recieved $1687.5
The profit <loss> is $37.5
which is 2.3%