search by name problem

hey smart guys
these are my codes and everything is work correctly just void search by name doesnt work
anybody to tell me why?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
#include <iostream>
#include <conio.h>
#include <string.h>
#include <stdlib.h>
using namespace std;

class student{
	
	private:
		
		int code;
		string name;
		string lastname;
		
	public:
		
		student();
		
		int getcode(){
			
			return code;
		}
		
		void setcode(int newcode){
			
			code=newcode;
		}
		
		string getname(){
			
			return name;
		}
		
		void setname(string newname){
			
			name=newname;
		}
		
		string getlastname(){
			
			return lastname;
		}
		
		void setlastname(string newlastname){
			
			lastname=newlastname;
		}
};


student *data[5];
int counter=0;

void getdata();
void print();
void sortbycode();
void sortbyname();
void sortbylastname();
void searchbycode();
void searchbyname();

int main(){
	
	int op;
	
	while(true){
		system("cls");
		cout<<"1- input 2- print 3- sort by code 4- sort by name 5- sort by lastname 6- search by code\n";
		cin>>op;
		
		switch(op){
			
			case 1:{
				data[counter]=new student();
				getdata();
				break;
			}
			
			case 2:print();
			break;
			
			case 3:sortbycode();
			break;
			
			case 4:sortbyname;
			break;
			
			case 5:sortbylastname();
			break;
			
			case 6:searchbycode();
			break;
		}
	}
	
	return 0;
}

student::student(){
	
	code;
	name;
	lastname;
}

void getdata(){
	
	int tempcode;
	string tempstring;
	
	cout<<"enter code: ";
	cin>>tempcode;
	
	data[counter]->setcode(tempcode);
	
	cout<<"enter name: ";
	cin>>tempstring;
	
	data[counter]->setname(tempstring);
	
	cout<<"enter lastname: ";
	cin>>tempstring;
	
	data[counter]->setlastname(tempstring);
	
	counter++;
}

void print(){
	
	for(int i=0;i<counter;i++){
		
		cout<<"\n______________________________________\n";
		
		cout<<"code is: "<<data[i]->getcode()<<endl;
		cout<<"name is: "<<data[i]->getname()<<endl;
		cout<<"lastname is: "<<data[i]->getlastname()<<endl;
	}
	getch();
}

void sortbycode(){
	
	student *temp=new student();
	
	for(int i=0;i<counter;i++){
		
		for(int j=0;j<i;j++){
			
			if(data[j]->getcode()>data[j+1]->getcode()){
				
				temp=data[j];
				data[j]=data[j+1];
				data[j+1]=temp;
			}		
		}
	}
}

void sortbyname(){
	
	student *temp=new student();
	
	for(int i=0;i<counter;i++){
		
		for(int j=0;j<i;j++){
			
			if(data[j]->getname()>data[j+1]->getname()){
				
				temp=data[j];
				data[j]=data[j+1];
				data[j+1]=temp;	
			}	
		}	
	}
}

void sortbylastname(){
	
	student *temp=new student();
	
	for(int i=0;i<counter;i++){
		
		for(int j=0;j<i;j++){
			
			if(data[j]->getlastname()>data[j+1]->getlastname()){
				
				temp=data[j];
				data[j]=data[j+1];
				data[j+1]=temp;	
			}	
		}
	}
}

void searchbycode(){
	
	int codesearch,key=-1;
	
	cout<<"enter code to serach: ";
	cin>>codesearch;
	
	for(int i=0;i<counter;i++){
		
		if(data[i]->getcode()==codesearch){
			
			key=i;
		}
		if(key==-1){
			
			cout<<"Not Find";
		}
		else{
			
			cout<<"Find\n"<<"code is: "<<data[key]->getcode()<<"\nname is: "<<data[key]->getname()<<"\nlastname is: "<<data[key]->getlastname();
		}
	}
	getch();
}

void searchbyname(){
	
	string namesearch;
	int key=-1;
	
	cout<<"enter name to search: ";
	cin>>namesearch;
	
	for(int i=0;i<counter;i++){
		
		if(strcmp(data[i]->getname(),namesearch)==0){
			key=i;
		}
	}
	if(key==-1){
			
			cout<<"Not Find";
		}
		else{
			
			cout<<"Find\n"<<"code is: "<<data[key]->getcode()<<"\nname is: "<<data[key]->getname()<<"\nlastname is: "<<data[key]->getlastname();
		}
		getch();
}
You can't use strcmp for strings. if(strcmp(data[i]->getname(),namesearch)==0)

Use
1
2
3
4
if (data[i]->getname() == namesearch)
{
   // display found message
}
thank you so much
my problem is sloved
so we just using strcmp for char?
so we just using strcmp for char?


Actually you can only compare two const char* with strcmp.
http://www.cplusplus.com/reference/cstring/strcmp/
Actually you use strcmp() to compare two C-strings, not single characters.
Topic archived. No new replies allowed.