sorting string members in an array of struct

[antonyt]

i am having trouble with the sortName function as it is not sorting the strings.I am weak on string sorting, havent done much work with it. Not sure what i am doing wrong. Any feedback will help me greatly thanks!

  #include <iostream>
#include <string>
using namespace std;

struct stuInfo
				{	string name;
					int idNum;
					float cExamGrade,
						  pExamGrade,
						  overallGPA;
				};

void sortName(stuInfo array[],int size);
void sortID(stuInfo array[],int size );
void sortcExam(stuInfo array[],int size);
void sortpExam(stuInfo array[],int size);
void sortOverallGPA(stuInfo array[],int size);

int main(){
	
	int arraySize,
		choice;
		
	cout<<"How many students are there?: ";
	cin>>arraySize;
	
	stuInfo info[arraySize];
	
	cout<<"Enter the information specified.\n"<<endl;
	
	for(int i=0 ;i<arraySize;i++){
		
		cin.ignore();
		cout<<"\nName for student "<<i+1<<": ";
		getline(cin,info[i].name);
		
		cout<<"ID number: ";
		cin>>info[i].idNum;
		
		cout<<"Current exam grade: ";
		cin>>info[i].cExamGrade;
		
		cout<<"Prior exam grade: ";
		cin>>info[i].pExamGrade;
		
		cout<<"Overall GPA: ";
		cin>>info[i].overallGPA;
	}
	
	cout<<"\nSelect what you would like to sort\n"
		<<"----------------------------------\n"
		<<"1 for name\n"
		<<"2 for ID number\n"
		<<"3 for current exam grade\n"
		<<"4 for prior exam grade\n"
		<<"5 for overall GPA\n"
		<<"6 for no sort\n\n"
		<<"Enter: ";
		
	cin>>choice;
	
	switch(choice)
	{
		case 1 :
			sortName(info,arraySize);
			break;
		case 2 :
			sortID(info,arraySize);
			break;
		case 3:
			sortcExam(info,arraySize);
			break;
		case 4:
			sortpExam(info,arraySize);
			break;
		case 5:
			sortOverallGPA(info, arraySize);
			break;
		case 6:
			cout<<"EXITED";
			return 0;
			break;
		default:
			while(choice<1 && choice>6)
			{
				cout<<"Enter valid choice: ";
				cin>>choice;
			}
			
		
	}
	
}
void sortName(stuInfo array[],int size )
{
	bool swap;
	string temp;
	
	do
	{
		swap = false;
		for(int i= 0; i<(size-1);i++)
		{	
			if (array[i].name>array[i+1].name)
			{
				temp=array[i].name;
				array[i].name=array[i+1].name;
				array[i+1].name=temp;
				swap=true;
			}
		}
	}while(swap);
	
	for(int i=0;i<size;i++)
	{
		cout<<array[i].name<<endl;
	}
}
void sortID(stuInfo array[],int size )
{
	bool swap;
	float temp;
	
	do
	{
		swap = false;
		for(int i= 0; i<(size-1);i++)
		{	
			if (array[i].idNum>array[i+1].idNum)
			{
				temp=array[i].idNum;
				array[i].idNum=array[i+1].idNum;
				array[i+1].idNum=temp;
				swap=true;
			}
		}
	}while(swap);
	
	for(int i=0 ; i<size; i++)
	{
		cout<<array[i].idNum<<endl;
	}
}
void sortcExam(stuInfo array[],int size )
{
		bool swap;
	float temp;
	
	do
	{
		swap = false;
		for(int i= 0; i<(size-1);i++)
		{	
			if (array[i].cExamGrade>array[i+1].cExamGrade)
			{
				temp=array[i].cExamGrade;
				array[i].cExamGrade=array[i+1].cExamGrade;
				array[i+1].cExamGrade=temp;
				swap=true;
			}
		}
	}while(swap);
	
	for(int i=0 ; i<size; i++)
	{
		cout<<array[i].cExamGrade<<endl;
	}
}
void sortpExam(stuInfo array[],int size )
{
		bool swap;
	float temp;
	
	do
	{
		swap = false;
		for(int i= 0; i<(size-1);i++)
		{	
			if (array[i].pExamGrade>array[i+1].pExamGrade)
			{
				temp=array[i].pExamGrade;
				array[i].pExamGrade=array[i+1].pExamGrade;
				array[i+1].pExamGrade=temp;
				swap=true;
			}
		}
	}while(swap);
	
	for(int i=0 ; i<size; i++)
	{
		cout<<array[i].pExamGrade<<endl;
	}
}
void sortOverallGPA(stuInfo array[],int size )
{
		bool swap;
	float temp;
	
	do
	{
		swap = false;
		for(int i= 0; i<(size-1);i++)
		{	
			if (array[i].overallGPA>array[i+1].overallGPA)
			{
				temp=array[i].overallGPA;
				array[i].overallGPA=array[i+1].overallGPA;
				array[i+1].overallGPA=temp;
				swap=true;
			}
		}
	}while(swap);
	
	for(int i=0 ; i<size; i++)
	{
		cout<<array[i].overallGPA<<endl;
	}
}

[cire]

i am having trouble with the sortName function as it is not sorting the strings.

You want to sort an array of objects based on one aspect (in this case the name) of those objects. You do not want to sort strings.

[Mort88]

As I'm reading your coding, it is a bit confusing because you are using variable names that are keywords which is not suggested to do. Swap is a function on its own and shouldn't be used as a variable name, array as well. It makes your code unclear on what your actual intent is for the program rather it is suppose to be used or it's just a variable name. Because we have so many functions that are wanting to use the Struct. It is best to use Classes and make them public (Not suggested) and then you can add in codes for the classes and calling them is much easier. You'll find it easier to work with classes for something like this. Structs. are used to keep data members mostly. But if you need to set and get them then a class is the way to go.

Another thing for struct and classes is you want to identify them a bit easier such as m_variable name. So that away a programmer knows they are working with a data member. I keep having to scroll up and down to see what variable I'm working with and how it's being called and set. I would suggest re-writing the code since you're working with structs. just know that they are like classes expect classes by default are private and structs. by default is public. Make yourself a Header file for your struct. if you plan on still using it. It makes reading your code much easier.

[cire]

Because we have so many functions that are wanting to use the Struct. It is best to use Classes

The use of struct and class are practically identical.

Another thing for struct and classes is you want to identify them a bit easier such as m_variable name. So that away a programmer knows they are working with a data member. I keep having to scroll up and down to see what variable I'm working with and how it's being called and set.

I don't know why you would need to "scroll" here. If it is preceded by a . it's a member.