Help with infinite loop

[nowakdal]

Hi, I'm trying to write a small game called Pig the Dice. The description of the game can be found here: http://rosettacode.org/wiki/Pig_the_dice_game

I've been trying to understand over the past hour why, when the die rolls a one, an infinite loop occurs. I cannot understand why this happens, because I broke the loop by returning a value when a one shows up.

The problem should be somewhere in the turn() function. Any help/suggestions pointing me in the right direction would be greatly appreciated!! It's my first time posting here so go easy on me! Thanks!!

#include <iostream>
#include <cstdlib>
#include <ctime>
using std::cout; using std::endl; using std::cin;

int dice_throw() {
	
	srand(time(0));
	
	int result = (rand() % 6) + 1;
	
	return result;
}


int turn() { 
	
	int player_turn_score = 0;
	bool play = true;
	int player_choice;
	
	while(play == true) {
	int roll = dice_throw();
	
	if (roll == 1) {
	
	cout << "Uh Oh! You rolled a one! You lose all your points for this round!" << endl;
	play = false;
	player_turn_score = 0;
	return player_turn_score;
	
	}
	
	player_turn_score = player_turn_score + roll;
	
	cout << "You rolled a " << roll << " and have scored " << player_turn_score << " points this round! " << endl; 
	
	cout << "Do you want to roll again (0 for no, 1 for yes)?: ";
	cin >> player_choice;
	
	if (player_choice == 0) {
		
		play = false;
		
		return player_turn_score;
		}
	else {
			continue;
			}
	
}
	return player_turn_score;
	}

int main(){
	
	int player1_total_score = 0;
	int player2_total_score = 0;
	int turn_points = 0;
	
	while ( ( player1_total_score < 100 ) || (player2_total_score < 100) ) { 
	
	cout << "It's player one's turn!" << endl;
	turn_points = turn();
	cout << "Player one scored " << turn_points << " points this round! " << endl;
	player1_total_score = player1_total_score + turn_points;
	cout << "Player one has a total of " << player1_total_score << " points in the game! " << endl;
	
	cout << "It's player two's turn!" << endl;
	turn_points = turn();
	cout << "Player two scored " << turn_points << " points this round! " << endl;
	player2_total_score = player2_total_score + turn_points;
	cout << "Player two has a total of " << player2_total_score << " points in the game! " << endl;
	
}
	
	cout << "Player one's score: " << player1_total_score << endl;
	cout << "Player two's score: " << player2_total_score << endl;
	
	if (player2_total_score > player1_total_score) {
		
		cout << "Player 2 wins!" << endl;
		
		}
		
	if (player1_total_score > player2_total_score) {
		
		cout << "Player 1 wins!" << endl;
		
		}
		
	else {
		cout << "Tie!" << endl;
		}
	
	
	return 0;

} 

[YFGHNG]

In your turn() function, get rid of all return statements except for the last one. Also it's bad habits to have more than one return statement per function, unless you deem it absolutely necessary.

[Mort88]

Getting rid of all the return statements expect the last one in your turn() function will fix a lot of your looping issues. on line 28, you don't need to set the bool value to false as it's already set to it. So you want to get rid of that. When the player enters the true statement is when it will break to the next loop for the second player to enter. Since you are starting out in programming, it is a good practice to start doing camel casing much as you can. As the underscore can represent other things when using it like, IE: Classes. So for int's you wanna do like this "myInt".

The program looks good. Another popular style to write your functions is proto-typing them. Makes it much easier to read your main and if there is an issue with a function we can look for it other than that most programmers will assume the function was written correctly and don't have to read through the function unless needed to.