small++ large-1

[nuttsy]

Write your question here.
Hi, I am having trouble with the count calculators for this code - small++; large-1; Can someone see what i have done wrong?

  #include <iostream>

int main()
{
    using namespace std;
    unsigned short small;
    unsigned long large;
    const unsigned short MAXSMALL=65535;
    
    cout << "Enter a small number: ";
    cin >> small;
    cout << "Enter a large number: ";
    cin >> large;
    
    cout << "small:" << small << "...";
    
    //for each iteration, test two conditions
    while (small < large && small < MAXSMALL)
    {
       if (small % 5000 == 0) //write a dot every 5k lines
           cout << ".";
        
        small++;
        large-1;<#statements#>
    }
    cout << "\nSmall: " << small << " Large: " << large << endl;
    return 0;
}

[TarikNeaj]

Just like small++; it's large--;

[Chervil]

large-1; doesn't actually do anything. Well, it calculates a result, but doesn't store it or use it in any way.

Did you mean to put large--; or the equivalent large = large-1; ?


By the way, instead of

    const unsigned short MAXSMALL=65535;

it is safer to write

    const unsigned short MAXSMALL = std::numeric_limits<unsigned short>::max();

and let the system supply the appropriate value.
remember to add #include <limits>

http://www.cplusplus.com/reference/limits/numeric_limits/