is this code correct?

[shadowvillian]

im trying to make random numbers and i was wondering if this code is right.

include

#include <ctime>
#include <cstdlib> 

srand((unsigned)time(0));
int Random; 
Random = (rand()%4+1); //generate number 1-4  

[R0mai]

correct

[gcampton]

yep, just don't use multiples of srand throughout your code. and that means in no loops. Typically putting up with your variable declarations is best place.

[gcampton]

#include <iostream>
#include <ctime>
#include <cstdlib>

using namespace std;

int getRandNum(int);

int main()
{
    srand(time(NULL));
    int number;

    for ( int i=0; i<10; i++ )
    {
        number = getRandNum(50); // get a number from 1-50
        cout << number << "\n";
    }

    cout << endl;
    return 0;
}

int getRandNum(int numbOutOf)
{
    return (rand() % numbOutOf + 1);
}

[R0mai]

Returns a number in range [min,max). (min inclusive, max exclusive)

int random(int min, int max) {
    return std::rand()%(max-min)+min;
}

[shadowvillian]

thanks for the tip gcampton, i never knew that. can i put line 3 on more than one line?

[gcampton]

if you mean rand() yea, you can have as many as you want.. However a function like the one ROmai or I posted would be better as it's LESS upkeep long term.

But yea just keep the srand((unsigned)time(NULL)) in a simple selection of code. you can keep it in int main() if you have your rand() in another class, or perhaps just put it in the driver of that class.
Up to you, you can actually have multiples if you wish (there's no reason to), but just don't put them where your calling rand() from. for example this would be the WRONG way to go about this function:

int getRandNum(int min, int max)
{
    srand(time(NULL));
    return rand() % (max-min) + min;
}