help with finding bugs

[learningcplusplus898]

program works fine, just would like help with spotting bugs and removing them.
also need to find out how to stop the song that plays when alarm goes off.

there is a little more work to do i know that, wanting to get it bug free before i finish the smaller details.

thanks

# include <iostream>
# include <iomanip>
# include <fstream>
# include <conio.h>
# include <ctime>
# include <string.h>
# include <string>
# include <windows.h>

using namespace std;

struct Alarm
{
	int alarmCounter;  // max 3 alarms
	int HourAlarm;
	int MinuteAlarm;
	int DayAlarm;
	int MonthAlarm;
	int YearAlarm;

	char password[20];
	int emptyCounter;
};

const char FILE_PATH[] = "F:\\alarm.txt";
const char FILE_PATH2[] = "F:\\password.txt";    //have password in main file, can move to another file when working

fstream MyFile( FILE_PATH, ios :: binary | ios :: in | ios :: out );
fstream MyFile2( FILE_PATH2, ios :: binary | ios :: in | ios :: out );

void createFile();
void displayMenu();
void switchFunction();
void addAlarm();
void changeAlarm();
void displayAlarms();
int checkAlarmCounter();
int checkPassword( char[] );
void createEmptyPassword();
void startClock();
void pause( int );

int main()
{
	char password[20] = {"abc"};    //if month is this then password is diff.

	Alarm temp;
	system("COLOR 0A");
	system("CLS");

	//PlaySound("D:\\Wide_Awake.wav",NULL,SND_FILENAME|SND_LOOP|SND_ASYNC);

	createFile();

	createEmptyPassword();

	MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	int checkedPass = 0;
	checkedPass = checkPassword( temp.password );

	if( checkedPass == 1 )
	{
		while( strcmp( temp.password, password ) == 0 )
		{
			switchFunction();
		}
	}
	if( checkedPass == 4 )
	{
		switchFunction();
	}

	if( checkedPass == 2 )
	{
		cout << "enter password to continue: ";
		cin >> temp.password;

		while( strcmp ( temp.password, password ) != 0 )
		{
			cout << "error: wrong password\n"
				  << "enter new password: ";
			cin >> temp.password;
		}
	}

	else
		if( checkedPass == 3 )
		{
			cout << "\n\aError: with password. \n\a";
		}

	system("CLS");
	cout << "GoodBye!";
	getch();

	MyFile2.close();
	MyFile.close();
	return 0;
}
//-------------------------------------------------------------------------
void createFile()
{
	if ( ! MyFile )
	{
		fstream MyFile( FILE_PATH, ios :: binary | ios :: out );
	}
	MyFile.close();

	if ( ! MyFile2 )
	{
		fstream MyFile2( FILE_PATH2, ios :: binary | ios :: out );
	}
	MyFile2.close();
}
//--------------------------------------------------------
int checkPassword( char inputPassword[] )
{
	char password[20] = {"abc"};    // if month is this then password is diff.

	Alarm temp;
	MyFile.open( FILE_PATH, ios :: binary | ios :: in );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	int returnCorrect = 1;
	int returnWrong = 2;
	int error = 3;
	int continueWithProgram = 4;

	while( !MyFile.eof() )
	{
		if( strcmp( temp.password, "EMPTY" )== 0 )
		{
			cout << "Enter new password to save to file ";
			cin >> temp.password;
			while( strcmp( temp.password, password ) != 0 )
			{
				cout << "error: incorrect password attempt to save to file.\n"
					  << "please try again. ";
				cin >> temp.password;
			}
				MyFile.close();

				temp.emptyCounter = 1;
				MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
				MyFile.clear();
				MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );
				MyFile.close();

			return continueWithProgram;
		}

		if( strcmp( temp.password, password )== 0 )
		{
			cout << "\n\ncorrect password in file.\n\n" ;
			return returnCorrect;
		}
		else
			if( strcmp( temp.password, password )!= 0 )
			{
				cout << "\n\nwrong password in file\n\n";
				return returnWrong;
			}
		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}

	cout << "Error: courrupt files, delete them. "; getch();
	return error;
}
//--------------------------------------------------------------------
void displayMenu()
{
	cout << "do you want to add a new alarm time or change one?" << endl
		  << "\tpress 'd' to display alarms " << endl
		  << "\tpress 'a' to add " << endl
		  << "\tpress 'c' to change " << endl
		  << "\tpress 's' to start clock" << endl << endl;
}
//-------------------------------------------------------------
void switchFunction()
{
	char choice;

	displayMenu();
	choice = getch();

	while( choice != 27 )
	{
		switch ( choice )
		{
			case 'a':
			case 'A':
				addAlarm();
				break;

			case 'c':
			case 'C':
				changeAlarm();
				break;

			case 'd':
			case 'D':
				displayAlarms();
				break;

			case 's':
			case 'S':
				startClock();
				break;

			default:
				cout << "error:";
		}

		displayMenu();
		choice = getch();
	}
}
//----------------------------------------------------------
void addAlarm()
{
	Alarm temp;
	MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	int alarmCount = 0;

	alarmCount = checkAlarmCounter();

	cout << "\n\n" << alarmCount << "\n\n";

	if( alarmCount == 2 )
	{
		system("CLS");
		cout << "\aError: with alarm count\n";
	}

	while( !MyFile.eof() )
	{
		if( temp.alarmCounter < 4 )
		{
			if( temp.alarmCounter == 0 )
			{
				MyFile.close();
				cout << "enter first alarm hour: ";
				cin >> temp.HourAlarm;

				while( temp.HourAlarm > 24 || temp.HourAlarm < 0 )
				{
					cout << "Error: enter hours within range 0-24 \n\n"
						  << "enter first alarm hour: ";
					 cin >> temp.HourAlarm;
				}

				cout << "enter first alarm minute: ";
				cin >> temp.MinuteAlarm;

				while( temp.MinuteAlarm  > 59 || temp.MinuteAlarm < 0 )
				{
					cout << "Error: enter minutes within range 0-59 "
						  << "enter first alarm minute: ";
					 cin >> temp.MinuteAlarm;
				}

				temp.alarmCounter++;
				cout << "\nAlarm Count is: " << temp.alarmCounter << "\n" ;

				MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
				MyFile.seekg( ( 1 - 1 ) * sizeof( Alarm ) );
				MyFile.clear();
				MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );

				MyFile.close();
			}

			if( temp.alarmCounter <= 2 || temp.alarmCounter != 1 || temp.alarmCounter != 3)
			{
				MyFile.close();

				cout << "enter second alarm hour: ";
				cin >> temp.HourAlarm;

				while( temp.HourAlarm > 24 || temp.HourAlarm < 0 )
				{
					cout << "Error: enter hours within range 0-24 \n\n"
						  << "enter second alarm hour: ";
					cin >> temp.HourAlarm;
				}

				cout << "enter second alarm minute: ";
				cin >> temp.MinuteAlarm;

				while( temp.MinuteAlarm  > 59 || temp.MinuteAlarm < 0 )
				{
					cout << "Error: enter minutes within range 0-59 "
						  << "enter second alarm minute: ";
					cin >> temp.MinuteAlarm;
				}

				temp.alarmCounter++;
				cout << "\nAlarm Count is: " << temp.alarmCounter << "\n" ;

				MyFile.open( FILE_PATH, ios :: binary | ios :: app );
				MyFile.clear();
				MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );
				MyFile.close();
			}

			if( temp.alarmCounter <= 3 || temp.alarmCounter != 1 || temp.alarmCounter != 2 )
			{
				MyFile.close();

				cout << "enter third alarm hour: ";
				cin >> temp.HourAlarm;

				while( temp.HourAlarm > 24 || temp.HourAlarm < 0 )
				{
					cout << "Error: enter hours within range 0-24 \n\n"
						  << "enter third alarm hour: ";
					cin >> temp.HourAlarm;
				}

				cout << "enter third alarm minute: ";
				cin >> temp.MinuteAlarm;

				while( temp.MinuteAlarm  > 59 || temp.MinuteAlarm < 0 )
				{
					cout << "Error: enter minutes within range 0-59 "
						  << "enter third alarm minute: ";
					cin >> temp.MinuteAlarm;
				}

				temp.alarmCounter++;
				cout << "\nAlarm Count is: " << temp.alarmCounter << "\n" ;

				MyFile.open( FILE_PATH, ios :: binary | ios :: app );
				MyFile.clear();
				MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );
				MyFile.close();
			}
		}
		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}
	MyFile.close();
}
//---------------------
//next slide. 

[learningcplusplus898]

void changeAlarm()
{
	Alarm temp;
	int changeAlarm = 0;
	int yesNo = 0;
	int update = 0;
	int exitCorrectly = 0;

	MyFile.open( FILE_PATH, ios :: binary | ios :: in );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	cout << "enter alarm number to change ";
	cin >> changeAlarm;


	while( !MyFile.eof() && exitCorrectly != 1 )
	{
		if( temp.alarmCounter == changeAlarm )
		{
			MyFile.close();
			system("CLS");

			cout << "H " << temp.HourAlarm << " M " << temp.MinuteAlarm << "\n";

			MyFile.seekg( ( changeAlarm - 1 ) * sizeof( Alarm ) );

			cout << " is this the alarm you are wanting to change? "

				 << endl << " 'y' yes or 'n' no "
				 << endl << endl;
			yesNo = getch();

			switch( yesNo )
			{
				case 'y':
				case 'Y':
					cout << "\npress 'h' to change hour"
						  << "\npress 'm' to change minutes\n";

					update = getch();

					switch( update )
					{
						case 'h':
						case 'H':
							cout << "enter new hour: ";
							cin >> temp.HourAlarm;
							break;

						case 'm':
						case 'M':
							cout << "enter new minutes: ";
							cin >> temp.MinuteAlarm;
							break;

						default:
							cout << "ERROR: invalid choice" << endl;
					}
					system("CLS");
					cout << "Updateing details" << endl; _getch();

					MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
					MyFile.clear();
					MyFile.seekg( ( changeAlarm - 1 ) * sizeof( Alarm ) );
					MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );

					MyFile.close();
					break;

				case 'n':
				case 'N':
					system("CLS");
					cout << "CANCLED\n";
					exitCorrectly = 1;

					MyFile.close();
					break;


				default:
					cout << "ERROR: invalid choice" << endl;
					exitCorrectly = 1;
			}
		}
		if( temp.alarmCounter != changeAlarm )
		{
			system("CLS");
			cout << "Error: Not found ! \n";
			//MyFile.close();
		}
		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}
	MyFile.close();
}
//-----------------------------
void displayAlarms()
{
	Alarm temp;
	MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	system("CLS");
	cout << "\n\n";

	while( !MyFile.eof() )
	{
		cout << "\nAlarm Count is: " << temp.alarmCounter << "\n" ;

		cout << "H " << temp.HourAlarm << " M " << temp.MinuteAlarm << "\n";

		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}
	MyFile.close();
}
int checkAlarmCounter()
{
	MyFile.close();

	Alarm temp;
	int correct = 1;
	int error = 2;
	int MAX = 3;

	MyFile.open( FILE_PATH, ios :: binary | ios :: in );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	while( ! MyFile.eof() )
	{
		if( temp.alarmCounter > MAX  || temp.alarmCounter == 0 )
		{
			return correct;
		}

		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}

	MyFile.close();
	return error;
}
void createEmptyPassword()
{
	Alarm temp;
	MyFile.open( FILE_PATH, ios :: binary | ios :: in );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	if( strcmp( temp.password, "EMPTY" ) == 0 && temp.emptyCounter == 1 )
	{
		cout << "\n File not Empty \n";
	}

	else
		if( strcmp( temp.password, "EMPTY" ) != 0 && temp.emptyCounter != 1 )
		{
			MyFile.close();

			cout << "\n File Empty First time opening file \n";
			strcpy( temp.password, "EMPTY" );
			temp.emptyCounter = 1;

			temp.alarmCounter = 0;
			temp.HourAlarm = 0;
			temp.MinuteAlarm = 0;

			MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
			MyFile.clear();
			MyFile.seekg( ( 1 - 1 ) * sizeof( Alarm ) );
			MyFile.write( ( const char* ) &temp, sizeof( Alarm ) );
			MyFile.close();
		}

}
void startClock()
{
	Alarm temp;
	MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
	MyFile.clear();
	MyFile.seekg( 0, ios :: beg );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	time_t currentTime;
	struct tm *localTime;

	time( &currentTime );
	localTime = localtime( &currentTime );

	int Day    = localTime->tm_mday;
	int Month  = localTime->tm_mon + 1;
	int Year   = localTime->tm_year + 1900;
	int Hour   = localTime->tm_hour;
	int Min    = localTime->tm_min;
	int Sec    = localTime->tm_sec;

	int alarmToRun = 0;
	int runYesNo = 0;
	int yesNo = 0;
	int pleaseWait = 1;
	int pleaseWait2 = 0;

	cout << "what alarm do you want to run? ";
	cin >> alarmToRun;

	while( !MyFile.eof() )
	{
		if( temp.alarmCounter == alarmToRun )
		{
			cout << "is this the alarm you would like to run?\n"
				  << "'y' yes, 'n' no \n "
				  << "H " << temp.HourAlarm << " M " << temp.MinuteAlarm << "\n";
			runYesNo = getch();

			switch( runYesNo )
			{
				case 'y':
				case 'Y':
					yesNo = 1;
					break;

				case 'n':
				case 'N':
					yesNo = 0;
					break;

				default:
					cout <<"\n\nError: with alarm to run.\n\n";
			}
		}
		MyFile.read( ( char* ) &temp, sizeof( Alarm ) );
	}
	MyFile.close();

	MyFile.open( FILE_PATH, ios :: binary | ios :: in | ios :: out );
	MyFile.clear();
	MyFile.seekg( ( alarmToRun - 1 ) * sizeof( Alarm ) );
	MyFile.read( ( char* ) &temp, sizeof( Alarm ) );

	cout << "you selected: ";
	if( yesNo == 1 )
	{
		cout << "yes\n"
			  << "current system time is: H " << Hour << " M " << Min << " \n\n";

		while( pleaseWait == 1 )
		{
			time_t currentTime;
			struct tm *localTime;

			time( &currentTime );
			localTime = localtime( &currentTime );

			int Day    = localTime->tm_mday;
			int Month  = localTime->tm_mon + 1;
			int Year   = localTime->tm_year + 1900;
			int Hour   = localTime->tm_hour;
			int Min    = localTime->tm_min;
			int Sec    = localTime->tm_sec;

			pleaseWait2++;

			if( pleaseWait2 % 2 == 0 )
			{
				system("CLS");
				cout << "please Wait for alarm.\n";

				cout << "current system time is: H " << Hour << " M " << Min << " S " << Sec << " \n\n";
				cout << "Your alarm is: H " << temp.HourAlarm << " M " << temp.MinuteAlarm << "\n\n";
				pause(1);
			}
				if( pleaseWait2 % 2 == 1 )
				{
					system("CLS");

					cout << "please Wait for alarm..\n";
					cout << "current system time is: H " << Hour << " M " << Min << " S " << Sec << " \n\n";
					cout << "Your alarm is: H " << temp.HourAlarm << " M " << temp.MinuteAlarm << "\n\n";
					pause(1);
				}

			if( Min == temp.MinuteAlarm && Hour == temp.HourAlarm )
			{
				system("CLS");
				cout << "current system time is: H " << Hour << " M " << Min << " \n\n";
				cout << "SUCCESS!!!";
				pleaseWait = 0;  //to make exit infinitfy loop

				PlaySound("D:\\Wide_Awake.wav",NULL,SND_FILENAME|SND_LOOP|SND_ASYNC);
				getch();
			}
		}
	}
	else
	{
		cout << "No\n";
	}

	cout << "exited loop\n\n";
	getch();

	PauseSound("D:\\Wide_Awake.wav",NULL,SND_FILENAME|SND_LOOP|SND_ASYNC);
	MyFile.close();
}
//---------------------------------------------
void pause( int dur )
{
	int temp = time(NULL) + dur;

	while(temp > time(NULL));
}

[48T7M4Gy]

If it's working fine, what makes you think your 600+ lines might contain bugs?

[learningcplusplus898]

when i try input parts where it requires numbers and i input letters. that breaks it.
i'm no professional programmer so i don't know "all" the bugs.

also how do i stop the song playing when the alarm reaches its timer?

[48T7M4Gy]

OK, but what I suggest you do is copy out the parts that don't work and concentrate on that sub unit.

Debugging is about the hardest part of programming and trying to do it with 600+ lines instead of a test unit of say 20 lines, is basically a waste of time.

Once you have the test unit show us that.

Cheers :)