2D array from txt file trouble, error message

[sep11]

I'm trying to create a program for class that will read data from a txt file and translate it into a 4x6 array, reading it line by line. I'm supposed to minimize global constants and use functions.

But I'm running into trouble. I've created a function with the idea/hope that it will load the array values for later use and manipulation. But I can't get to the point where it will compile. I need some pointer objects but I've gotten pretty lost.

I was trying to structure this program off one I did before that used a 1D array and functions. Clearly it doesn't translate completely and I haven't figured out how to code differently for it. I'm still pretty new at this. Any guidance would be much appreciated!

Here's my code:

#include <iostream>
#include <fstream>
#include <iomanip>
#include <string>
using namespace std;



int getARRAY(const int[][], int);
//void goal1
//void goal2
//void goal3(const int[][COLUMNS], int);
//void goal4(const int[][COLUMNS], int);


int main()
{
	const int COLUMNS = 6;
	const int ROWS = 4;	
	int ARRAY[ROWS][COLUMNS];


	cout << "The contents of the array are:\n";
	getARRAY;
	
	
	//goal1;
	//goal2;
	//goal3;
	//goal4;

	system("Pause");
	return 0;

}

int getARRAY(int[][], int ARRAY)
{
	fstream inputFile;

	inputFile.open("C:\\ExternalFiles\\exfile2DARRAY.txt");
	if (inputFile.fail())
	{
		cerr << "\a\a**Error opening input file.\n";
		exit(EXIT_FAILURE);
	}

	int count = 0;

	while (count < ARRAY[][] && inputFile >> ARRAY[count])
	{
		count++;
	}

	inputFile.close();
	return ARRAY[4][6];

}

[kbw]

The syntax is wrong, but before we get into fixing it, can you show what the content of the text file so we can better understand what you're trying to do?

[sep11]

So I've updated my code a bit though it still isn't quite right:

#include <iostream>
#include <fstream>
#include <iomanip>
#include <string>
using namespace std;



int getARRAY(const int[][6], int);
void showARRAY(int ARRAY[][6], int rows);


int main()
{
	const int COLUMNS = 6;
	const int ROWS = 4;	
	int ARRAY[ROWS][COLUMNS];


	cout << "The contents of the array are:\n";
	getARRAY(int ARRAY[][6], int ARRAY);

	system("Pause");
	return 0;
}

int getARRAY(int[][6], int ARRAY)
{
	fstream inputFile;
	ofstream outputFile;

	inputFile.open("C:\\ExternalFiles\\exfile2DARRAY.txt");
	if (inputFile.fail())
	{
		cerr << "\a\a**Error opening input file.\n";
		exit(EXIT_FAILURE);
	}

	int count = 0;

	while (count < ARRAY[][6] && inputFile >> ARRAY[count])
	{
		count++;
	}

	inputFile.close();
	return ARRAY[][6];

}

void showARRAY(int ARRAY[][6], int rows)
{
	ofstream outputFile;
	outputFile.open("C:\\ExternalFiles\\exfile2DARRAYout.txt");
	if (outputFile.fail())
	{
		cerr << "\a\a**Error opening output file.\n";
		exit(EXIT_FAILURE);
	}

	outputFile << "Content of this array:\n\n";
	for (int x = 0; x < 4; x++)
	{
		for (int y = 0; y < 6; y++)
		{
			cout << setw(8) << ARRAY[x][y] << " ";
		}
		outputFile << endl;
		outputFile.close();
	}
}

And here is the content of the file:
1 29 38 94 50 67
37 899 10 119 121 138
11 15 203 401 222 109
2 94 55 5 35 21

[Thomas1965]

You still have quite a few syntax errors:

1>main.cpp(21): error C2144: syntax error : 'int' should be preceded by ')'
1>main.cpp(21): error C2660: 'getARRAY' : function does not take 0 arguments
1>main.cpp(21): error C2059: syntax error : ')'
1>main.cpp(41): error C2059: syntax error : ']'
1>main.cpp(42): error C2143: syntax error : missing ';' before '{'
1>main.cpp(47): error C2059: syntax error : ']'

Here is a little example how to read the data and show it on the screen.
Maybe you can adopt ypur program.

#include <iostream>
#include <fstream>
#include <iomanip>
#include <string>
using namespace std;

const int COLUMNS = 6;
const int ROWS = 4;	

void getArray(int numbers[ROWS][COLUMNS]);
void showArray(int numbers[ROWS][COLUMNS]);


int main()
{
 int numbers[ROWS][COLUMNS];
 
  cout << "The contents of the array are:\n";
  cout << "==============================\n\n";
  getArray(numbers);
  showArray(numbers);
  cout << "\n==============================\n\n";
  system("Pause");
  return 0;
}

void getArray(int numbers[ROWS][COLUMNS])
{
  fstream inputFile;
  ofstream outputFile;

  inputFile.open("Numbers.txt");
  if (!inputFile)
  {
    cerr << "\a\a**Error opening input file.\n";
    exit(EXIT_FAILURE);
  }

  for (int row = 0; row < ROWS; row++)
  {
    for (int col = 0; col < COLUMNS; col++)
    {
      inputFile >> numbers[row][col];
    }
  }
}

void showArray(int numbers[ROWS][COLUMNS])
{
  for (int row = 0; row < ROWS; row++)
  {
    for (int col = 0; col < COLUMNS; col++)
    {
      cout << numbers[row][col] << '\t';
    }
    cout << endl;
  }


}

[sep11]

Ah. I see. Thank you for your guidance!!

[sep11]

Okay so I was able to fix some of the syntax problems for this, but now all that is showing up is the first line of the array.

How do I make the loop continue so that all 24 elements of the array are printed?

Here's my code:

int getARRAY(int numbers[4][6], int, int);
void showARRAY(int numbers[4][6], int, int);


int main()
{
	const int ROWS = 4;
	const int COLUMNS = 6;
	int numbers[ROWS][COLUMNS];

	getARRAY(numbers, ROWS, COLUMNS);

	cout << "\n\n\tSee files in C:\\ExternalFiles for output.\n\n\n";
	showARRAY(numbers, ROWS, COLUMNS);

	system("Pause");
	return 0;
}

int getARRAY(int numbers[4][6], int ROWS, int COLUMNS)
{
	fstream inputFile;
	ofstream outputFile;

	inputFile.open("C:\\ExternalFiles\\exfile2DARRAY.txt");
	if (inputFile.fail())
	{
		cerr << "\a\a**Error opening input file.\n";
		exit(EXIT_FAILURE);
	}

	for (int x = 0; x < ROWS; x++)
	{
		for (int y = 0; y < COLUMNS; y++)
		{
			inputFile >> numbers[x][y];
		}
	}

}

void showARRAY(int numbers[4][6], int ROWS, int COLUMNS)
{
	ofstream outputFile;
	outputFile.open("C:\\ExternalFiles\\exfile2DARRAYout.txt");
	if (outputFile.fail())
	{
		cerr << "\a\a**Error opening output file.\n";
		exit(EXIT_FAILURE);
	}

	outputFile << "Content of this array:\n\n";


	for (int x = 0; x < ROWS; x++)
	{
		for (int y = 0; y < COLUMNS; y++)
		{
			outputFile << setw(8) << numbers[x][y] << "\t";
		}
		outputFile << endl;
		outputFile.close();
	}
}

Also, I keep getting this error: not all control paths return a value.
What do I do about that?

Links or tutorials would be much appreciated!

[sep11]

Well I figured out the error. Needed to return values.

So I managed to do that by adding:

return numbers[4][6]; //added to line 40

Still having trouble figuring out how to get the array to continue loading.