How to pull data from txt file and put into a sturucture

[markd]

Hi i'm really new to c++ so bare with. I am looking pull data from a text file that displays multiple cities in the format cityname xcoordinate ycoordinate and then displays them. For some reason though the program only displays the last cities data.

#include <vector>
#include <cmath>

struct City {
    string name;
    int x, y;
};

int main()
{
    ifstream inputFile("CoordinateData.txt");
    vector<City> cities;
    City temp;
    while (inputFile >> temp.name >> temp.x >> temp.y)
        cities.push_back(temp);

    City anchor; // the constant data.
    for (City city : cities)
    cout << temp.name << temp.x << temp.y << endl;
    system("pause");
    return(0);
}

[Chervil]

Line 19 temp.name should be city.name etc.

If you rewrite the while loop like this, the temp variable will not exist after that loop, avoiding its accidental reuse.

    for (City temp; inputFile >> temp.name >> temp.x >> temp.y; )
        cities.push_back(temp);

I'm not sure whether I like that style or not, but it's a thought.

[markd]

Thanks! Do you know how I'd then go about just displaying a specific city?

[Chervil]

Do you know how I'd then go about just displaying a specific city?

How specific? The nth one in the vector, or the one with a particular name or ...

[markd]

What I need to do in the long run is be able to select a few of the cities and use their coordinates in calculations so i'm wondering how I would be able to select an individual city if i needed to use it. I'm not to sure which would be easier either one would be helpful.

[Chervil]

Select by number is straightforward, just use the array syntax cities[n] where n is in the range 0 to cities.size()-1.
http://www.cplusplus.com/reference/vector/vector/operator%5B%5D/
http://www.cplusplus.com/reference/vector/vector/size/

Select by name, you could write your own code to search the vector, or use the std::find from the <algorithm> header.
http://www.cplusplus.com/reference/algorithm/find/

[markd]

when selecting a city using the syntax array [n] eg city.name[1] it only gives a letter of the second character of the city rather than the second word in the list. Any ideas why this might be?

[Chervil]

Your vector is called cities. So you would need to access cities[1].name.

Example:

    unsigned int n = 3;
    if (n < cities.size())
        cout << "cities[" << n << "] " << cities[n].name << "  " << cities[n].x << "  " << cities[n].y <<  '\n';
    else
        cout << "Out of range: " << n << "  max: " << cities.size()-1   <<  '\n';