Multiple problems with program.

[alvl5froakie]

This is and assignment for my class. You are required to make a program with a switch menu and some other content that was covered in class and while my menu works fine along with some other stuff you also need a save file and open file function. This is where my problems begin... when i import a file back to my program there seems to be a miscommunication the makes it so there is 5 + however many records were input and saved to said file and these files are just blank and they also mess up when they are displayed. Next, when i try to sort the records by name then only the names will switch not the whole record. also for an aesthetic note my columns seem to change places depending on the length of the value input.

Now for the real question, am i using the struct correctly within my display, my open file, my save file or even if my input info.

#include <iostream>
#include <fstream>
#include <string>
#include <sstream>
#include <iomanip>
#include <cstring>
using namespace std;

struct Player {
	string name;
	int gamesPlayed;
	int points;
	int goals;
	int assists;
	int penaltyMinutes;
};


const int MAXSIZE = 30;

void openFile(Player[], int&, ifstream&);
void saveFile(const Player[], int, ofstream&);
void getInfo(Player[], int&, bool&);
void displayInfo(const Player[], int, bool);
void sortInfo(Player[], int, bool&);
void searchInfo(Player[], int, bool&);
void removeInfo(Player[], int&);
bool okToSearch(int size);
int indexOf(string target, Player athlete[], int size);
char menuStuff();

ofstream fout;
ifstream fin;


int main ()
{
	Player names[MAXSIZE];
	int numOfPlayers = 0;
	bool sorted = false;
	bool run = true;
	
	do
	{
		cout << "Stat Tracker Program  --  " << numOfPlayers <<
			 " players being tracker." << endl;
		switch ( menuStuff() )
		{
			case 'O': openFile(names, numOfPlayers, fin) ; break;
			case 'S': saveFile(names, numOfPlayers, fout) ; break;
			case 'A': getInfo(names, numOfPlayers, sorted) ; break;
			case 'D': displayInfo(names, numOfPlayers, sorted) ; break;
			case 'C': sortInfo(names, numOfPlayers, sorted) ; break;
			case 'F': searchInfo(names, numOfPlayers, sorted) ; break;
			case 'R': removeInfo(names, numOfPlayers) ; break;
			case 'Q': run = false; break;
			default : cout << "ERROR: INVALID ENTRY" << endl;
		}
	}
	while (run);
	cout << endl << "Program Terminated" << endl;
	
	system ("pause");
	
}

char menuStuff()
{
	char response;
	cout << endl << "Choose an option" << endl;
	cout << "(O)pen File, (S)ave File, (A)dd Players and Stats, (D)isplay Players and Stats,\n(C)atergoize Players and Stats," 
			" (F)ind Players and Stats,\n(R)emove Players and Stats, (Q)uit" << endl;
	cout << "> ";
	cin >> response;
	cin.ignore(256, '\n');
	return toupper(response);
}

void saveFile(const Player athlete[], int size, ofstream&)
{

	char filename[30];
	cout << "Please Enter a Filename: ";
	cin.getline(filename, 30);
	fout.open(filename, ios::app);
	
	if(!fout.fail())
	{
		cout << "Saving INFO to the disc.";
		for(int i=0; i < size; i++)
		{
			fout << athlete[i].name << ';'
				 << athlete[i].gamesPlayed << ';'
				 << athlete[i].points << ';'
				 << athlete[i].goals << ';'
				 << athlete[i].assists << ';'
				 << athlete[i].penaltyMinutes;
			
			if (i < size - 1) fout << endl;
		}
		cout << endl << athlete << " Players Written to Disk." << endl;
		fout.close();
		system("pause");
		system("cls");

	}
	else
	{
		cout << "ERROR: Problem with FILE" << endl;
		system("pause");
		system("cls");

	}
}

void openFile(Player athlete[], int& size, ifstream&)
{
	char filename[30];
	string str;
	stringstream strstrm;
	
	cout << "Please enter the FILE you would like to open: ";
	cin.getline(filename, 30);
	fin.open(filename);
	if (!fin.fail())
	{
		system("cls");
		cout << "Reading from Disc";
		size  = 0;
		while(!fin.eof() && size < MAXSIZE)
		{
			getline(fin, str, ';');
			athlete[size].name = str;
			
			getline(fin, str, ';');
			strstrm.str(""); strstrm.clear();
			strstrm << str;
			strstrm >> athlete[size++].gamesPlayed;
			
			getline(fin, str, ';');
			strstrm.str(""); strstrm.clear();
			strstrm << str;
			strstrm >> athlete[size++].points;
			
			getline(fin, str, ';');
			strstrm.str(""); strstrm.clear();
			strstrm << str;
			strstrm >> athlete[size++].goals;
			
			getline(fin, str, ';');
			strstrm.str(""); strstrm.clear();
			strstrm << str;
			strstrm >> athlete[size++].assists;
			
			getline(fin, str, ';');
			strstrm.str(""); strstrm.clear();
			strstrm << str;
			strstrm >> athlete[size++].penaltyMinutes;
		}
		cout << endl << size << " Players from the disc" << endl;
		
		system("pause");
		system("cls");
	}
	else
	{
		cout << "ERROR: Cannot open FILE" << endl;
		system("pause");
		system("cls");
	}
	
}

void getInfo(Player athlete[], int& size, bool& sorted)
{
	Player tmp;
	char response;
	char str[256];
	if (size < MAXSIZE)
	{
		system("cls");
		cout << "Input Player Info" << endl << endl;
		cout << "Name: ";
		cin.getline(str, 256, '\n');
		tmp.name = str;
		cout << "Games Played: ";
		cin >> tmp.gamesPlayed;
		cout << "Goals:	";
		cin >> tmp.goals;
		cout << "Assists: ";
		cin >> tmp.assists;
		cout << "Points: ";
		cin >> tmp.points;
		cout << "Penalty Minutes: ";
		cin >> tmp.penaltyMinutes;
		cout << endl;
		cout << "Add this Player to the Tracker? (y/n) ";
		cin >> response;
		if (toupper(response) == 'Y')
			athlete[size++] = tmp;
		}
		else
		{
			cout << "Tracker at max CAPACITY; Cannot enter more Players." << endl;
			system("pause");
		}
	system("pause");
	system("cls");
}
void displayInfo(const Player athlete[], int size, bool sorted)
{
	system("cls");
	
	if(size < 1)
	{
		cout << "Nothing to display" << endl;
	}
	else
	{
		cout << "Listing of Players being Tracked" << endl << endl;
		cout << fixed << setprecision(2);
		cout << "Player Name         Games Played	Goals	Assists	  Points    Penalty Minutes" << endl;
		cout << "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" << endl;
		
		cout << left;
		for (int i = 0; i < size; i++)
		{
			cout << athlete[i].name << right
				 << setw(15) << athlete[i].gamesPlayed
				 << setw(8) << athlete[i].goals
				 << setw(13) << athlete[i].assists
				 << setw(10) << athlete[i].points
				 << setw(15) << athlete[i].penaltyMinutes << left << endl;
		}
		
		cout << "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" << endl;
		cout << size;
		cout << " Players Tracked" << endl;
	}
	system("pause");
	system("cls");
}
void sortInfo(Player athlete[], int size, bool& sorted)
{
    int i, j, min;
	for (i = 0; i < (size-1); i++) 
	{
    	min = i;
    	for (j = (i+1); j < size; j++) 
		{
      		if(athlete[j].name < athlete[min].name) 
			  min = j;
    	}
   		 if (i != min) swap(athlete[i].name, athlete[min].name);
  	}
	cout << "Names Sorted!";
	sorted = true;
}
void searchInfo(Player athlete[], int size, bool& sorted)
{
	if(okToSearch(size))
	{
		string name;
		int ndx;
		cout << "Enter the Player you want to find: ";
		getline(cin, name);
		ndx = indexOf(name, athlete, size);
		if(ndx < size)
			cout << name << " found at line " << ndx+1 << "." << endl;
		else
			cout << name << " was not found." << endl;
	}
	else 
	{
		cout << "Please sort before searching.";
	}
}
void removeInfo(Player athlete[], int& size)
{
	
	string name;
	int ndx;
	
	cout << "Enter the name you want to delete: ";
	getline (cin, name);
	
	
	if(ndx < size)
	{
		for(int i = ndx; i < size-1; i++)
		{
			athlete[i] = athlete[i+1];
		}
		size--;
		cout << name << " has been removed." << endl;
	}
	else
	cout << name << " was not found." << endl;
	
}

bool okToSearch(int size)
{
	if(size == 0)
	{
		cout << "The Tracker is Empty." << endl
			 << "Please add Players before searching." << endl;
		return false;
	}
	else 
	{
		return true;
	}
}

int indexOf(string target, Player athlete[], int size)
{
	for (int i = 0; i < size; i++)
		if (athlete[i].name == target) return i; 
  	return size;
}

Any help would be greatly appreciated.
Thanks in advance.

[48T7M4Gy]

Now for the real question, am i using the struct correctly within my display, my open file, my save file or even if my input info.

I'm sure you're genuine and mean well but the real question is 'have you tested your program'. What data have you tested it on and what results did you get. There is a good chance if it runs without errors on sample data (we don't have it) and you have printed out the data and it is to your expectations then everything is fine.

If it isn't performing and you can't work out why then that's where we can help. Otherwise ...

Cheers :)

[alvl5froakie]

Sorry haven't done this before.
When i just try to open a text file that was saved as test.txt and display the input data (in this case Name: Luke, Games Played: 13, Goals: 12, Assists: 12, Points: 24, Penalty Minutes: 12) was displayed like so,

Listing of Players being Tracked

Player Name         Games Played        Goals   Assists   Points    Penalty Minutes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Luke             13       0            0         0              0
              02046820731            0        24              0
              3      12            0         0              0
              0       0           12         0              0
           -376    -373            0         0             12
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 Players Tracked
Press any key to continue . . .

but if the program was run on its own without opening a file and just display the input then it turns out to the desired effect,(same input)

Listing of Players being Tracked

Player Name         Games Played        Goals   Assists   Points    Penalty Minutes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Luke             13      12           12        24             12
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 Players Tracked
Press any key to continue . . .

now for the sorting problem (input 1 Name:Luke, Games Played: 13, Goals:12, Assists:12, Points: 24, Penalty Minutes:12) (Intput 2 Name:John, Games Played: 45, Goals: 22, Assists: 54, Points: 76, Penalty Minutes: 66) the display output before

Listing of Players being Tracked

Player Name         Games Played        Goals   Assists   Points    Penalty Minutes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Luke             13      12           12        24             12
John             45      22           54        76             66
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 Players Tracked
Press any key to continue . . .

and the output after sorting

Listing of Players being Tracked

Player Name         Games Played        Goals   Assists   Points    Penalty Minutes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
John             13      12           12        24             12
Luke             45      22           54        76             66
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 Players Tracked
Press any key to continue . . .

For the sorting problem i know what it is just don't know how to fix it.
hopefully this helps more than my first set of information. Also as for the test data. I have been consistently using these 2 inputs.

Thanks again.

[48T7M4Gy]

Taking the first display I think you have something wrong with you data file and if you lpost it here I can check. Just cut and paste it from the text file as is.

[alvl5froakie]

Luke;13;24;12;12;12

is what is in the text file after it is saved.

[48T7M4Gy]

OK I'll have a look by running your program. I am surprised your text file has only one player.

One observation right at the start is the ;'s in your data. That is probably where the problem lays.

[48T7M4Gy]

vvoid openFile(Player athlete[], int& size, ifstream&)
{
	char filename[30];
	cout << "Please enter the FILE you would like to open: ";
	cin >> filename;

	fin.open(filename);
	if (!fin.fail())
	{
		size = 0;
		while (!fin.eof() && size < MAXSIZE)
		{
			fin >> athlete[size].name;
			fin >> athlete[size].gamesPlayed;
			fin >> athlete[size].points;
			fin >> athlete[size].goals;
			fin >> athlete[size].assists;
			fin >> athlete[size].penaltyMinutes;
			size++;
		}
		cout << endl << size << " Players from the disc" << endl;
	}
	else
		cout << "ERROR: Cannot open FILE" << endl;
}

If you change to this and remove the ;'s replacing them with spaces I think most of the troubles arte solved.

[48T7M4Gy]

Data file:

Gladys 12 23 11 10 9
Luke 13 24 12 12 12
Alice 4 18 9 7 13
Bill 8 8 16 4 10
MARY 9 1 2 4 18

Output to screen:

Listing of Players being Tracked

Player Name         Games Played        Goals   Assists   Points    Penalty Minutes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Gladys             12      11           10        23              9
Luke             13      12           12        24             12
Alice              4       9            7        18             13
Bill              8      16            4         8             10
MARY              9       2            4         1             18
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 Players Tracked
Press any key to continue . . .

This is just formatting and output order on each line. No big deal for you to fix by shuffling the struct attributes around.

[alvl5froakie]

that worked Thank you so much :)

[48T7M4Gy]

With your sort function you need to swap all the associated attributes, not just the name as the attribute you are sorting on.

[alvl5froakie]

yeah thats what i was just thinking but thanks again

[48T7M4Gy]

Cheers :)