Phone Book

[kyresong]

I was wondering if you could help me about this. It's a phone book. I am recording name in it. Then searching it from number and from name.

Problems;

1- Search from name: it finds the first search then when select opt2 second time it can't find anything and goes to the main menu.

2- Search from number: It asks me to type the number and goes to the main menu.

3-I also realized when I use 100 instead of "count" in for loop it works fine ( but in first try onlt). So I did the same thing in phone. So I have said for ( int i =0 ; i < 100 ; i++){ for both loops. I thought it should be working for either count or 100. But it seems there is a difference. It's not working in properly even I type 100.

#include <fstream>
#include <iostream>
#include <string>

using namespace std;

void addName(string names[], string phones[], int count)
{

string name;
cout << "Enter a name:";
cin >> name;

string phone;
cout << "Enter a phone number:";
cin >> phone;

names[count] = name;
phones[count] = phone;
count++;

}

void searchName(string names[], string phones[], int count)
{
string name;
cout << "Enter Name:";
cin >> name;

for (int i = 0; i < 100; i++){

if (name == names[i])
{
cout << names[i] << " 's phone number is: " << phones[i] << endl << endl;
}

}
}

void searchPhone(string names[], string phones[], int count){

string phone;
cout << "Enter a phone number: ";
cin >> phone;

for (int i = 0; i < 100; i++)
{
if (phone == phones[i])
{
cout << phones[i] << "belongs to " << names[i];
}

}

}
int main()
{
string names[100];
string phones[100];
int count = 0;

while (true)
{
cout << "Ultimate Phone Book v1.2" << endl;
cout << "1- Add a Record" << endl;
cout << "2- Search By Name" << endl;
cout << "3- Search By Phone" << endl;
cout << "4- Display All" << endl;
cout << "0- Exit" << endl << endl;

int choice;

cout << "What's your choice?:";
cin >> choice;

cout << endl;


if (choice == 1) // Add Names
{
addName(names, phones, count);
}

if (choice == 2) //Search Names
{
searchName(names, phones, count);
}

if (choice == 3) //Search By Phone
{
searchPhone(names, phones, count);
}





}
}

[jasonwynn10]

can you please use code tags? It makes it easier to read.
http://www.cplusplus.com/forum/articles/42672/

#include <fstream>
#include <iostream>
#include <string>
#include <windows.h>
using namespace std;
string names[100];
string phones[100];
int count = 0;
void addName()
{

string name;
cout << "Enter a name:";
cin >> name;

string phone;
cout << "Enter a phone number:";
cin >> phone;

names[count] = name;
phones[count] = phone;
count++;

}

void searchName()
{
string name;
cout << "Enter Name:";
cin >> name;

for (int i = 0; i < 100; i++){

if (name == names[i])
{
cout << names[i] << " 's phone number is: " << phones[i] << endl << endl;
}

}
}

void searchPhone()
{

string phone;
cout << "Enter a phone number: ";
cin >> phone;

for (int i = 0; i < 100; i++)
{
if (phone == phones[i])
{
cout << phones[i] << "belongs to " << names[i];
}

}

}
int main()
{
while (true)
{
cout << "Ultimate Phone Book v1.2" << endl;
cout << "1- Add a Record" << endl;
cout << "2- Search By Name" << endl;
cout << "3- Search By Phone" << endl;
cout << "4- Display All" << endl;
cout << "0- Exit" << endl << endl;

int choice;

cout << "What's your choice?:";
cin >> choice;

cout << endl;


if (choice == 1) // Add Names
addName();
else if (choice == 2) //Search Names
searchName();
else if (choice == 3) //Search By Phone
searchPhone();
system("pause");
system("CLS");
}
}

I made all your variables global, I added a clear screen effect when the program restarts, and I changed the way your if statements were set up.

[kyresong]

Thanks I didn't know it.

Thank you very much for replying it. I am very curious what was wrong with my code and how would you do that without making global variable?

Best
Kyre

[jasonwynn10]

I just made all the variables global for my own betterment. I have the program even more progressed here:

#include <fstream>
#include <iostream>
#include <string>
#include <windows.h>
using namespace std;
string names[100];
string phones[100];
int count = 0;
void addName()
{

string name;
cout << "Enter a name:";
cin >> name;

string phone;
cout << "Enter a phone number:";
cin >> phone;

names[count] = name;
phones[count] = phone;
count++;

}

void searchName()
{
string name;
cout << "Enter Name:";
cin >> name;

for (int i = 0; i < 100; i++){

if (name == names[i])
{
cout << names[i] << " 's phone number is: " << phones[i] << endl << endl;
}

}
}

void searchPhone()
{

string phone;
cout << "Enter a phone number: ";
cin >> phone;

for (int i = 0; i < 100; i++)
{
if (phone == phones[i])
{
cout << phones[i] << "belongs to " << names[i];
}

}

}

void DisplayContact()
{
for(int i=0; i<=names.length();i++) ///Broken On Purpose BTW
{
cout<<names[i]<<"  "<<phones[i]<<endl;
}

}

int main()
{
while (true)
{
cout << "Ultimate Phone Book v1.2" << endl;
cout << "1- Add a Record" << endl;
cout << "2- Search By Name" << endl;
cout << "3- Search By Phone" << endl;
cout << "4- Display All" << endl;
cout << "0- Exit" << endl << endl;

int choice;

cout << "What's your choice?:";
cin >> choice;

cout << endl;


if (choice == 1) /// Add Names
addName();
else if (choice == 2) ///Search Names
searchName();
else if (choice == 3) ///Search By Phone
searchPhone();
else if (choice == 4)
DisplayContact();
else if (choice == 0)
return 0;
system("pause");
system("CLS");
}
}

I left the contact displaying part broken on purpose BTW. I'll let you finish it.

[kyresong]

I appreciate for the effort. Meanwhile I found my mistake. Which was about "reference by value" After I've put "&" front of the count everything worked well.

 
#include <fstream>
#include <iostream>
#include <string>

using namespace std;

void addName(string names[], string phones[], int &count)
{

	string name;
	cout << "Enter a name:";
	cin >> name;

	string phone;
	cout << "Enter a phone number:";
	cin >> phone;

	names[count] = name;
	phones[count] = phone;
	count++;

}

void searchName(string names[], string phones[], int &count)
{
	string name;
	cout << "Enter Name:";
	cin >> name;

	for (int i = 0; i < count; i++){

		if (name == names[i])
		{
			cout << names[i] << " 's phone number is:   " << phones[i] << endl << 

[jasonwynn10]

nice