bubble sort not working

[N8RzwA7f]

Hello,
I can't get this bubble sort to work? I think it's a problem in the arraysort() method itself.

thanks.

  #include <cstdlib>
#include <iostream>
#include <string>
using namespace std;

void arraysort(int* myarray,int* pcount,string order);
void fillarray(int* myarray,int* pcount);
void printarray(int* myarray,int* pcount);
int main(int argc, char** argv) {
    int mycount = 0;
    int *pcount = &mycount;
    string order;
    cout << "Enter the array size: " <<  endl;
    cin >> *pcount;
    int* myarray = new int[*pcount];
    cout << " Now enter some random values  the array will sort them  :  "  <<    endl;
    cout << " NO MORE THAN : " << *pcount << " ! " << endl;
    fillarray(myarray,pcount);
    cout << "Enter the order: ascending/descending: "  << endl;
    cin >> order;
    arraysort(myarray,pcount,order);
    printarray(myarray,pcount);
    
    
    return 0;
}
void fillarray(int* myarray,int* pcount){
    int value;
    for(int i=0; i< *pcount; i++){
        if (cin >> value){
            myarray[i] = value;
        } else {
            cout << " cin failed to get the value !" << endl;
        }
    }
    cin.ignore(100,'\n');
}
void arraysort(int* myarray, int* pcount,string order) {
    // BUBBLE SORT
    int flag = 1;
    int temp;
    if (order == "ascending") {
        cout << "You picked ascending(small->large)" << endl;
        for (int i=1; i <= *(pcount)  && flag; i++){
           flag = 0;
           for (int j=0; j < *(pcount - 1); j++) {
             if (myarray[j] > myarray[j + 1]){  
               //swap the values;
               temp = myarray[j];
               myarray[j]= myarray[j+1];
               myarray[j+1] = temp;
               flag = 1;  //a swap occured.
             }
           }
        }
    } else {
        cout << "You picked descending(large->small)" << endl;
        for (int i=1;(i <= *pcount) && flag; i++){
           flag = 0;
           for (int j=0; j < *(pcount - 1);j++) {
             if (myarray[j + 1] > myarray[j]){
               //swap the values;
               int temp = 0;
               temp = myarray[j];
               myarray[j]= myarray[j+1];
               myarray[j+1] = temp;
               flag = 1;  //a swap occured.
             }
           }
        }
    }
    cin.ignore(100,'\n');
}
void printarray(int* myarray, int* pcount) {
    for(int i = 0; i < *pcount; i++){
        cout << myarray[i] << endl;
    }
    cin.ignore(100,'\n');
}

[N8RzwA7f]

/

[coder777]

The problem is on line 46/60:

*(pcount - 1) -> (*pcount - 1) // Note the *

You change the pointer and then get the wrong value. There is really no need to pass an int as a pointer. Why do you do so?

[N8RzwA7f]

So what should it be instead ?

I know it's maybe not needed , it was just to practice passing a pointer.
I thought it's possible to change a pointer's value during runtime?

Thanks

[coder777]

So what should it be instead ?

Pass int by value.


Yes, pointer can be changed at runtime. They are numerical values:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

#include <iostream> using namespace std; int main() { int x; int *p = &x; ++p; cout << "&x = " << &x << endl; cout << "p = " << p << endl; cout << "diff = " << p - &x << endl; return 0; }

&x = 0x770bb1fe1a28 p = 0x770bb1fe1a2c diff = 1

Note that always the size of the type of the pointer is added and subtracted. Hence the real numerical difference of this values in this case is 4 = sizeof(int).