reading through text file

[basketball914]

I need my code to read an example of "string:double" but reading through my code it'll give me the string but it also says it cannot be found. i can't figure out why it won't read the error on the left and right side i need to to detect wether or not the string is to the left of the : and the double to the right

#include <iostream>
#include <vector>
#include <fstream>
using namespace std;
char c='1';

class MenuItem
{
private:
string name;
double price;
public:
/// Constructor - initialize the object from a given name and price
MenuItem(string itemName, double itemPrice);

/// Constructor - initialize the object given a single text line
/// using the syntax "itemname:price"
MenuItem(string specification);

/// Print the name and price of this menu entry
void Print();

class InvalidItem
{
private:
string message;
public:
InvalidItem(string msg)
{
message = msg;
}
string GetMessage() const
{
return message;
}
};


};
bool InterpretableAsDouble(string s);

bool InterpretableAsstring(string s);
vector<MenuItem> ProcessFile();

void MenuItem::Print()
{
cout << "the item " << name << "costs " << price <<endl;
}
MenuItem::MenuItem(string itemName, double itemPrice)
{
name=itemName;
price=itemPrice;

if (itemName == " " )
{
throw InvalidItem("there is no name");
}
else if (itemPrice <=0)
{
throw InvalidItem("this is not a real price");
}
}




MenuItem:: MenuItem(string specification)
{

double colPosition = specification.find(":");
if (colPosition > specification.length())
{

throw InvalidItem("No Semicolen found in line '" + specification + "'");
}
string leftSide = specification.substr(0, colPosition);
string rightSide = specification.substr(colPosition);
if (leftSide == "" || rightSide == "")
{
throw InvalidItem("semicolen missing in line '" + specification + "'");
}



name = atof(leftSide.c_str());
price = atof(rightSide.c_str());


double emptyPosition = specification.find(name);
if (emptyPosition > specification.length())
{

throw InvalidItem("No Menu item found in line '" + specification + "'");
}




double emptypricePosition = specification.find(price);
if (emptypricePosition > specification.length())
{

throw InvalidItem("No price item found in line '" + specification + "'");
}
string Leftside = specification.substr(0, emptypricePosition);
string Rightside = specification.substr(emptypricePosition+1);
if (Leftside == "" || Rightside == "")
{
throw InvalidItem("menu item missing price '" + specification + "'");
}
if (InterpretableAsDouble(leftSide) == false || InterpretableAsDouble(rightSide) == false)
{
throw InvalidItem("no menu item price '" + specification + "'");
}

name = atof(leftSide.c_str());
price = atof(rightSide.c_str());




}


// For doubles, use atof instead of atoi


int main()
{
try
{
vector<MenuItem> records = ProcessFile();

cout << "Here is the information:\n";
for (double i = 0; i < records.size(); i++)
{
records[i].Print();
}
}
catch (string e)
{
cout << "Sorry, an error occurred: " << e << endl;
}
catch (MenuItem::InvalidItem e)
{
cout << "Syntax error in file: " << e.GetMessage() << endl;
}

}


vector<MenuItem> ProcessFile()
{
vector<MenuItem> result;

string filename;
cout << "What is the filename? ";
getline(cin, filename);

/// Create the filestream object
ifstream fin;
/// Attempt to open a file
fin.open(filename.c_str());
/// Test for failure
if (fin.fail())
{
throw string(filename + " could not be opened.");
}

/// Read one line at a time
string line;
do
{
getline(fin, line);
if (line != "")
{
MenuItem nextMenuItem(line);
result.push_back(nextMenuItem);
}
}
while (fin.eof() == false);

/// Close the file
fin.close();

return result;
}

bool InterpretableAsDouble(string s)
{
for (int i = c-'1'; i < s.length(); i++)
{
if (!(s[i] >= 1 && s[i] <= 9))
return false;
}
return true;
}

[pearlyman]

1st. Use code tags please.
2nd. Your code is very hard to read without any formatting at all. You really need to work on your formatting...
3rd. On my compiler (Code::blocks) I couldn't even get this thing to compile until I added stdlib.
4th. around line 193, instead of
for (int i = c-'1'; i < s.length(); i++)
for (int unsigned i = c-'1'; i < s.length(); i++)
Now it compiles, no warnings, no errors... without the accompanying text file, I can't test it further.

This is better.

#include <iostream>
#include <vector>
#include <fstream>
#include <stdlib.h>

using namespace std;
char c='1';

class MenuItem
{
private:
    string name;
    double price;
public:
/// Constructor - initialize the object from a given name and price
    MenuItem(string itemName, double itemPrice);

/// Constructor - initialize the object given a single text line
/// using the syntax "itemname:price"
    MenuItem(string specification);

/// Print the name and price of this menu entry
    void Print();

    class InvalidItem
    {
    private:
        string message;
    public:
        InvalidItem(string msg)
        {
            message = msg;
        }
        string GetMessage() const
        {
            return message;
        }
    };


};
bool InterpretableAsDouble(string s);

bool InterpretableAsstring(string s);
vector<MenuItem> ProcessFile();

void MenuItem::Print()
{
    cout << "the item " << name << "costs " << price <<endl;
}
MenuItem::MenuItem(string itemName, double itemPrice)
{
    name=itemName;
    price=itemPrice;

    if (itemName == " " )
    {
        throw InvalidItem("there is no name");
    }
    else if (itemPrice <=0)
    {
        throw InvalidItem("this is not a real price");
    }
}




MenuItem:: MenuItem(string specification)
{

    double colPosition = specification.find(":");
    if (colPosition > specification.length())
    {

        throw InvalidItem("No Semicolen found in line '" + specification + "'");
    }
    string leftSide = specification.substr(0, colPosition);
    string rightSide = specification.substr(colPosition);
    if (leftSide == "" || rightSide == "")
    {
        throw InvalidItem("semicolen missing in line '" + specification + "'");
    }



    name = atof(leftSide.c_str());
    price = atof(rightSide.c_str());


    double emptyPosition = specification.find(name);
    if (emptyPosition > specification.length())
    {

        throw InvalidItem("No Menu item found in line '" + specification + "'");
    }




    double emptypricePosition = specification.find(price);
    if (emptypricePosition > specification.length())
    {

        throw InvalidItem("No price item found in line '" + specification + "'");
    }
    string Leftside = specification.substr(0, emptypricePosition);
    string Rightside = specification.substr(emptypricePosition+1);
    if (Leftside == "" || Rightside == "")
    {
        throw InvalidItem("menu item missing price '" + specification + "'");
    }
    if (InterpretableAsDouble(leftSide) == false || InterpretableAsDouble(rightSide) == false)
    {
        throw InvalidItem("no menu item price '" + specification + "'");
    }

    name = atof(leftSide.c_str());
    price = atof(rightSide.c_str());




}


// For doubles, use atof instead of atoi


int main()
{
    try
    {
        vector<MenuItem> records = ProcessFile();

        cout << "Here is the information:\n";
        for (double i = 0; i < records.size(); i++)
        {
            records[i].Print();
        }
    }
    catch (string e)
    {
        cout << "Sorry, an error occurred: " << e << endl;
    }
    catch (MenuItem::InvalidItem e)
    {
        cout << "Syntax error in file: " << e.GetMessage() << endl;
    }

}


vector<MenuItem> ProcessFile()
{
    vector<MenuItem> result;

    string filename;
    cout << "What is the filename? ";
    getline(cin, filename);

/// Create the filestream object
    ifstream fin;
/// Attempt to open a file
    fin.open(filename.c_str());
/// Test for failure
    if (fin.fail())
    {
        throw string(filename + " could not be opened.");
    }

/// Read one line at a time
    string line;
    do
    {
        getline(fin, line);
        if (line != "")
        {
            MenuItem nextMenuItem(line);
            result.push_back(nextMenuItem);
        }
    }
    while (fin.eof() == false);

/// Close the file
    fin.close();

    return result;
}

bool InterpretableAsDouble(string s)
{
    for (int i = c-'1'; i < s.length(); i++)
    {
        if (!(s[i] >= 1 && s[i] <= 9))
            return false;
    }
    return true;
}

[basketball914]

sorry new to site didn't realize it posted like that...

and the text file needed is just a basic txt file

it needs input like burrito:5.5 or something like that

i am suppose to throw an error if burrito doesn't show up on the left side

or if the 5.5 doesn't show up on the right

but my code will read the file but i can't get my error to work

[pearlyman]

I need my code to read an example of "string:double"

You are using getline, which throws it all in one string. I take your instructions to mean you should read the string, then read the double...