C++

Forum

 
Segmentation fault (core dumped)

ottob (23)
I am getting the error Segmentation fault (core dumped) when I run my code. It compiles and I can enter the information but when it displays the info, it doesn't display "Employees w/ no bonus , avg bonus, high bonus" So I'm guessing something is wrong there but I'm not sure what it is. Any help is greatly appreciated. Thank you

ottob (23)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
 
#include <iostream>
#include <cmath>
#include <cstdlib>
#include <string>
#include <algorithm>
#include <cctype>
#include <sstream>
#include <set>
#include <iomanip> 

using namespace std;


//Create enumeration that contains bonus information 
enum BonusAvailability{NO_BONUS, AVG_BONUS, HIGH_BONUS};


//Create a struct that contains the employees personal information
struct PersonalInfo
{
	string fName,
		   lName,
		   title;
};

//Create a struct for hourly workers, calls personal info struct 
struct HourlyW
{
	PersonalInfo pData ; 
	double hoursWorked; 
	double hourlyRate;
};

//Create a struct for salary workers, calls personal info struct
struct SalaryW
{
	PersonalInfo pData;
	double salary;
	double bonus;
	BonusAvailability bData;
	
};
ottob (23)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
 
int main()
{
	
	
	int numInfo; // Holds number of employess to be entered 
	int NUM_HOUR = 0; // Holds number of hourly workers 
	int NUM_SALARY = 0; // Holds number of salary workers
	char selection; // If user wants to continue 
	char selection2; // If user wants to continue 
	double tHour; // Total hourly 
	double tSalary; // Total salary
	BonusAvailability b; // Create b under Bonus Availability 
	
				  // Get number of employees to be entered 
				  cout << "Enter the number of employees you will be entering information for: ";
				  cin >> numInfo;
				  
				  
				  
				  // If number is negative, show error message  
				  while (numInfo < 0)
				   {
					   cout << "Invalid number or negative number! Try again!" << endl;
					   exit(1);
				   }
				  // Get number of hourly workers 	  
				  cout << "How many are hourly workers?" << endl;
				  cin >> NUM_HOUR;
				  HourlyW employee[NUM_HOUR]; // Create employee under Hourly W with size being hourly workers
				 
				  
				  // If number is negative, show error message
				  while (NUM_HOUR < 0)
				   {
					   cout << "Invalid number or negative number! Try again!" << endl;
					   exit(1);
				   }
				  
				  // Get number of salary workers 
				  cout << "How many are salary workers?" << endl;
				  cin >> NUM_SALARY;
				  SalaryW emp[NUM_SALARY]; // Create emp under Salary W with size being salary workers
				  
				  
				  // If number is negative, show error message 
				  while (NUM_SALARY < 0)
				   {
					   cout << "Invalid number or negative number! Try again! " << endl;
					   exit(1);
				   }
				   
				   // If sum of hourly and salary is less than or greater than the total number of employees entered show error message 
				   while ((NUM_HOUR + NUM_SALARY) > numInfo || ( NUM_HOUR + NUM_SALARY < numInfo))
				   {
					   cout << "Hourly workers plus Salary workers does not equal " << numInfo << endl;
					   cout << "Try again " << endl;
					   cout << "" << endl;
					   cout << "How many hourly workers?" << endl;
					   cin >>NUM_HOUR;
					   while (NUM_HOUR < 0)
						{
							cout << "Invalid number or negative number!" << endl;
							exit(1);
						}
						cout << "How many are salary workers?" << endl;
						cin >> NUM_SALARY;
						while (NUM_SALARY < 0)
							{
								cout << "Invalid number or negative number!" << endl;
								exit(1);
							}
						if (NUM_HOUR + NUM_SALARY == numInfo)
						{
							break;
						}
				   }
				 
				  
				  // If hourly workers is greater than 0, run this to get the information
				  if (NUM_HOUR > 0)
				  {
					cout << "Hourly Workers!" << endl;
					cout << "---------------" << endl;
				  
					for (int i = 0; i < NUM_HOUR; i++)
					{
						  
					  
					  cout << "Enter first name: ";
					  cin >> employee[i].pData.fName;
					  cout << "" << endl;
					  cout << "Enter last name: ";
					  cin >> employee[i].pData.lName;
					  cout << "" << endl;
					  cout << "Enter their title: ";
					  cin >> employee[i].pData.title;
					  cout << "" << endl;
					  cout << "Enter the hours worked: ";
					  cin >> employee[i].hoursWorked; 
					  
					  // If hours worked is less than 0 or greater than 80, show error message 
					  while (employee[i].hoursWorked < 0 || employee[i].hoursWorked > 80)
					  {
						  cout << "Incorrect input!" << endl;
						  cout << "" << endl;
						  cout << "Enter the hours worked: ";
						  cin >> employee[i].hoursWorked;
						  if (employee[i].hoursWorked > 0 || employee[i].hoursWorked < 80)
							  break;
					  }
					  cout << "" << endl;
					  cout << "Enter the hourly rate: ";
					  cin >> employee[i].hourlyRate;
					  cout << "" << endl;
					  //tHour = employee[i].hoursWorked * employee[i].hourlyRate; // Get total hourly pay 
					  
					  //Ask if they want to continue 
					  cout << "Would you like to continue? Y or N" << endl;
					  cin >> selection;
					  if (selection == 'y' || selection == 'Y')
					  {
						  continue;
					  }
					  else 
					  {
						  break;
					  }
					 // cout << "Total " << tHour << endl;  //TEST 
					  
				    
				    } 
			      }
ottob (23)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
 
				 // If number of salary workers is greater than 0, run this to get the information  
				 if (NUM_SALARY > 0)
				 {
					cout << "Salary Workers!" << endl;
					cout << "---------------" << endl;
					for (int i = 0; i < NUM_SALARY; i++)
					{
						
						cout << "Enter first name: ";
						cin >> emp[i].pData.fName;
						cout << "" << endl;
						cout << "Enter last name: ";
						cin >> emp[i].pData.lName;
						cout << "" << endl;
						cout << "Enter their title: ";
					    cin >> emp[i].pData.title;
					    cout << "" << endl;
						cout << "Enter salary: ";
						cin >> emp[i].salary;
						
						// If salary is less that 0, show error message 
						while (emp[i].salary < 0)
						{
						  cout << "Incorrect input!" << endl;
						  cout << "" << endl;
						  cout << "Enter the salary: ";
						  cin >> emp[i].salary;
						  if (emp[i].salary > 0)
							  break;
						}
					  
						cout <<"" << endl;
						cout << "Enter bonus: ";
						cin >> emp[i].bonus;
						
						// If bonus is less than 0, show error message 
						while (emp[i].bonus < 0)
					    {
						  cout << "Incorrect input!" << endl;
						  cout << "" << endl;
						  cout << "Enter bonus: ";
						  cin >> emp[i].bonus;
						  if (emp[i].bonus > 0)
						  {
							break;
						  }
						}
						
						
						tSalary = emp[i].salary + emp[i].bonus; // Hold total pay for salary workers 
						//cout << "Salary is " << tSalary << endl; //TEST 
						
						cout << "" << endl;
						
						//See if user wants to continue 
					    cout << "Would you like to continue? Y or N" << endl;
					    cin >> selection2;
					    if (selection2 == 'y' || selection2 == 'Y')
							{
								continue;
							}
						else 
							{
								break;
							}
					  
					  // See what category the salary workers fall under 
					  if (emp[i].bonus == 0)
					  {
						  b = static_cast<BonusAvailability> (0);
						 
					  }
					  else if  (emp[i].bonus > 0 && emp[i].bonus <= 5000)
					  {
						  b = static_cast<BonusAvailability> (1);
					  }
					  else if (emp[i].bonus > 5000)
					  {
						  b = static_cast<BonusAvailability>(2);
					  }
						cout << "" << endl;
						//cout << "Bonus is " << b << endl; //TEST 
					}
					
				 }
				 
				 //Begin displaying information 
				 cout << "      List of employees              " << endl;
				 cout << "    --------------------         " << endl;
				 cout <<    " First  " << "  Last  " << "     Total Pay " << endl;
				 cout << " -------------------------------" << endl;
				 
														
					for (int i = 0; i < numInfo; i++)
					{
						if (NUM_HOUR > 0)
						{
							cout << left << setw(10) <<  employee[i].pData.fName << setw(12) << employee[i].pData.lName << setw(10) << (employee[i].hoursWorked * employee[i].hourlyRate) << endl;
						}
						cout << " " << endl;
						if (NUM_SALARY > 0)
						
							cout << left << setw(10)<< emp[i].pData.fName  << setw(12) << emp[i].pData.lName << setw(10) <<  emp[i].salary + emp[i].bonus << endl;

						}
					cout << "" << endl;
					
					//Show bonus for salary workers 
					
						cout << "  Employees with NO bonus" << endl;
						cout << "---------------------------" << endl;
						cout << " First  " << " Last  " << endl; 
						cout << "-------------------------------";
					
						for (int i = 0; i < numInfo; i++)
						{
						 
						  if (emp[i].bonus == 0)
						  {
							  cout << left << setw(10) << emp[i].pData.fName << setw(12) << emp[i].pData.lName << endl;
						  }
						}
						
						cout << "" << endl;
						cout << "  Employees with AVG bonus" << endl;
						cout << "---------------------------" << endl;
						cout << " First  " << " Last  " << endl; 
						cout << "-------------------------------"; 
						
						 for (int i = 0; i <  numInfo; i++)
						 {
							if (emp[i].bonus == 1)
						  {
							  cout << left << setw(10) << emp[i].pData.fName << setw(12) << emp[i].pData.lName << endl;
						  }
						 }
						 cout << "" << endl;
						cout << "  Employees with HIGH bonus" << endl;
						cout << "---------------------------" << endl;
						cout << " First  " << " Last  " << endl; 
						cout << "-------------------------------";
						
						 for (int i = 0; i < numInfo; i++)
						 {
							if(emp[i].bonus == 2)
						  {
							  cout << left << setw(10) << emp[i].pData.fName << setw(12) << emp[i].pData.lName << endl;
						  }
						 }
						 
						
			 
	



			return 0;

}
cire (8284)
1
2
 
    cin >> NUM_HOUR;
    HourlyW employee[NUM_HOUR];

This is illegal in C++. NUM_HOUR must be a compile time constant. (And generally speaking identifier tokens that are all-caps are reserved for macros or constants.)

Do you pay attention to compiler warnings? You have several lines of unreachable code that your compiler is likely to warn you about.


In this code:

1
2
3
4
5
6
7
8
9
10
11
12
 
   for (int i = 0; i < numInfo; i++)
    {
        if (NUM_HOUR > 0)
        {
            cout << left << setw(10) << employee[i].pData.fName << setw(12) << employee[i].pData.lName << setw(10) << (employee[i].hoursWorked * employee[i].hourlyRate) << endl;
        }
        cout << " " << endl;
        if (NUM_SALARY > 0)

            cout << left << setw(10) << emp[i].pData.fName << setw(12) << emp[i].pData.lName << setw(10) << emp[i].salary + emp[i].bonus << endl;

    }

You access outside the bounds of the emp and employee arrays.

ottob (23)
I changed NUM_HOUR to a const int NUM_HOUR = 0; and I did the same for NUM_SALARY

Now I am getting error: cannot bind 'std::istream for several lines.
88:14
101:14
119:15
126:14

Can you explain a bit more on how I'm accessing outside the bounds for emp and employee?
cire (8284)
I changed NUM_HOUR to a const int NUM_HOUR = 0; and I did the same for NUM_SALARY

I can't say that's much of an improvement. Zero-sized arrays of automatic storage duration are not legal either (and if they were, using that array to store anything would be disastrous.)

Your line numbers and that error message mean nothing to me since they don't match up with the code you've supplied.


Can you explain a bit more on how I'm accessing outside the bounds for emp and employee?

If you had one salaried employee and one hourly employee, then numInfo would be 2, but emp and employee would have only one element each, so you would be accessing outside the bounds of each array when i was 1.
Topic archived. No new replies allowed.