return-statement with a value, in function returning 'void' [-fpermissive]

[hdyh]

This coding was not function because of the return cutPoint. please help me to solve this problem

#include <iostream>
using namespace std;

void quickSort (int*,int,int);
int partition(int*, int,int);
int main()
{
int a[12];
for(int i=0;i<12;i++){
cout<< "Number " << i+1 << " ";
cin>>a[i];
}

quickSort(a,0,11);

for (int i=0; i<12 ; i++)
{
cout << a[i] << endl;
}

}

void quickSort (int T[], int first , int last)
{
int cut;
if (first<last)
{
cut = partition(T, first,last);
quickSort(T, first,cut);
quickSort (T, cut+1, last);
}


int partition(int T[], int first,int last);
{

int pivot, temp;
int loop, cutPoint, bottom, top;
pivot=T[first];
bottom = first; top = last;
loop=1;

while (loop)
{
while (T[top]>pivot)
{
top--;
}

while(T[bottom]<pivot)
{

bottom++;

}
if (bottom<top)
{
temp=T[bottom];
T[bottom]=T[top];
T[top]=temp;


}
else
{
loop=0;
cutPoint = top;

}

}
return cutPoint;
}
}

[TheIdeasMan]

Hi,

Please always use code tags. And ensure the code has some indentation.

http://www.cplusplus.com/articles/z13hAqkS/

Without this, it is hard to see what is happening.

[E0p9LyTq]

You have a couple of very simple mistakes in your code:

1. Remove the ; from your partition function definition.

2. Remove the last } and move it to the end of your quicksort function.

And as TheIdeaMan suggested PLEASE use code tags so your source is easier to read:

#include <iostream>
using namespace std;

void quickSort (int*, int, int);
int partition(int*, int, int);

int main()
{
   int a[12];
   for(int i=0; i<12; i++)
   {
      cout<< "Number " << i+1 << " ";
      cin>>a[i];
   }

   quickSort(a,0,11);

   for (int i=0; i<12 ; i++)
   {
      cout << a[i] << endl;
   }

}

void quickSort (int T[], int first , int last)
{
   int cut;

   if (first<last)
   {
      cut = partition(T, first,last);
      quickSort(T, first,cut);
      quickSort (T, cut+1, last);
   }
}

int partition(int T[], int first,int last)
{
   int pivot, temp;
   int loop, cutPoint, bottom, top;
   pivot=T[first];
   bottom = first;
   top = last;
   loop=1;

   while (loop)
   {
      while (T[top]>pivot)
      {
         top--;
      }

      while(T[bottom]<pivot)
      {
         bottom++;
      }
      if (bottom<top)
      {
         temp=T[bottom];
         T[bottom]=T[top];
         T[top]=temp;
      }
      else
      {
         loop=0;
         cutPoint = top;
      }
   }
   return cutPoint;
}

[hdyh]

thanks for not use code tags TheIdeaMan.

[hdyh]

Thanks for the answer FurryGuy, but i still can't get the output from these coding. I still new with the coding

[E0p9LyTq]

I noticed that if you enter two or more numbers that are the same your program logic goes into what appears to be an infinite loop. Enter different numbers and your quicksort works without "hanging."

I didn't do any debugging so I can't say with any definite idea where your logic is faulty. Just a gut impression you are not properly checking when two numbers are equal and thereby skipping the actual sorting of the two elements.