Problems with an array project im working on.

[jdawg123]

This is what i have so far. I'm not completely sure if this correctly assigns the random numbers to the array, so if it doesn't let me know. But I need a simple way to find the max value from the random generated numbers. Any help would be greatly appreciated.

#include <iostream>
#include <cstdlib>	// for rand and srand functions
#include <ctime>
using namespace std;

int main()
{
	int num = 0;

	// srand(time(NULL));
	srand(1);

	for (int i = 0; i < 100; i++)
	{
		num = rand() % 100 + 1;
		cout << num << " ";
	}

	return 0;
}

[Disch]

You do not have an array in that code. You have a single varialbe 'num'. Every time you create a random number and assign it to num, you are erasing the old number.

If you want an array of 100 elements:

int num[100];  // make an array of 100 elements

for(...)
{
    num[i] = ...  // assigns the random number to a different element in the array each time 

[BettyBoopTS]

Here is a simple program I wrote when learning how to create and manipulate random numbers. This will generate a list of random numbers (1-100) then sequentially index them. I used the goto command which is usually frowned upon due to the creation of spaghetti logic, "unless it benefits the program" which in this case, I believe is true due to the fact that the logic is easy to follow. I also generated a couple cout statements so that one could see the stages of change the integers go through during process. Good Luck!

#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;

int main()
{

int b,d,m;
int w[100];
int x[100];

b=1;m=1;
srand (time(NULL) );
loop1:
m = rand() % 100 + 1;

for(d=1;d<=100; d++)
w[d]=d; x[d]=d; 


if(w[m] != 0)goto loop3;

if (w[m] ==0)goto loop1;

loop3:

cout << "w[" <<m<< "] = " << w[m]<< "  :\n"; x[b] =w[m]; ; w[m]=0;
cout << "w[" <<m<< "] = " << w[m]<< "  :\n"; 
cout << "x[" <<b<< "] = " << x[b]<< "  :\n\n";
b=b+1;  if(b<=100)goto loop1;  
b=1;

cout << "finis";

return 0;
}

[jdawg123]

its telling me i have an error. something like num[30] doesnt convert to int.
any sugestions. its suppose to be 30 by the way.

#include <iostream>
#include <cstdlib>	
#include <ctime>
using namespace std;

int main()
{

	int num[30];

	// srand(time(NULL));
	srand(1);

	for (int i = 0; i < 30; i++)
	{
		num = rand() % 100 + 1;
		
	}

	
	
	 return 0;
}
	

[BettyBoopTS]

it works for me under 2 different compilers, watcom and visual studio express2008, let me check it out , ill get back to you, it should be something simple, isnt it always?? lol

[jdawg123]

ha, im using visual studio 2008. Idk why it isnt working, But i need it to assign the random numbers to the array, then i need to have a loop that finds the max value in the loop.


Error 1 error C2440: '=' : cannot convert from 'int' to 'int [30]' e:\assignment 4\assignment 4\assign4.cpp 18 Assignment 4


that is the error i get

[BettyBoopTS]

actually, i noticed that if i compile it with watcom, i have no trouble running it on watcom or visual studio, however, if i compile it with visual studio, it compiles, runs fine on watcom but i am noticing the same error message as you are getting using Visual Studio. So its a compiler issue, my first guess is that it has some sort of ambiguous interpetation of an otherwise correct code(that they warned us about in class!)I will go through the program and locate the problem using visual studio so that it can be addressed once and for all.

[BettyBoopTS]

hey jdawg, ok, i changed the program a bit , one thing that was changed was instead of using two single dimension arrays i went with a two dimension array. I also eliminated the unnecesary cout statements. I compiled it with, and ran it through visual studio to insure it would work for you. I also tailored it to your specifications, it will now print out 30 random numbers ranging from 1-100. plus the final cout gives the location and value of the highest number of the 30 sampled. i dont think you will have any problems running this one. best of luck!!

#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;

int main()
{

int b,d,e,f,h,i,m,y;
int x[101][2];

b=d=h=m=y=1;
x[d][1]=1;x[d][2]=1;

for(d=1;d<=100;d++)
{x[d][1]=d;x[d][2]=d;}

srand (time(NULL) );

loop1:

m = rand() % 100 + 1;

if(x[m][1] != 0)goto loop3;

if (x[m][1] ==0)goto loop1;

loop3:

 x[b][2] =x[m][1]; ; x[m][1]=0;
 
cout << "x[" <<b<< "][2]= " << x[b][2]<< "  :\n";
y=1;

b=b+1;  if(b<=30)goto loop1;  
b=1;y=1;

for (b=1;b<=30;b++)
if(x[b][2]>=x[y][2])y=b;
cout <<"\n";
cout << "max value is: " "x[" <<y<< "][2] = " << x[y][2]<< "  :\n\n";

cout << "finis";

return 0;
}

partial output with max value & location in array


,,,, [2]= 43  :
x[19][2]= 95  :
x[20][2]= 4  :
x[21][2]= 55  :
x[22][2]= 84  :
x[23][2]= 98  :
x[24][2]= 100  :
x[25][2]= 96  :
x[26][2]= 57  :
x[27][2]= 60  :
x[28][2]= 39  :
x[29][2]= 50  :
x[30][2]= 33  :

max value is: x[24][2] = 100  :
,,,