Input number of elements

[supernoob]

The program is not working properly when I input 10.
I don't know why but the program will add a '0' after the first element.
Sample output:

Input number of elements: 10
Input element #1:5
Input element #2:5
Input element #3:6
Input element #4:6
Input element #5:7
Input element #6:7
Input element #7:1
Input element #8:1
Input element #9:8
Input element #10:2
Search element to be searched: 7
1 0 1 2 5 5 6 6 7 7 Number searched: 7
Location of number searched: Index number 9
The average of the elements is: 4

#include <iostream>

using namespace std;

int search (int*, int);
float mean(int*, int);
int location(int*, int, int);
void sort(int*, int);

int main()
{
    int num[50];
    int numEle, a, l;

    cout << "Input number of elements: ";
    cin >> numEle;
    for (int i = 0; i < numEle; i++)
    {
        cout << "Input element #"<<i+1<<": ";
        cin >> num[i];
    }
    sort(num, numEle);
    a = search(num, numEle);
    for (int j = 0; j < numEle; j++)
    {
        cout << num[j]<<" ";
    }
    l = location(num, numEle, a);
    if (a != -1)
    {
        cout << "Number searched: "<<a<<endl;
        cout << "Location of number searched: Index number "<<l<<endl;
    }
    else cout << "The number searched does not exist."<<endl;

    cout << "The average of the elements is: "<<mean(num, numEle)<<endl;

    return 0;
}

void sort(int array[], int element)
{
    int temp;
    for (int i = element - 1; i > 0; i--)
    {
        for (int k = 0; k < element; k++)
        {
            if (array[k] > array[k+1])
            {
                temp = array[k+1];
                array[k+1] = array[k];
                array[k] = temp;
            }
        }
    }
}



int search(int arr[], int num)
{
    int ele;
    int first = 0, last = num-1, mid;
    bool found = false;
    cout << "Select element to be searched: ";
    cin >> ele;
    while ((first <= last) && (found == false))
    {
        mid = (first+last)/2;
        if (ele > arr[mid])
            first = mid+1;
        else if (ele < arr[mid])
            last = mid-1;
        else
        {
            found = true;
        }
    }
    if (found == true)
    {
        return ele;
    }
    else return -1;

}

float mean(int arr[], int num)
{
    int temp, ave;
    for (int i =0; i < num; i++)
    {
        temp = temp + arr[i];
    }
    ave = temp/num;

    return ave;
}

int location(int arr[], int num, int ele)
{
    int first = 0, last = num-1, counter = 0;
    bool found = false;
    while (found == false)
    {
        if (ele != arr[counter])
            counter++;
        else if (ele == arr[counter])
        {
            counter++;
            found = true;
        }

    }
    return counter;
}

[sasauke]

I reorganized your program a little bit. I hope you don't mind. There were a couple of design mistakes and what not. Ask if you have any questions.

#include <iostream>

using namespace std;

int search(int*, int, int&);
float mean(int*, int);
void sort(int*, int);

int main()
{
	int numEle;

	cout << "Input number of elements: ";
	cin >> numEle;

	int *num = new int[numEle];

	for (int i = 0; i < numEle; i++)
	{
		cout << "Input element #" << i + 1 << ": ";
		cin >> num[i];
	}

	sort(num, numEle);

	int location;
	int numToFind = search(num, numEle, location);

	for (int j = 0; j < numEle; j++)
	{
		cout << num[j] << " ";
	}

	if (numToFind != 0)
	{
		cout << "\nNumber searched: " << numToFind << endl;
		cout << "Location of number searched: Index number " << location << endl;
	}
	else cout << "\nThe number searched does not exist." << endl;

	cout << "The average of the elements is: " << mean(num, numEle) << endl;

	cin.ignore();
	cin.get();

	delete[] num;
	return 0;
}

//Your bubblesort(?) function was kind of wrong.
void sort(int array[], int element)
{
	for (int i = 1; i < element; i++)
	{
		bool isSorted = true;
		for (int k = 0; k < element - 1; k++)
		{
			if (array[k] > array[k + 1])
			{
				int temp = array[k + 1];
				array[k + 1] = array[k];
				array[k] = temp;
				isSorted = false;
			}
		}
		if (isSorted == true)
		{
			break;
		}
	}
}

//There was also no need for a different function for the location
//So the location is found in the same function
int search(int arr[], int num, int &location)
{
	int ele;
	cout << "Select element to be searched: ";
	cin >> ele;

	for (int i = 0; i <= num; i++)
	{
		if (ele == arr[i])
		{
			location = i + 1;
			return ele;
		}
	}

	return 0;
}

float mean(int arr[], int num)
{
	int temp = 0;
	for (int i = 0; i < num; i++)
	{
		temp = temp + arr[i];
	}

        //You would have to cast the return value to float
        //Otherwise you would not get a correct answer:
	return (float)temp / num;
}

[ne555]

        for (int k = 0; k < element; k++)//line 46
        {
            if (array[k] > array[k+1]) //out of bounds access