Working on rand loop and when I run it results don't match

[millerizi]

OK, so I am just working on making a trivia game and trying to get the questions to come up based in random number, I don't get any errors, but when I enter the answer it never seems to be right, not sure what I am doing wrong here, I do get a random number I think based off of computer time, but once I get to my questions the answers I have made correct don't work. Any suggestions to get me back on track would be awesome.

#include <iostream>
#include <ctime>
#include <cstdlib>

using namespace std;


int questions(int guess);
    int total;
    int counter = 1;
    int score = 0;
    int enter;
    int guess;
    int point = 0;



int main()
{

    //srand is used to find the Random number based on the computer time
    srand(time(NULL));

    cout << "************************************************************************\n";
    cout << "************************************************************************\n";
    cout << "*******************  Millerizi Trivia  *********************************\n";
    cout << "************************************************************************\n";
    cout << "************************************************************************\n";
    cout << "\nHow many questions do you want to answer?\n"
         << "Enter Number Here: ";
    cin >> total;

    cout << "You want to play to answer " << total <<" questions.";

    while (counter <= total)
        {
            //This creates the number randomly between 1 and and the number after %
            cout << "Your Current Score Is: " << score <<"\n";
            guess = rand() % 4 +1;
            questions(guess);
            ++counter;
    }
    cout << "Your Final Score Is: " << score <<"\n";
    return 0;
}


int questions(int guess)
{
    int answer;
    int point;
        switch(guess)
        {
            case 1:
                cout << guess;
                cout<<"\nHow Many Players are on a soccer field for a game?\n";
                cout<<"1. 22\n";
                cout<<"2. 11\n";
                cout<<"3. 10\n";
                cout<<"4. 6\n";
                cout<<"\nPlease Enter 1-4: ";
                cin >> answer;
                    if (answer = 1)
                    {
                        cout<<"\nNice Job, that is Correct\n";
                        point = 1;
                        break;
                    }
                    if (answer = 2)
                    {
                        cout<<"\nSorry, that is incorrect";
                        point = 0;
                        break;
                    }
                    if (answer = 3)
                    {
                        cout<<"\nSorry, that is incorrect";
                        point = 0;
                        break;
                    }
                    if (answer =4)
                    {
                        cout<<"\nSorry, that is incorrect";
                        point = 0;
                        break;
                    }
            case 2:
                cout << guess;
                cout<<"\nHow Many Players are on a basketball court?\n";
                cout<<"\n1. 22";
                cout<<"\n2. 11";
                cout<<"\n3. 10";
                cout<<"\n4. 6";
                cout<<"Please Enter 1-4: ";
                cin >> answer;
                    if (answer = 1)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 2)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 3)
                    {
                        cout<<"\nNice Job, that is Correct\n";
                        break;
                    }
                    if (answer =4)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
            case 3:
                cout << guess;
                cout<<"\nWhat is the number one sport in the USA?\n";
                cout<<"\n1. Soccer";
                cout<<"\n2. Basketball";
                cout<<"\n3. Football";
                cout<<"\n4. Baseball";
                cout<<"\nPlease Enter 1-4: ";
                cin >> answer;
                    if (answer = 1)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 2)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 3)
                    {
                        cout<<"\nNice Job, that is Correct\n";
                        break;
                    }
                    if (answer =4)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
            case 4:
                cout << guess;
                cout<<"\nWhat sport has a Wold Cup every 4 years?\n";
                cout<<"\n1. Football";
                cout<<"\n2. Golf";
                cout<<"\n3. NASCAR";
                cout<<"\n4. Soccer";
                cout<<"\nPlease Enter 1-4: ";
                cin >> answer;
                    if (answer = 1)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 2)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer = 3)
                    {
                        cout<<"\nSorry, that is incorrect";
                        break;
                    }
                    if (answer =4)
                    {
                        cout<<"\nNice Job, that is Correct\n";
                        break;
                    }                        default:
                    cout<<"\nEnter correct choice";

        }
    //system("pause");
    }

[itsAbhi]

try using switches inside the question to
switch(answer)
case 1:

default:


or useing


if else if ladders

not only if
if
if


this is the answer
|
V

[yR9wb7Xj]

It's your if statement if I'm not mistaking because you're assigning answer to 3 but you're not assigning answer to equal 3. so example if(answer==3), try that for all of them it should work.

[millerizi]

DOH, Codex, I think you are right, I use SQL everyday and forgot about that difference. I will try that. Thanks its Abhi, I really do need to figure out the best flow as well, currently just trying to see how I can get stuff working together and then experiment with different options.