Brain cramp

[fguy]

Something like this should be dead simple. I can't believe it's not working. Here is my code...

#include <iostream>
#include <vector>
#include <string>

using namespace std;

int main()
{
    vector<string> v;
    string s;

    while( cin >> s );
        v.push_back(s);

    for( string str : v )
        cout << str << " ";

    return 0;
}

As you can see, all I want is to input a few strings and print them back out. So I input my strings, separated by <enter> and terminate input with a ctrl-z. But only the last string I enter is being printed.

[LB]

You have a semicolon at the end of line 12, so line 13 will never be reached until there is no more input.

Always use curly braces.

[sasauke]

Like LB said. ALWAYS use curly brackets, even if it's only one statement. It makes the code way clearer to read and you will make less mistakes.

#include <iostream>
#include <vector>
#include <string>

using namespace std;

int main()
{
    vector<string> v;
    string s;

    while( cin >> s )
    {
        v.push_back(s);
    }
    
    for( string str : v )
    {
        cout << str << " ";
    }

    return 0;
}

[fguy]

lol thanks