Heloo

[Lazlo]

I have a problem I want to write multiple person
and I want to save in output file
and then I want to take from output what I have write


this is my code

  #include <iostream>
#include <string>
#include <fstream>
#include <sstream>

using namespace std;

class Persoana
{
public:
	Persoana(string n, string p, int v)
	{
		setName(n);           \\name
		setPrenume(p);         \\forename
		setVarsta(v);          \\age
	}
	void setName(string x)
	{
		name = x;
	}
	
	void setPrenume(string x)
	{
		Prenume = x;
	}
	void setVarsta(int x)
	{
		Varsta = x;
	}

	string get()
	{
		ostringstream os;
		os << "\Name:" << name << "\nPrenume:" << Prenume << "\nVarsta:" << Varsta << endl;
		return os.str();
	}


private:

	string name;
	string Prenume;
	int Varsta;
};






int main()
{
	
	
	string name;
	string Prenume;
	int Varsta;
	ofstream output;
	output.open("marius.txt", ios::end);

	

	cout << "Numele: ";
	cin >> name;
	cout << "Prenumele: ";
	cin >> Prenume;
	cout << "Varsta: ";
	cin >> Varsta;
	cout << "Numele Prenumele si varsta \n" << endl;
	cout << "\Name:" << name << "\nPrenume:" << Prenume << "\nVarsta:" << Varsta << endl;



	output.close;
	system("pause");
	return 0;
}

[Axarator]

output.open("marius.txt", fstream::app, ios::end);

Something like that

[MikeyBoy]

You probably want to take a look at:

http://www.cplusplus.com/doc/tutorial/files/

[Lazlo]

thx Axarator
If I want to write this name Axel Lastname Paul age 20

[Axarator]

Is there a problem with it still?

[Lazlo]

I want to create a person like this

name:Alen
Lastname:Peter
Age:20

[Axarator]

Check this pastebin (Some things are broken but my name thing works) https://pastebin.com/DjtwLZ1E

[Lazlo]

I must worck with classes

[Axarator]

Your code seems fine to me.

[Lazlo]

yes but I want to be predefinite name lastname age

[Axarator]

I'm also a beginner, I am sorry I can't help.

[andywestken]

Try compiling your broken version and see if you can see how the error messages allowed me to fic your program in a couple of minutes!

Not sure how you want to use your file. As you were trying to open with ios::end (used for seeking) I switched it to ios::ate, but ios::app might be better. See documentation on fstream::open for details.

Also, I'd prob use

ofstream output("marius.txt", ios::ate);

rather than

	ofstream output;
	output.open("marius.txt", ios::ate);

Andy

 #include <iostream>
#include <string>
#include <fstream>
#include <sstream>

using namespace std;

class Persoana
{
public:
	Persoana(string n, string p, int v)
	{
		setName(n);            //name          <= comments were wrong way round (\\ rather than //)
		setPrenume(p);         //forename
		setVarsta(v);          //age
	}
	void setName(string x)
	{
		name = x;
	}
	
	void setPrenume(string x)
	{
		Prenume = x;
	}
	void setVarsta(int x)
	{
		Varsta = x;
	}

	string get()
	{
		ostringstream os;
		os << "\nName:" << name << "\nPrenume:" << Prenume << "\nVarsta:" << Varsta << endl;
		// <= started with "\N rather than "\nN and compiler doesn't know what \N means (just \n)
		return os.str();
	}

private:
	string name;
	string Prenume;
	int Varsta;
};

int main()
{
	string name;
	string Prenume;
	int Varsta = 0; // <= good habit to init all vars!
	ofstream output;
	//output.open("marius.txt", ios::end); // ios::end if for seeking!
	output.open("marius.txt", ios::ate); // ate = at end (to append)

	cout << "Numele: ";
	cin >> name;
	cout << "Prenumele: ";
	cin >> Prenume;
	cout << "Varsta: ";
	cin >> Varsta;
	cout << "Numele Prenumele si varsta \n" << endl;
	cout << "\nName:" << name << "\nPrenume:" << Prenume << "\nVarsta:" << Varsta << endl;
	// <= started with "\N rather than "\nN and compiler doesn't know what \N means (just \n)

	output.close(); // missing () -- was just output.close
	system("pause");
	return 0;
}

[Lazlo]

this is my new code
I want to save in output file and then I want to call the output txt

[mutexe]

You need to read up on classes (there are 2 pages on this site).
You don't initialise member variables in the way that you have, and your set methods aren't setting anything.

Read Andy's post again.