I'm back from slaying errors and only 23 deadly errors remain.

[eons93]

shit, forgot i renamed the files to equipment but i'll repost to help.

Equipment.h

#pragma once
#include <iostream>
#include <ctime>
#include <string>
#include "Combat.h"
#include "Combatant.h"
#include "Scenario.h"
#include "Dice.h"


using namespace std;

class Weapon
{
public:
	Weapon(string name, int attack, int damage);

	string _name;
	int _damageDice;
	int _attackDice;
};

Equipment.cpp

#include <iostream>
#include <ctime>
#include <string>
#include "Combat.h"
#include "Combatant.h"
#include "Scenario.h"
#include "Dice.h"
#include "Equipment.h"

using namespace std;


Weapon::Weapon(string name, int attack, int damage)
{
	name = _name;
	damage = _damageDice;
	attack = _attackDice;
}

[Wyboth]

I see what is going wrong - you never assigned anything to _damageDice or _attackDice. You need to do _damageDice = damage; and _attackDice = attack;. You had it flipped the wrong way. When you never assign a value to an int but then try to read what its value is, you always get a wacky value. Remember you list what you want to assign to first, and put what you want to assign to it after the equals sign. You also need to flip around your name variable. That should fix the error with the uniform_int_distribution. Let us know what the next error is.

[eons93]

but i am assigning them values ( or am i not understanding hat you're saying). in the Weapon "Club", im assigning those int variables 4 and 10 respectively, but they go into the weapon func as that and come out as really high numbers.


from Combatant.cpp

void Combatant::attack(Combatant target)
{
	//Initialize Weapon
	Weapon club("Club", 4, 10);

	int aTotal;
	int dTotal;
	int iTotal;

	//Roll dice for Attack and Damage "ranges"
	Dice ATTACK;
	Dice DAMAGE;

	int attackDiceResults = ATTACK.diceRoller(club._attackDice);
	int damageDiceResults = DAMAGE.diceRoller(club._damageDice);

	//Add dice results with player stats.
	aTotal = _attack + attackDiceResults;
	dTotal = _damage + damageDiceResults;

	if (aTotal >= target._defense) {
		iTotal = dTotal - 5;
		target._health = iTotal;
		cout << "You have been dealt " << iTotal << "damage to!" << endl;
		target._health -= iTotal;
	}
	else {
		cout << _name << "has missed!" << endl;
	}
}

edit!!! nevermind, i reread what you were saying and re looked at my other situations i did that kind of func and switch the variables. it now works perfectly. thank you so much.

[Wyboth]

You're welcome. Good luck with your future projects.

[eons93]

haha, thanks, I've ran into a new problem now though. I'm trying to have my program compute whether a target is alive or dead.

combatant.cpp

Combatant::Combatant(int level, int health, int defense, int speed, int damage, int attack, int stamina, int mana, int armor, int magicResist)
{
	string _name;
	bool _alive = true;
	_level = level;
	_health = health;
	_currentHealth = health;
	_defense = defense;
	_speed = speed;
	_damage = damage;
	_attack = attack;
	_stamina = stamina;
	_mana = mana;
	_armor = armor;
	_magicResist = magicResist;
}

part of combat.cpp

bool Combat::runCombat()
{
	Combatant kyle(1, 10, 10, 3, 5, 6, 15, 12, 500, 1000);
	Combatant one(1, 10, 10, 2, 5, 6, 15, 12, 500, 1000);
	Combatant two(1, 10, 10, 1, 5, 6, 15, 12, 500, 1000);
	Combatant three(1, 10, 10, 4, 5, 6, 15, 12, 500, 1000);

	kyle._name = "Kyle";
	one._name = "Orrin";
	two._name = "Braedon";
	three._name = "Brent";

	bool cbat = true;

	while (cbat == true)
	{
		int turn = checkSpeed(kyle._speed, one._speed, two._speed, three._speed);

		if (turn == 1) {
			int choice = kyle.pickAction();
			if (choice == 1) {
				//Pick target
				cout << "Please pick a target" << endl;
				cout << "1)." << one._name << "   " << one._currentHealth << endl;
				cout << "2)." << two._name << "   " << two._currentHealth << endl;
				cout << "3)." << three._name << "   " << three._currentHealth << endl;
				int choice;
				cin >> choice;

				//Check is attack beats target defense, then subtract armor from damage total and inflict to health.
				switch (choice)
				{
				case 1: 
					if (one._alive == true) {
						one._currentHealth -= kyle.attack(one);
						if (one._currentHealth <= 0) {
							cout << one._name << " has been slain!!" << endl;
							one._alive = false;
						}
					}
					else {
						cout << "Please pick another target. " << one._name << " has had enough!" << endl;
					}
					break;
				case 2:
					if (two._alive == true) {
						two._currentHealth -= kyle.attack(two);
						if (two._currentHealth <= 0) {
							cout << two._name << " has been slain!!" << endl;
							two._alive = false;
						}
					}
					else {
						cout << "Please pick another target. " << two._name << " has had enough!" << endl;
					}
					break;
				case 3:
					if (three._alive == true) {
						three._currentHealth -= kyle.attack(three);
						if (three._currentHealth <= 0) {
							cout << three._name << " has been slain!!" << endl;
							three._alive = false;
						}
					}
					else {
						cout << "Please pick another target. " << three._name << " has had enough!" << endl;
					}
					break;
				}
				
			}
		}
		else if (turn == 2) {
			one.attack(kyle);
		}
		else if (turn == 3) {
			two.attack(kyle);
		}
		else {
			three.attack(kyle);
		}
	}
	return true;

}

i've checked the debugger and at every state, all the _alive variables equal true but it never when as if it were true. It immediately says each target is dead right as I declare it without any info about whether is died or not or took damage. my combatants are playing opossum.

edit: and as i was typing that reply i had an idea and tried it after posting, it worked, problem resolved. I needed to switch the if else statements.