Blackjack Program

[ohsnap1319]

I am having a lot of problems with my blackjack program. It doesn't run at all! If someone can help me that would be great!! Thanks!

#include <iostream>
#include <ctime>

using namespace std;

const int NUMCARDS = 52;
const int NUMATTEMPTS = 5;
const int MAXNUMCARDS = 12;

void displayMenu();
void NewHandMenu();
void ShuffleUpDemCards(bool DeckOfCards[]);
int NewCards(bool DeckOfCards[]);
void cardCharacters(int NewCard);
void PlayersCardHand(int PlayersHand[], int PlayersDealtHand);
void HousesCardHand(int HousesHand[], int HousesDealtHand);
int PlayersHandScore(int PlayersHand[], const int PlayersDealtHand);
int HousesHandScore(int HousesHand[], const int HousesDealtHand);
void ScoresAndHands(int HousesHand[], const int HousesDealtHand, int PlayersHand[], const int PlayersDealtHand);


int main()
{
	time_t qTime;
	time(&qTime);
	srand(qTime);


	bool DeckOfCards[NUMCARDS];
	int PlayersHand[MAXNUMCARDS];
	int HousesHand[MAXNUMCARDS];
	int PlayersDealtHand = 0;
	int HousesDealtHand = 0;
	int badAttempts=0;
	
	
	
	while (true {
		displayMenu();
		ShuffleUpDemCards(DeckOfCards);
		
		PlayersHand[0] = NewCards(DeckOfCards);
		PlayersHand[1] = NewCards(DeckOfCards);
		HousesHand[0] = NewCards(DeckOfCards);
		HousesHand[1] = NewCards(DeckOfCards);

		HousesDealtHand = 2;
		PlayersDealtHand = 2;
	}

	NewHandMenu();

	char choice;
	bool HitsforPlayer = true;
	int PlayerScore = PlayersHandScore(PlayersHand, PlayersDealtHand);
	int HouseScore = HousesHandScore(HousesHand, HousesDealtHand);
	do {
		cout << "The House's Hand" << endl;
		cardCharacters(HousesHand[1]);
		cout << endl;
		cout << "The Player's Score = " << PlayersHandScore(PlayersHand, PlayersDealtHand) << endl;
		PlayersCardHand(PlayersHand, PlayersDealtHand);

		cout << "Player, would you like to hit(press h) or stay(press s)";
		cin >> choice;

		if(choice == 'h') {
			cout << "Player selects to hit!!\n";
			PlayersHand[PlayersDealtHand] = NewCards(DeckOfCards);
			PlayersDealtHand++;
		}
		else if(choice == 's') {
			cout << "Player selects to stay!!\n";
		bool HitsforPlayer = false;
		}
		else {
			cout << "You entered an invalid choice!!!\n";
			cout << "Please try again! This time press an ""h"" to hit or press a ""s"" to stay!!\n";
			cin >> choice;
		}

		cout << endl << endl;
		PlayerScore = PlayersHandScore(PlayersHand, PlayersDealtHand);
	} while (HitsforPlayer && PlayerScore < 22);

	if(PlayerScore > 21) {
		cout << "I am sorry, but you have busted!!\n";
		cout << "The House Wins the Hand!!!\n";
		ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
	}

	else {
		while (HouseScore < 17) {
			HousesHand[HousesDealtHand] = NewCards(DeckOfCards);
			HousesDealtHand++;
			HouseScore = HousesHandScore(HousesHand, HousesDealtHand);
		}

		bool HouseBusts = (HouseScore > 21);

		if(HouseBusts) {
			cout << "Congratulations, the House Busted!!!\n";
			cout << "You win the Hand!!\n";
			ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
		}
		else {
			if (PlayerScore == HouseScore) {
				cout << "Both your hand and the Houses hand are the same!!\n";
				cout << "The hand results in a push, and no one wins!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}
			else if (PlayerScore > HouseScore) {
				cout << "Your hand is higher than the Houses hand!!\n";
				cout << "You win the hand!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}

			else  {
				cout << "The Houses hand is higher than your hand!!\n";
				cout << "The House wins the hand!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}
		}
	}
}


void displayMenu()
{
	cout << "*******************************************\n";
	cout << "HI, AND WELCOME TO OUR BLACKJACK PROGRAM!!!\n";
	cout << "*******************************************\n";
	
}

void NewHandMenu()
{
	cout << "*******************************************\n";
	cout << "------Starting a New Hand------------------\n";
	cout << "*******************************************\n";

}


void ShuffleUpDemCards(bool DeckOfCards[])
{
	int index;
	for(index=0; index<NUMCARDS; index ++) {
		DeckOfCards[52] = false;
	}
}

int NewCards(bool DeckOfCards[])
{
	DeckOfCards[NUMCARDS] = true;
	int NewCard = -1;
	do {
		NewCard = (rand() % 52);
		if (!DeckOfCards[NewCard]) {
			DeckOfCards = false;
		}
	} while (DeckOfCards);
	return NewCard;
}

void cardCharacters(int NewCard)
{
	const int RANK = (NewCard%13);
	const int SUIT = (NewCard/13);
	if(RANK==0)
		cout << "Ace of";
	else if(RANK<9)
		cout << (RANK+1) << " of ";
	else if(RANK==10)
		cout << "Jack of ";
	else if(RANK==11)
		cout << "Queen of ";
	else 
		cout << "King of ";
	
	if(SUIT==0)
		cout << "Hearts";
	else if(SUIT==1)
		cout << "Spades";
	else if(SUIT==2)
		cout << "Diamonds";
	else 
		cout << "Clubs";
}

void PlayersCardHand(int PlayersHand[], int PlayersDealtHand)
{
	int CardIndex;

	for(CardIndex = 0; CardIndex < PlayersDealtHand; CardIndex++) {
		const int NewCard = PlayersHand[CardIndex];
		cardCharacters(NewCard);
		cout << " ";
	}
	cout << endl;

}

void HousesCardHand(int HousesHand[], int HousesDealtHand)
{
	int CardIndex;

	for(CardIndex = 0; CardIndex < HousesDealtHand; CardIndex++) {
		const int NewCard = HousesHand[CardIndex];
		cardCharacters(NewCard);
		cout << " ";
	}
	cout << endl;
}

int PlayersHandScore(int PlayersHand[], const int PlayersDealtHand) 
{
	int AceCount	= 0;
	int Score		= 0;
	int CardIndex;
	for (CardIndex = 0; CardIndex < PlayersDealtHand; CardIndex++) {
		const int NextCard = PlayersHand[CardIndex];
		const int Rank = (NextCard % 13);
		if (Rank == 0) {
			AceCount++;
			Score++;
		} 
		else if (Rank < 9) {
			Score += (Rank + 1);
		} 
		else {
			Score += 10;
		}
	}
	while (AceCount > 0 && Score < 12) {
		AceCount--;
		Score +=  10;
	}
	return Score;
}

int HousesHandScore(int HousesHand[], const int HousesDealtHand)
{
	int AceCount	= 0;
	int Score		= 0;
	int CardIndex;
	for (CardIndex = 0; CardIndex < HousesDealtHand; CardIndex++) {
		const int NextCard = HousesHand[CardIndex];
		const int Rank = (NextCard % 13);
		if (Rank == 0) {
			AceCount++;
			Score++;
		} 
		else if (Rank < 9) {
			Score += (Rank + 1);
		} 
		else {
			Score += 10;
		}
	}
	while (AceCount > 0 && Score < 12) {
		AceCount--;
		Score +=  10;
	}
	return Score;
}

void ScoresAndHands(int HousesHand[], const int HousesDealtHand, int PlayersHand[], const int PlayersDealtHand) 
{
	cout << "House's Hand: Score = " << HousesHandScore(HousesHand, HousesDealtHand) << endl;
	HousesCardHand(HousesHand, HousesDealtHand);
	cout << "Player's Hand: Score = " << PlayersHandScore(PlayersHand, PlayersDealtHand) << endl;
	PlayersCardHand(PlayersHand, PlayersDealtHand);
	cout << endl;
}

[joeriMJ]

Ugh, that's a lot of code.

What does or doesn't it do? What do you expect?
Where is the problem situated?

Any debugging info ?

[ohsnap1319]

Well. This program is supposed to be a blackjack program. But unfortunately I think that I completely messed up on programming it. First off, the program compiles but nothing happens. I need to resolve this problem before I can even begin to resolve anything else.

[UNkillableThrill]

Not that I am some awesomely skilled coder or anything, but where are the comments? One of my first instructors drilled that into us and I suggest you teach yourself the same thing. thorough commenting not only helps other people understand what your code is doing, but will help you when you look back on the code. That being said, I will take a look at the code in a few hours when I am at a computer with an IDE.

GL,
UNkillableThrill

edit (10:31am) - line 38: you need a second ')'
edit (10:34am) - line 169: (NewCard/13); should be (NewCard%4);

edit (10:37am) - line 166: I would not use if/else so much, it can make it a little hard to follow the code. In this situation, I would use switch(). Example:

 
switch(RANK){
  case 0:
    cout << "Ace of ";
  case 10:
    cout << "Jack of ";
  case 11:
    cout << "Queen of ";
  case 12:
    cout << "King of ";
  default:
    cout << RANK+1 << " of ";
}

Note, as I did above, you also want to put a space after the card value so that the suit is not stuck on the back end of the word "of": cout << "Ace of ";

[UNkillableThrill]

One more question, have you used structures or pointers at all yet? If you have experience with those, then I would suggest making the players' hands and the deck an array of Card structs. Pass a pointer to the individual card to the functions. Ex:

struct Card{
  string name;  // to use a string, you will need to also use #include <string>
  int suit;
  int value;
};

Then you can use the case to also append the name variable to say the card's value:

Card newCard;
// let's assume you initialize newCard to have a value of 11 and a suit of 4
//your cardCharacter() will now be written like this (assuming you pass a pointer to the card):
switch(newCard->value){
  case 0:
    newCard->name = "Ace of ";
  case 10:
    newCard->name = "Jack of ";
  case 11:
    newCard->name = "Queen of ";
  case 12:
    newCard->name = "King of ";
  default:
    newCard->name = value + 1;
    newCard->name.append(" of ");
}

//and your  switch() for the suit would be:

switch(newCard->suit){
  case 0:
    newCard->name.append("Hearts");
  case 1:
    newCard->name.append("Spades");  
  case 2:
    newCard->name.append("Diamonds"); 
  case 3:
    newCard->name.append("Clubs"); 
  default:
    cout << "INVALID SUIT VALUE";
}