C++11 File input output

[d1729]

I am trying to solve the usaco gift1 problem(greedy gift covers) but I am getting all the answers as friend's name followed by 0.Please can someone help?
The question:
A group of NP (2 ≤ NP ≤ 10) uniquely named friends has decided to exchange gifts of money. Each of these friends might or might not give some money to any or all of the other friends. Likewise, each friend might or might not receive money from any or all of the other friends. Your goal in this problem is to deduce how much more money each person gives than they receive.

The rules for gift-giving are potentially different than you might expect. Each person sets aside a certain amount of money to give and divides this money evenly among all those to whom he or she is giving a gift. No fractional money is available, so dividing 3 among 2 friends would be 1 each for the friends with 1 left over -- that 1 left over stays in the giver's "account".

In any group of friends, some people are more giving than others (or at least may have more acquaintances) and some people have more money than others.

Given a group of friends, no one of whom has a name longer than 14 characters, the money each person in the group spends on gifts, and a (sub)list of friends to whom each person gives gifts, determine how much more (or less) each person in the group gives than they receive.

IMPORTANT NOTE

The grader machine is a Linux machine that uses standard Unix conventions: end of line is a single character often known as '\n'. This differs from Windows, which ends lines with two charcters, '\n' and '\r'. Do not let your program get trapped by this!

PROGRAM NAME: gift1

INPUT FORMAT

Line 1: The single integer, NP
Lines 2..NP+1: Each line contains the name of a group member
Lines NP+2..end: NP groups of lines organized like this:
The first line in the group tells the person's name who will be giving gifts.
The second line in the group contains two numbers: The initial amount of money (in the range 0..2000) to be divided up into gifts by the giver and then the number of people to whom the giver will give gifts, NGi (0 ≤ NGi ≤ NP-1).
If NGi is nonzero, each of the next NGi lines lists the the name of a recipient of a gift.
SAMPLE INPUT (file gift1.in)

5
dave
laura
owen
vick
amr
dave
200 3
laura
owen
vick
owen
500 1
dave
amr
150 2
vick
owen
laura
0 2
amr
vick
vick
0 0
OUTPUT FORMAT

The output is NP lines, each with the name of a person followed by a single blank followed by the net gain or loss (final_money_value - initial_money_value) for that person. The names should be printed in the same order they appear on line 2 of the input.

All gifts are integers. Each person gives the same integer amount of money to each friend to whom any money is given, and gives as much as possible that meets this constraint. Any money not given is kept by the giver.

SAMPLE OUTPUT (file gift1.out)

dave 302
laura 66
owen -359
vick 141
amr -150



//code
#include <iostream>
#include <cstring>
#include <fstream>
#include <ctype.h>
#include <string>
#include <cstdlib>
#include <cstdio>
#include <limits>
using namespace std;
int main(int argc, const char * argv[]) {
ofstream fout("gift1.out");
ifstream fin("gift1.in");
int np,i;
fin>>np;
fin.ignore(numeric_limits<streamsize>::max(),'\n');
string *s;
int money[np];
s=new string[np];
for (i=0; i<np; i++) {
getline(fin, s[i]);
money[i]=0;
}
string s1;
string s2,s3;
int x,y,j;
while(getline(fin, s1)){
getline(fin, s1);
fin>>x>>y;
fin.ignore(numeric_limits<streamsize>::max(),'\n');
for (i=0; i<np; i++) {
if(s1.compare(s[i])==0){
money[i]-=(x/y)*y;
}
}
for(j=0;j<y;j++){
getline(fin,s1);
for(i=0;i<np;i++){
if(s1.compare(s[i])==0){
money[i]+=x/y;
}
}
}
}
for(i=0;i<np;i++){
fout<<s[i]<<" "<<money[i]<<endl;
}
return 0;
}

[coder777]

You should check whether the files could be opened, othewise you get bad results.

Change int money[np]; -> int money = new int[np];
The stack shouldn't contain variable length arrays.

I cannot exactly say why this happens (since i don't know the file format and you don't provide data to test), but integer division (x/y) are prone to result 0 since they don't have a decimal point. Better use float or double instead