Counter Isn't Working For My Game

closed account (NU9yT05o)
I don't understand why my counter(In my display function) is giving me weird numbers. I will post what the output should be in the comments.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
#include <iostream>
#include <fstream>
#include <iomanip>
using namespace std;

const int SIZE = 20;
void displayGrid( bool [][SIZE]);
void nextGeneration(bool [][SIZE], bool [][SIZE]);
int getNeighborCount(const bool [][SIZE], int, int);
void readGrid(bool [][SIZE]);
void initGrid(bool [][SIZE]);
int liveCellNeighbors(bool [][SIZE], int, int);
int deadCellNeighbors(bool [][SIZE], int, int);
int getTotalLive(bool [][SIZE], int, int);
int getTotalDead(bool [][SIZE], int, int);


int main()
{

  // Initilize the grid to all dead cells
  bool Grid[SIZE][SIZE];
  int row, col;

  // Prompt user for initially living cells. Ignore illegal inputs.
  readGrid(Grid);


  bool temp[SIZE][SIZE];   // temporary workspace for computing next generation
  for (int count = 0; count <= 5; count++)
  {
       displayGrid(Grid);
       nextGeneration(Grid, temp);

  };




  return 0;
}




int getTotalLive(bool World[][SIZE], int row, int col)
    {
        int numLive=0;


        for(int i = 0 ; i < row ; i++)
        {
            for(int j = 0 ; j < col ; j++)
            {
                if(World[row][col] == )
                    numLive++;
            }
        }


        return numLive;
    }




int getTotalDead(bool World[][SIZE], int row, int col)
    {
        int numDead = 0;

        for(int i = 0 ; i < row ; i++)
        {
            for(int j= 0 ; j < col ; j++)
            {
                if(World[row][col]== false)
                    numDead++;
            }
        }


        return numDead;
    }
int liveCellNeighbors(bool World[][SIZE], int row, int col)
{
    int neighbors;

    if(World[row][col]== true && World[row][col-1]==true && col-1>=0)
          {
          neighbors++;
          }
          if(World[row][col]== true && World[row+1][col-1]==true && row+1<3 && col-1>=0)
          {
          neighbors++;
          }
           if(World[row][col]== true && World[row+1][col]==true && row+1<3)
          {
          neighbors++;
          }
          if(World[row][col]== true && World[row][col+1]==true && col+1<SIZE)
          {
          neighbors++;
          }

         if(World[row][col]== true && World[row-1][col-1]==true && row-1>=0 && col-1>=0 )
          {
          neighbors++;
          }
          if(World[row][col]== true && World[row+1][col+1]==true && row+1<3 && col+1<SIZE)
          {
          neighbors++;
          }
          if(World[row][col]== true && World[row-1][col]==true && row-1>=0)
          {
          neighbors++;
          }
          if(World[row][col]== true && World[row-1][col+1]==true && row-1>=0 && col+1<SIZE)
          {
          neighbors++;
          }

   return neighbors;
}



int deadCellNeighbors(bool World[][SIZE], int row, int col)
{
    int neighbors;

    if(World[row][col]== true && World[row][col-1]==true && col-1>=0)
          {
          neighbors++;
          }
          if(World[row][col]== false && World[row+1][col-1]==true && row+1<3 && col-1>=0)
          {
          neighbors++;
          }
           if(World[row][col]== false && World[row+1][col]==true && row+1<3)
          {
          neighbors++;
          }
          if(World[row][col]== false && World[row][col+1]==true && col+1<SIZE)
          {
          neighbors++;
          }

         if(World[row][col]== false && World[row-1][col-1]==true && row-1>=0 && col-1>=0 )
          {
          neighbors++;
          }
          if(World[row][col]== false && World[row+1][col+1]==true && row+1<3 && col+1<SIZE)
          {
          neighbors++;
          }
          if(World[row][col]== false && World[row-1][col]==true && row-1>=0)
          {
          neighbors++;
          }
          if(World[row][col]== false && World[row-1][col+1]==true && row-1>=0 && col+1<SIZE)
          {
          neighbors++;
          }

   return neighbors;
}





void readGrid(bool World[][SIZE])
{
    ifstream infile("bacteria.txt");

    int numBacteria, row, col;

    initGrid(World);  //initialize grid

    infile >> row >> col;
    while (infile){
        World[row][col] = true;
        infile >> row >> col;
    }
    infile.close();
}

void initGrid(bool World[][SIZE])
{
    for (int row = 0; row < SIZE; row++){
        for (int col = 0; col < SIZE; col++){
            World[row][col] = false;
        }
    }
}

void displayGrid(bool World[][SIZE])
{
  cout << "  01234567890123456789" << endl;
    for (int row = 0; row < SIZE; row++){
        cout << setw(2) << row;
        for (int col = 0; col < SIZE; col++){
            if (World[row][col]){ //if true, cell is "alive"
                cout << "*";
            } else {             //if false, cell is "dead"
                cout << " ";
            }
        }
        cout << endl;
    }



cout<<"Total alive in row 10 = "<<getTotalLive(World, 10, SIZE)<<endl;
cout<<"Total alive in col 10 = "<<getTotalLive(World, SIZE, 10)<<endl;
cout<<"Total dead in row 16 = "<<getTotalDead(World, 16, SIZE)<<endl;
cout<<"Total dead in col 1 = "<<getTotalDead(World, SIZE, 1)<<endl;
cout<<"Total alive = "<<getTotalLive(World, SIZE, SIZE)<<endl;
cout<<"Total dead = "<<getTotalDead(World, SIZE, SIZE)<<endl;
}

// Declares a local array of states and sets it to the next generation
// by looping thru the object's World array, and for each cell calling
// the getNeighborCount function to see whether it should live or die.
// Once the temporary array is filled, it is copied over to the
// object's World array.
void nextGeneration(bool World[][SIZE], bool tempWorld[][SIZE])
{
  int neighborCnt;
  for (int i=0; i < SIZE; i++)
    for (int j=0; j < SIZE; j++) {
      neighborCnt = getNeighborCount(World,i,j);
      if (neighborCnt == 2)             // 2 live neighbors:
	tempWorld[i][j] = World[i][j];  // unchanged in next generation.
      else if (neighborCnt == 3)
	tempWorld[i][j] = true;         // 3 live neighbors:
                                        // alive in next generation

      else tempWorld[i][j] = false;      // 1, 4-8 living neighbors:
    }                                    // dead in next generation

  // copy tempWorld to World
  for (int i=0; i < SIZE; i++)
    for (int j=0; j < SIZE; j++)
      World[i][j] = tempWorld[i][j];
}

int getNeighborCount(const bool World[][SIZE], int row, int col)
// This function takes a row/col pair and counts the number
// of living neighbors for the specified cell.
{
//  1 2 3       These are the positions of the
//  4 x 5       neighbors of x. Each is checked
//  6 7 8       below for alive/dead.

  int cnt=0;

  if (row > 0) {
    if (col > 0 && World[row-1][col-1] == true)          // check 1
      cnt++;
    if (col < SIZE-1 && World[row-1][col+1] == true)     // check 3
      cnt++;
    if (World[row-1][col] == true)                       // check 2
      cnt++;

  }

  if (row < SIZE - 1) {
    if (col > 0 && World[row+1][col-1] == true)          // check 6
      cnt++;
    if (col < SIZE - 1 && World[row+1][col+1] == true)   // check 8
      cnt++;
    if (World[row+1][col] == true)                       // check 7
      cnt++;
  }

  if (col > 0 && World[row][col-1] == true)              // check 4
    cnt++;
  if (col < SIZE - 1 && World[row][col+1] == true)       // check 5
    cnt++;

  return cnt;
}

Check line 55, what are you meant to be comparing with here?

In function liveCellNeighbors (line 83) you increment an uninitialized variable called neighbors, same with deadCellNeighbors
Topic archived. No new replies allowed.