How to get out of this while-loop

[nunchuckie]

Hi guys, I just started practicing C++.
Right now I'm trying to put lines of text to a file one by one manually and then stop puting in text by typing end. The thing is that I don't really know how to put the whole line of text one by one into a file and then stop the input by typing a command like "end"...


#include<iostream>
#include<fstream>
using namespace std;

int main()
{
char filename[30];
string sentence;
int i = 2;

cout << "Name your file: ";
cin >> filename;

ofstream outputfile(filename, ios::out);
string text;

cout << endl << "Row 1: ";

while (sentence != "end") // <- Lol! :(
{
cin >> text;
getline(cin, text);
outputfile << sentence << endl;
cout << "Row " << i << ": ";
++i;
}

... more code..

return 0;
}

[Disch]

You're getting user input and putting it into text, not sentence. You never set sentence to anything.

Also... you're using cin >> and getline to get input. Pick just one of them. You can't do both like that. At best you'll skip every other sentence.

[nunchuckie]

Yes ofc, thank you! I changed my code to this and now the input and the break out of the loop works. But I have a new problem, I output the "Row number" one time too much. It seems like the program is going through the loop one time at the beginning to check ( text != "end" ) and this gives me one "Row number" too much at the beginning.

while (text != "end") 
{
   cout << "Row " << i << ": "; 
   getline(cin, text);
   outputfile << text << endl;
   ++i;
} 

EDIT;

fixed the little probelm by doing this

int i = 0;

while (text != "end") 
{
   ++i;
   getline(cin, text);
   outputfile << text << endl;
   cout << "Row " << i << ": "; 
} 

But now it outputs one "Row number" too much when i jump out from the loop.

[Disch]

Look just before that while loop. Did you forget to delete the cout << endl << "Row 1: " line you have in your original post?

EDIT: I'm too slow for the edit. Although I don't think your fix helped. Try switching back to what you had before and get rid of the preceeding cout line.

[nunchuckie]

Oh, I forgot to mention that i did get rid of the one preceeding cout line.

#include<iostream>
#include<fstream>

using namespace std;

int main()
{

  char filename[30];
  string  sentence;

  int i = 0;

  cout << "Name your file: ";

  cin >> filename;
  
  ofstream outputfile(filename, ios::out);
  
  cout << endl;

  while (sentence != "end")
    {
      ++i;
      getline(cin, sentence);
      outputfile << sentence << '\n';       
      cout << "Rad " << i << ": "; 
    }
    
  
  return 0;
  
}

Example of the output would look like this:

Name your file: text.txt

Row 1: Hi what a nice day
Row 2: How are you
Row 3: end
Row 4:

..end of example, but as you see there is a row 4 too much.

[Disch]

change your while loop to how it was in your previous post.

[nunchuckie]

Hi, thanks for your reply. But it seems like the problem persist.

The output turn to look like this instead:

Name your file: text.txt

Row 1: Row 2: Hi what a nice day
Row 3: end

But I did this and it seemed to work

  while (sentence != "end")
    { 
      getline(cin, sentence);
      outputfile << sentence << '\n';       
      if(sentence != "end")    
	{
	  cout << "Rad " << i << ": "; 
	  ++i;
	}
    }

thx for your help.