Logical Errors with Arrays.

[Akyrun]

This program is now fixed for syntax errors.
Now I am having issues with the arrays.
When the program starts, all the slots for the inventory are filled with 0s.
When I go to add item, it won't show.
I hate arrays right now haha.
Any help is appreciated.

/************************************************
Array Sample
*************************************************/

#include <iostream>
#include <string>
#include <iomanip>

using namespace std;

//******* Global Parallel Arrays *********
const int carArraySize = 5;

string carMakeArray[carArraySize];
string carModelArray[carArraySize];
int carYearArray[carArraySize];
double carPriceArray[carArraySize];

//******* Function Prototypes ***********
void initArrays();
void displayArrays();
void addToArrays();
void removeFromArrays(int);

int main()
{
	int choice = 0;
	int arraySubscript = 0;

	initArrays();

	do
	{
		system("cls");
		displayArrays();
		cout << endl << endl;
		cout << "==== Car Inventory Options ====" << endl << endl;
		cout << "1. Add to Inventory" << endl;
		cout << "2. Remove from Inventory" << endl;
		cout << "3. End Program" << endl << endl;
		cout << "Please make a selection: ";
		cin >> choice;

		switch(choice)
		{
		case 1:
			addToArrays();
			break;
		case 2:
			system("cls");
			displayArrays();

			cout << endl << endl;
			cout << "Please enter the Index number of the car to remove: ";
			cin >> arraySubscript;
			
			removeFromArrays(arraySubscript);
			break;
		case 3:
			return 0;
		default:
			cout << "Invalid Choice!" << endl;
			system("pause");
		}
	}while(true);

}

/**********************************************
Function: initArrays
Input:
Output:

Description:
Initializes the global parallel arrays
**********************************************/

void initArrays()
{
	for(int i = 0; i < carArraySize; i++)
	{
		carMakeArray[i] = "";
        carModelArray[i] = "";
		carYearArray[i] = 0;
		carPriceArray[i] = 0.0;
	}
	return;
}

/**********************************************
Function: displayArrays
Input:
Output:

Description:
Displays the global parallel arrays and allows basic operations.
**********************************************/

void displayArrays()
{
	system("cls");
	cout << "              ================= Car Inventory ====================" << endl << endl;
	cout << " Index     Year        Make                    Model                    Price" << endl;
	cout << "-----------------------------------------------------------------------------" << endl;
		
	for(int i = 0; i < carArraySize; i++)
	{
		if(carMakeArray[i] == "")
			cout << " " << i << ". " << "\t" << carYearArray[i] << "\t" << carMakeArray[i] << "\t" << carModelArray[i] << "\t" << setw(10) << carPriceArray[10] << endl;
	}

	return;
}

/**********************************************
Function: addToArrays
Input:
Output:

Description:
Allows additions to the global parallel arrays
**********************************************/

void addToArrays()
{	
	system("cls");

	for(int i = 0; i < carArraySize; i++)
	{
		if(carMakeArray[i] == "")
		{
			cout << "==== Add to Car Inventory ====" << endl << endl;
			cout << "Car Year: ";
			cin >> carYearArray[i];
			cout << "Car Make: ";
			cin >> carMakeArray[i];
			cout << "Car Model: ";
			cin >> carModelArray[i];
			cout << "Car Price: ";
			cin >> carPriceArray[i];
			return;
		}
		else
		{
			cout << "Not Enough Array Space!" << endl;
			system("pause");
			return;
		
	}
}
}

/**********************************************
Function: removeFromArrays
Input:
Output:

Description:
Allows removal from the global parallel arrays.
**********************************************/

void removeFromArrays(int subscriptFromMain)
{
	carMakeArray[subscriptFromMain] = "";
    carModelArray[subscriptFromMain] = "";
	carYearArray[subscriptFromMain] = 0;
	carPriceArray[subscriptFromMain] = 0.0;

	for(int i = 0; i < carArraySize - 1; i++)
	{
		if(carMakeArray[i] != "")
		{
			carMakeArray[i] = carMakeArray[i + 1];
			carModelArray[i] = carModelArray[i + 1];
			carYearArray[i] = carYearArray[i + 1];
			carPriceArray[i] = carPriceArray[i + 1];

			carMakeArray[i + 1] = "";
			carModelArray[i + 1] = "";
			carYearArray[i + 1] = 0;
			carPriceArray[i + 1] = 0.0;
		}
	}
}

[helios]

Lines 127-130 hide the global arrays.

[Akyrun]

Thanks... Have no idea why it was there.
Still puts out 0's though. =[

[helios]

See line 108.

[Akyrun]

Helios, what should I do...
I get it, I know whats wrong but I just can't think of how to fix it for some reason.

[helios]

If you can't figure out how to fix it, it's because you don't get it and you don't know what's wrong. Look very carefully at the line I pointed out, see what it's doing in its context.
I've already done too much by doing half the debugging for you. If I did more, you wouldn't learn anything.

[writetonsharma]

hehehehe... :D

[herbert1910]

ah. a guessing game. i won't ruin it for the two of you.

here is another clue:
there is no problem in line 136, but if you comment-out (remove) line 136, then numbers show up. try it:

// cin >> carMakeArray[i]; 

except, line 136 isn't the problem. line 136 is a good line. restore line 136, then fix the real problem in line 108.


there are more problems after you fix this display-only-0 thing. this game may take a while. i don't think helios is going to let you play outside today.