compiler error when filling a vector with info from a class.

[AC DC Bag]

Hello, I need help filling a vector that is in a class I created called List, with info that is input into a class called Item. I get one compiler error that say "Line 81 no overloaded function takes 4 arguments"

I think that means that the four arguments don't have anywhere to pass into, but these are two separate classes, so I didn't think there was anything being overloaded. I have tried a bunch of different arrangements and get more compiler errors. It sounds like I need to make a function call somewhere, or add another function to take the arguments and fill the vector, but I am not sure what to work on to get this compiling and running.

All of the info is brought in from the user, and the List constructor was working before I started trying to make and populate the vector.

Any kind help is appreciated, thank you.

#include <iostream>
#include <string>
#include <vector>

//using namespace std;
using std::cout;
using std::cin;
using std::endl;
using std::string;
using std::vector;

class Items
{

public:
	//default constructor
	Items();
	//member function declarations
	string getName();
	void setName (string name);
	int getNumber ();
	void setNumber (int number);
	string getUnits ();
	void setUnits(string units);
	double getPrice();
	void setPrice (double price);

protected:
//private:
	//variables (name, number, units, unit price)
	string name;
	int number;
	string units;
	double price;
};

class List
/*
			: public Items

store item objects on the list object, add an item, remove an item
provide 10% club card discount

as item objects are created they need to be stored as list objects
*/
{

public:
//default constructor
	List();
	
	void addListitem(vector<List>& p)
	{
		//function is to take item, number, units, and price, populate them to
		//a temp, then push them into the vector
	
	int pIndex = 0;

	double cost;
	string package;
	int quantity;
	string thing;
	
	//getName()
	//{
	thing = name;
	//}
	//getNumber()
	//{
	quantity = number;
	//}
	//getUnits()
	//{
	package = units;
	//}
	//Items.getPrice()
	//{
	cost = price;
	//}
	List pTemp(thing, quantity, package, cost);
	//(item,number,units,price);
	p.push_back(pTemp);
	pIndex++;
	}

private:
	string name;
	int number;
	string units;
	double price;

protected:

};


List::List()
{
	cout << " I have been constructed";

	/*
	void addListitem(vector<List>& p)
	{
		//function is to take item, number, units, and price, populate them to
		//a temp, then push them into the vector
		int pIndex = 0;
		double cost;
		string package;
		int quantity;
		string thing;



                List pTemp(thing,quantity,package,cost);
		p.push_back(pTemp);
		pIndex++;
	} 
	*/
}

int main()
{
vector <Items> p;

char input;
		cout << " You must input the item, number to buy, units it " << endl;
		cout << " comes in, and the cost per unit" << endl;
		cout << endl;
do
{
	string n;
		cout << " What item would you like to place on the list? " << endl;
		cin >> n;

	int k;
		cout << " How many " << n << " would you like to buy? " << endl;
		cin >> k;

	string m;
		cout << " What units do the " << n << " come in? " << endl;
		cin >> m;

	double v;
		cout << " What is the price per " << m << " of " << n << "?" << endl;
		cin >> v;
		cout << endl;

	cout << "ITEM: " << "NUMBER: " << "UNITS: " << "PRICE: " << endl;
	cout << endl;

	//constructors...
	Items Items;
	
		Items.setName (n);
		Items.setNumber (k);
		Items.setUnits (m);
		Items.setPrice (v);
		cout << endl;
		
		cout << " type y to continue making the list, and add another item" << endl;
		cout << "type any other character to move along without adding another item" << endl;
		cin >> input;
		cout << endl;

			List List;
		Items.getName();
		Items.getNumber();
		Items.getUnits();
		Items.getPrice();
}

while (input == 'y' || input == 'Y');

	cout << endl << endl;

	cin.ignore();
	cin.get();
	return 0;
}

	//create object
	Items::Items()
	{
	}
	
	//member functions (accessors and mutators)
	string Items::getName()
	{
	return name;
	}

	void Items::setName(string i)
	{
		name = i;	
		cout << " " << name;
	}

	int Items::getNumber()
	{
	return number;
	}

	void Items::setNumber(int a)
	{	
		number = a;
		cout << "  " << number << "      ";
	}

	string Items::getUnits()
	{
	return units;
	}

	void Items::setUnits(string b)
	{
		units = b;
		cout << " " << units << "  ";
	}

	double Items::getPrice()
	{
	return price;
	}

	void Items::setPrice(double c)
	{
		price = c;
		cout << " " << price << endl;
	}

[LendraDwi]

Create another constructor in List that take 4 argument

[AC DC Bag]

Thank you for the advice, but I really don't understand. Any new constructor that I try to add with a parameter list only causes more errors, and if I try to add a parameter list to the default constructor, more errors.

I must be missing something in the function setup that isn't taking arguments right?

[AC DC Bag]

Ok, thank you again. I was able to get the compiler to run without error, but I do have a question.

Why did it work when I made a new constructor, identical to the default constructor, but with a parameter list?

Is the default constructor always just kind of a reference, that shouldn't have any parameters?

[AC DC Bag]

So now that things will compile, would someone be so kind as to help me build and display the vector that takes the list items?

Thanks again to LendraDwi, I really appreciate the help.

#include <iostream>
#include <string>
#include <vector>

//using namespace std;
using std::cout;
using std::cin;
using std::endl;
using std::string;
using std::vector;

class Items
{

public:
//default constructor
Items();
//member function declarations
string getName();
void setName (string name);
int getNumber ();
void setNumber (int number);
string getUnits ();
void setUnits(string units);
double getPrice();
void setPrice (double price);

protected:
//private:
//variables (name, number, units, unit price)
string name;
int number;
string units;
double price;
};

class List
/*
: public Items

store item objects on the list object, add an item, remove an item

provide 10% club card discount as a separate class, add a distinction that will allow an item to be added to the correct list

as item objects are created they need to be stored as list objects
*/
{

public:
//default constructor
List();
List(double, int, string, string);

void addListitem(vector<List>&p)
{
//function is to take item, number, units, and price, populate them to
//a temp, then push them into the vector

int pIndex = 0;

double cost;
int quantity;
string package;
string thing;

cost = price;

quantity = number;

package = units;

thing = name;

List pTemp(cost, quantity, package, thing);
p.push_back(pTemp);
pIndex++;
}

private:
double price;
int number;
string name;
string units;


protected:

};


List::List()
{
cout << " I have been constructed" << endl << endl;
//cout << &List::addListitem;
}


int main()
{
vector <Items> p;

char input;
cout << " You must input the item, number to buy, units it " << endl;
cout << " comes in, and the cost per unit" << endl;
cout << endl;
do
{
string n;
cout << " What item would you like to place on the list? " << endl;
cin >> n;

int k;
cout << " How many " << n << " would you like to buy? " << endl;
cin >> k;

string m;
cout << " What units do the " << n << " come in? " << endl;
cin >> m;

double v;
cout << " What is the price per " << m << " of " << n << "?" << endl;
cin >> v;
cout << endl;

cout << "ITEM: " << "NUMBER: " << "UNITS: " << "PRICE: " << endl;
cout << endl;

//constructors...
Items Items;

Items.setName (n);
Items.setNumber (k);
Items.setUnits (m);
Items.setPrice (v);
cout << endl;

cout << " type y to continue making the list, and add another item" << endl;
cout << "type any other character to move along without adding another item" << endl;
cin >> input;
cout << endl;

List List;
Items.getName();
Items.getNumber();
Items.getUnits();
Items.getPrice();
}

while (input == 'y' || input == 'Y');

cout << endl << endl;

cin.ignore();
cin.get();
return 0;
}

//create object
Items::Items()
{
}

//member functions (accessors and mutators)
string Items::getName()
{
return name;
}

void Items::setName(string i)
{
name = i;
cout << " " << name;
}

int Items::getNumber()
{
return number;
}

void Items::setNumber(int a)
{
number = a;
cout << " " << number << " ";
}

string Items::getUnits()
{
return units;
}

void Items::setUnits(string b)
{
units = b;
cout << " " << units << " ";
}

double Items::getPrice()
{
return price;
}

void Items::setPrice(double c)
{
price = c;
cout << " " << price << endl;
}

[cire]

Is the default constructor always just kind of a reference, that shouldn't have any parameters?

A default constructor is, by definition, a constructor that can be invoked with no arguments.

Presumably your List class should have a private member that is the vector that holds objects of type Items.

[AC DC Bag]

Thank you for the answer and the advice. I have lots of code working now, but it is kind of all over the place once I get past the input. I have to shuffle things around and make things as you suggest.

Thanks very much.