loop all the time when hitting q to quit

[bcav311]

when i hit q to quit it goes into an infi loop and just goes over and over. Is there another way to make this quit?

  #include <iostream>


using namespace std;

void myswap(int &num1, int &num2);


int main(int argc, char** argv) {

	int num1, num2, num3, temp;
    char quit='a';

cout << "Number Swapper\n" << endl;



while (quit != 'q')
{
	cout << "Enter Three numbers: ";

	cin >> num1 >> num2 >> num3;

	cout << "Your numbers in order are: ";
	// Compares the first two numbers inputted
		if (num1 >= num2)
		{
			myswap(num1, num2);
		}
	// compares the last number
		 if (num3 <= num2 && num3 <= num1)
		 {
		 	myswap(num3, num2);

		 	myswap(num1, num2);
		 }
	// compares the last and middle
		if(num3 >= num1 && num3 <= num2)
		{
			myswap(num3, num2);
		}

		cout << num1 << " " << num2 << " " << num3 << endl;// outputs the numbers in order

            // press q to quit
		if (quit == 'q')

        break;


}
cin >> num1;



	return 0;
}


//pulling function myswap
void myswap(int & num1, int & num2)
{
	int temp = num1;
	num1 = num2;
	num2 = temp;
}

[Semoirethe]

You're never inputting to quit. Add

    cout << "Press q to quit or c to continue";
    cin >> quit;

or something similar right above the if(quit == 'q') statement.

What is happening is that you're attempting to input a char to an int and the cin.fail() flag is being thrown. Once that happens all cin>> statements are ignored until you fix it and it's just looping infinitely.

[bcav311]

ya i did that and it is not letting the loop continue right after the first numbers are imputed. is there a way for me to add it to my first cout like

cout<< "enter 3 numbers or press q to quit";

having that at the beginning and then have the loop continue until q is pressed?

[Semoirethe]

This is very clunky and weird style but:

while (true)
{
    cout<< "enter 3 numbers or press q to quit"

    cin >> num1 >> num2 >> num3;
    if(cin.fail()) {
        cin.clear();
        cin.ignore(100, '\n');
        break;
    }
.
.
.
}

should work.

[bcav311]

hmmm, it does stop it, but it only stops asking me to input things.

like when i hit q it will just let me keep hitting enter.

  

cout <<"Please enter a number between 1 and 10: ";
	cin >> size;
	if (size < 0 || size > 10)
        {
		cout <<"That is not a positive number, please try again!! " <<endl;
		cin >> size;
	    }


	while(quit != 'q')
	{
		for (int row = 0; row < size; row++)
           {
			for (int col = 0; col < size; col++)
            {
				if (row==0 || row == (size-1) )
				{
					if (col == 0 || col == size - 1)
						cout <<  "-";
					else
                      {
						cout << "-";
					  }

				}
				else if (col==0 || col == (size-1) )
					cout <<"|";
				else
					cout <<" ";
			}

			cout << "Try again or press q to quit" << endl;
			cin >> quit;

			if (quit == 'q')
                break;

                else
                {
                    for (int row = 0; row < size; row++)
           {
			for (int col = 0; col < size; col++)
            {
				if (row==0 || row == (size-1) )
				{
					if (col == 0 || col == size - 1)
						cout <<  "-";
					else
                      {
						cout << "-";
					  }

				}
				else if (col==0 || col == (size-1) )
					cout <<"|";
				else
					cout <<" ";
                }

		   }
                }
           }
	}

	return 0;
}

i tried something similar to this but for some reason it will not work right in the other program

[Semoirethe]

That's because you have a random cin outside the loop itself. Just remove that, it works fine for me without it.