Problems with sprintf

CODE:

//(...)

char* metod=strtok(request," ");
char* object=strtok(NULL," ");
char* protocol=strtok(NULL,"\n");
object=strtok(object,"/");

char response[1000];

const char* response_404 = "404 Not Found\n";
const char* html_response_404 = "<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL was not found on this server.</p>\n</body><html>\n";

sprintf(response,"%s %s\n%s",protocol,response_404,html_response_404);
cout << response << endl;

OUT:

404 Not Found

<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL was not found on this server.</p>
</body><html>

SHOULD BE:

HTTP/1.1 404 Not Found

<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL was not found on this server.</p>
</body><html>

What am I doing wrong?

Last edited on

Bazzy (6281)

Please use [code][/code] tags
You are missing the opening double-quotes sign:
sprintf(response,%s %s\n%s",protocol,response_404,html_response_404);

response is not big enough

Last edited on

esehacker (4)

it's still not working

Bazzy (6281)

Can you post the code you have for _404 strings declaration?
The code above should work fine

esehacker (4)

Here it is (edited above).

Bazzy (6281)

That code should work. The only issue I see is that the names don't match but that seems only a copy-paste error
Is protocol ever changing the address it's pointing to?

esehacker (4)

If I do this:

const char* protocol2;

      if (strcmp(protocol,"HTTP/1.0"))
	{
	  protocol2 = "HTTP/1.0";
	}
      if (strcmp(version,"HTTP/1.1"))
	{
	  protocol2 = "HTTP/1.1";
	}

sprintf(response,"%s %s\n%s",protocol2,response_404,html_response_404);
cout << response << endl;

It works! But I don't know why...

Topic archived. No new replies allowed.

C++

Forum

Problems with sprintf