converting string to int and checking for a comma.

[Bocian]

Hello, im in the process of writing a input validation code. But i seem to be stuck on a certain part. For the first part, i need to check that my input has a comma in it and if it doesn't it should loop back. I have already completed the previous loops to check for digits and character lengths. And I need to convert a string into an int in order to return the function.

 const int SIZE = 50; 
    char input[SIZE];
	cin.getline (input,SIZE);

	
    int numChar = 0, cnt = 0;

	while(input[cnt++] != '\0')
	{
		numChar++;
	}

	if  (numChar >= 30)    
	{
		
	cout << "Error, Must be no greater than 30 characters long.\n";
	}

	
	for (int cnt = 0; input[cnt] != '\0'; cnt++)
	{
		if (isdigit(input[cnt]))
		cout << "Error, name must not contain a digit.\n";
		
	}
	
	for (int cnt = 0; input[cnt] != '\0'; cnt++)
	{
		if (input[cnt] != ',')
		{
			cout << "Error, password must contain a comma.\n";
			
		}
	}


int GetID (void)
{
	string input;
	int x = 1;
	cin >> input;
	int maxstring = 4;

	while ( input.size() != 4)
	{
		cout << " Id must be 4 numbers" << endl;
		cin >> input;
	}
	
	//x = input;
	//return x;
	return x;
}

[Bocian]

int GetID (void)
{
	string input;
	cin >> input;
	int maxstring = 4;

	while ( input.size() != 4)
	{
		cout << " Id must be 4 numbers" << endl;
		cin >> input;
	}
	
	std::istringstream buf(input.substr(0,4));
	long int num;
	buf >> num;
	cout << num;
	

	return num;
}

updated code

[fg109]

	for (int cnt = 0; input[cnt] != '\0'; cnt++)
	{
		if (input[cnt] != ',')
		{
			cout << "Error, password must contain a comma.\n";
			
		}
	}

You are crying "Error!" whenever a character is not a comma. Perhaps you should try counting how many commas there are instead.

[Bocian]

i still need help, my getname function gets skipped over and i still don't know how to check for comma.

Here is my entire program:

#include <iostream>
#include <string>
#include <iomanip>
#include <sstream>
using namespace std;

string GetName (void);
int GetID (void);
int GetYear ( void);
string GetGender (void) ; 
//****************************************************************************************************
int main()
{
	const int SIZE = 50; 
    char input[SIZE];
	string output, gender, name;
	int year, id;


	year = GetYear(); // done
	name = GetName();
	id = GetID (); // done
	gender = GetGender(); // done



	cout << name;
	cout << setw(7) << "ID:" << id;
	cout << setw(10) << "       Graduated in:" <<  year;
	cout << setw(10) <<gender;
	cout << endl;
	
	return 0;
}
//****************************************************************************************************

string GetGender (void)
{

	char gender;
	string x;
	cout << "What is your gender?" << endl;
	cin >> gender;
	
	 while ( !(gender == 'm' || gender == 'M' || gender == 'f' || gender == 'F') )
   {
      cout << "Please, enter F or M: ";
      
      cin.clear();
      cin.ignore (1000, '\n');

      cin >> gender;
   }
	 if ( gender == 'f')
	 {
		 gender = 'F';
	 }
	  if ( gender == 'm')
	 {
		 gender = 'M';
	 }

	if ( gender = 'f')
	{
		x = "Female";
	}
		
	if ( gender = 'M')
	{
		x = "Male";
	}
	
	return x;



	
}

	
//****************************************************************************************************
int GetID (void)
{
	cout << "Enter your ID number" << endl;
	string input;
	cin >> input;
	

	while ( input.size() != 4)
	{
		cout << " Id must be 4 numbers" << endl;
		cin >> input;
	}
	
	std::istringstream buf(input.substr(0,4));
	long int num;
	buf >> num;

	

	return num;
}
//****************************************************************************************************

string GetName (void)
{
	

	const int SIZE = 50; 
	int value; 
    char input[SIZE];
	cout << "Enter your name" << endl;
	cin.getline (input,SIZE);

	
    int numChar = 0, cnt = 0;

	while(input[cnt++] != '\0')
	{
		numChar++;
	}

	if  (numChar >= 30)    
	{
		
	cout << "Error, Must be no greater than 30 characters long.\n";

	}

	
	for (int cnt = 0; input[cnt] != '\0'; cnt++)
	{
		if (isdigit(input[cnt]))
		cout << "Error, name must not contain a digit.\n";


		
	}
	
	
	


	string output;
	output = input;
	return output;
}


	
//****************************************************************************************************

int GetYear (void)
{
	cout << "Enter your graduation year"; 
	start:
	string input;
	cin >> input;

	
	std::istringstream buf(input.substr(0,4));
	long int num;
	buf >> num;


	 if ((num >= 1895) && (num <= 2016)) 
	 {
        
	 }
	 else
	 {
		 cout << "Error, year must be from 1895 - 2016 and/or contain only 4 numbers\n";
		 goto start;
	 }

			
	return num;	
	
}