error: expected primary-expression before } token

[grandes4squatch]

Write your question here.
Hi, I'm having an error that I'm sure is a very easy fix, but I just cannot figure out how to fix it. I'm getting errors about expected primary expressions and none of the other forum posts are helping me much with my issue. I'm getting the errors on lines 229, 240-241, 263, and 267. Any help is greatly appreciated!

  #include<iostream>
#include<fstream>
#include<sstream>
#include<string>
#include<vector>
#include<algorithm>

using namespace std;

/*
//str2int convert a string to an integer
int str2int(string s){
        int n=atoi(s.c_str());
        return n;
}

(+*/

//To keep track of the input postion and the input data
class Buffer{
private:
        string s;
        int pos;
public:
        //To advance pos to where the next tag begins (on the <)
        int skipToTag(){
                while(pos<s.size() and s[pos]!='<')
                        pos++;
                return pos;
        }

        //Advance pos to immediately after the next tag
        //precondition: pos is positioned outside of a tag

        int skipPastTag(){
                while(pos<s.size() &&s[pos]!='>') pos++;
                pos++; //advance past the '>'
                return pos;
        }

        char get(){
                if(pos<s.length()){
                        return s[pos++];
                }
        return '\0'; //return null character of eob
        }

        string substr(int start, int finish){ //from [start,finish]
                string result = "";
                if(finish<s.size())
                        while (start<finish){
                                result = result + s[start];
                                start++;
                        }
                return result;
	    }

        bool eob(){
                return pos >=s.length();
        }

        void read(istream &fin){
                s = "";
                char ch;
                while(fin.get(ch)){
                        s = s + ch;
                }
        }

        void write(ostream &fout){
                fout << s;
        }
}buffer; //Declare the buffer -- as a global variable!

string getTag (Buffer &buffer){
        string result = "";
        buffer.skipToTag(); //positioned at '<'
        char ch;
        buffer.get(); //skip the '<'
        if(buffer.eob())
                return result;
        else {
                ch = buffer.get();
                while(!buffer.eob() and ch!='>'){
                        result = result + ch;
                        ch = buffer.get();
                }
                buffer.get(); //advance past the '>'
                return result;
        }
}

class Person{
protected:
        string first;
        string last;
public:
        Person(){first= ""; last = "";}
        Person(string first, string last){
                this-> first = first; this-> last = last;
        }
        string getField() const {return last;}

        // to read the xml
        void read(){

                int start = buffer.skipPastTag(); // to skip past the <>
                int finish = buffer.skipToTag(); // skip to </>
                first = (buffer.substr(start, finish));



                buffer.skipPastTag(); //skip past </>
                start = buffer.skipPastTag(); //skip past <
                finish = buffer.skipToTag(); //skip to </>
                last =(buffer.substr(start, finish));

                //to throw the rest away
                buffer.skipPastTag();
                buffer.skipPastTag();
        }


        void write(ostream &fout){
                fout << "<Person>" << endl;
                fout << "       <First>" << first << "</First>" << endl;
                fout << "       <Last>" << last << "</Last>" << endl;
                fout << "</Person>" << endl;
        }


};

class Student : public Person{
private:
        Person t1;
        string s;
        string major;
        string gpa;
public:
        Student(Person t1, string s){
                this -> t1 = t1; this -> s = s;
        }
        string getField() const {return last;}
        void read(){

                buffer.skipPastTag(); //<student>
                t1.read();
                int start = buffer.skipPastTag(); //skip past string
                int finish = buffer.skipToTag(); //skip to /string
                major = buffer.substr(start, finish); //read the string


                buffer.skipPastTag();
                start = buffer.skipPastTag();
                finish = buffer.skipToTag();
                gpa = buffer.substr(start, finish);


                buffer.skipPastTag();
                buffer.skipPastTag();

        }

        void write(ostream &fout){
                fout << "<Student>" << endl;
                t1.write(fout);
                fout << "       <Major>" << major << "</Major>" << endl;
                fout << "       <GPA>" << gpa << "<GPA>" << endl;
                fout << "</Student>" << endl;
        }
};
  
class Professor : public Person{
private:
        Person t1;
        string s;
        string discipline;
        string rank;
public:
        Professor(Person t1, string s){
                this -> t1 = t1; this -> s = s;
        }
        string getField() const {
                return last;
        }
        void read(){
                buffer.skipPastTag();
                t1.read();
                int start = buffer.skipPastTag();
                int finish = buffer.skipToTag();
                discipline = buffer.substr(start, finish);

                buffer.skipPastTag();
                start = buffer.skipPastTag();
                finish = buffer.skipToTag();
                rank = buffer.substr(start, finish);
                buffer.skipPastTag();
                buffer.skipPastTag();
        }

        void write(ostream &fout){
                fout << "<Professor>" << endl;
                t1.write(fout);
                fout << "       <Discipline>" << discipline << "</Discipline>" << endl;
                fout << "       <Rank>" << rank << "</Rank>" << endl;
        }
};

bool compare1(const Student &s, const Student &t){
        return s.getField()<t.getField();
}

bool compare2(const Professor &s, const Professor &t){
        return s.getField()<t.getField();
}

void print1(const vector <Student> &v){
        int i = 1;
        cout << "Printing Person vector contents:" << endl;
        for(auto it: v){
                cout << "Record " << i << ":" << endl;
                it.write(cout);
                i++;
        }
        cout << endl;
}

void print2(const vector <Professor> &v){
        int i = 1;
        cout << "Printing Student vector contents: " << endl;
        for(auto it: v) {
                cout << "Record" << i << ":" << endl;
                it.write(cout);
                i++;
        }

        cout << endl;
}
    

int main(){


ifstream fin ("info.xml");

cout << "info.xml contains: " << endl << endl;

buffer.write(cout);
cout << "Reading info.xml, reconstructing the info and priting it back out: " << endl;


vector <Student> studentRecords;
vector <Professor> profRecords;

bool done = false;
string tag = getTag(buffer);
do{
        cout << "\nFound recorded object " << tag << ":" << endl;
        if(tag == "Student"){
                student.read(); //read the rest of the record
                studentRecords.push_back(Student);
        }
        else if(tag == "Professor"){
                professor.read();
                profRecords.push_back(Professor);
        }
        else
                done = true; // no tag found
        tag = getTag(buffer);
}while (!buffer.eob() && !done);

sort (studentRecords.begin(), studentRecords.end(), compare1);
sort (profRecords.begin(), profRecords.end(), compare2);

print1(studentRecords);
print2(profRecords);
return 0;
}                           

[ultifinitus]

Ohi! You didn't declare the student object before calling student.read(); you're also trying to push back the actual class of Student into your vector<Student> instead of the student which you forgot to create. You may also want to consider making a blank initializer for your Student and Professor classes so you can create empty instances of those which you can fill before pushing them back into your arrays.