Range-based loop problem

[mighty asker]

The loop won't break.

//string second="45670";
//string first="";
//int max=7; 	
   for(char temp:second)
	{
	first += temp;
        if(temp==(char)max) break; //not working
	}

[Gamer2015]

max is an integer with value 7
temp is a character with value '7'

The value '7' corresponds to the value 55 in the ASCII. (google ASCII for details)
therefore the loop will not break when max is the character '7' but when the value of the character is 7

//string second="45670";
//string first="";
//char max='7'; 	 // added ' ', should work now
   for(char temp:second)
	{
	first += temp;
        if(temp==max) break; //not working
	}

[shadowCODE]

are you thinking that (char)max is '7' ??

[mighty asker]

are you thinking that (char)max is '7' ??

Yep. Until now.

should work now

It probably will. But I need max to remain int.

[Gamer2015]

then you can try int max = '7';
if that does not work cast the '7' to an int: int max = (int)'7';

[mighty asker]

max is an output from a function. It won't be 7 everytime.

[Gamer2015]

but it will be a number between 0 and 9 right?
In this case you can do: if(temp==(max + '0')) break;

[mighty asker]

but it will be a number between 0 and 9 right?

Yep.
But I'm not sure if I understand what if(temp==(max + '0')) break; does.

[mighty asker]

Above line seems to work though I didn't understand how.
However, I need help with similar problem from another program.

for (int i = 0; i < line.length()-1; i++)
		{			
			int temp = line[i];
                }

How to make this work?

[Gamer2015]

But I'm not sure if I understand what if(temp==(max + '0')) break; does.
in the ASCII all characters have a value.
values for 0-9 are consecutive, so to get the character-value of a number you simply need to add the value of '0' (which is equivalent to 48)

so if max = 7 then max + '0' = 55 = '7'

How to make this work?

What should it do?

[mighty asker]

"line" is a string and "temp" is an int.
It should assign the current char in "line" to temp.

[Gamer2015]

so this char is a number (eg. '7') and you want to have it as int?

Same idea as above but in reverse order
int temp = line[i] - '0';

[mighty asker]

Thank you.
You're talking about the second table, right?
http://www.theasciicode.com.ar/