banking program error

[werdem]

hi, when I completed to case 4 and 5, l executed the program, actually functions working but exe file stops with an error.if you have any idea to solve it,it will be great, thanks.

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

#include "transaction.h"
#include "account.h"
#include "Custome.h"
void trans(account* customer, const double& balance, const string& transactiondescription, const string& transactiondate);
int main()
{

	string customername, userid, pin;
	int option;
	account *acc;
	string transactiondate;
	string transactiondescription;
	double transactionamount;
	string customer;
	string accountno;
	double balance;
	double totaldeposit=0;
	double totalwitdrawal;
	transaction list[50];
	int transactioncount = 0;
	void recorddeposit();

	//main menu//
	do
	{

		cout << "Welcome to our banking system" << endl;
		cout << "*****************************************" << endl;
		cout << "Please chose your transaction" << endl;
		cout << "*****************************************" << endl;
		cout << "1-Create new customer record" << "\n"
			<< "2-Create new transaction" << "\n"
			<< "3-Create new account" << "\n"
			<< "4-Record deposit" << "\n"
			<< "5-Record withdraw" << "\n"
			<< "6-Print report" << endl
			<< "8-Exit" << endl;

		cin >> option;

		//transaction according to menu selection//
		switch (option)
		{
		case 1:
			cout << "please enter costumer name" << endl;
			cin >> customername;
			cout << "Please enter user id" << endl;
			cin >> userid;
			cout << "please enter pin number" << endl;
			cin >> pin;
			createcustomer(customername, userid, pin);

			break;
		case 2:
			cout << "enter transaction date" << endl;
			cin >> transactiondate;
			cout << "enter transaction amount" << endl;
			cin >> transactionamount;
			cout << "enter transaction description" << endl;
			cin >> transactiondescription;
			createtransaction(transactiondate, transactiondescription, transactionamount);


			break;

		case 3:
			cout << "please enter costumer name" << endl;
			cin >> customername;
			cout << "please enter the account number" << endl;
			cin >> accountno;
			cout << "enter transaction date" << endl;
			cin >> transactiondate;
			cout << "enter the amount of money you wanted to deposit" << endl;
			cin >> balance;
			transactiondescription = "Opening balance";
			acc = createaccount(customername, accountno, transactiondate, balance);
		
			cout << totaldeposit << endl;

			break;

		case 4:
			cout << "please enter costumer name" << endl;
			cin >> customer;
			cout << "enter the amount of money you wanted to deposit" << endl;
			cin >> balance;
			transactiondescription = "deposit";
			transactiondate = "01/01/2015";

			trans(acc, balance, transactiondescription, transactiondate);

			break;
		case 5:
			cout << "please enter costumer name" << endl;
			cin >> customer;
			cout << "enter the amount of money you wanted to withdraw" << endl;
			cin >> balance;
			transactiondescription = "withdraw";
			transactiondate = "01/01/2015";

			// trans(account*customer, balance, transactiondescription, transactiondate);





			break;

		case 6:
			//Display(createaccount);
			//int i;
			//for (int i = 0; i < customer->transactioncount; i++) DisplayUnit(customer>list[i]);
			//string vvv = "erer";

			//cout << vvv.customer<< endl;


			break;
		}//end switch
	} while (option != 8);

}
void trans(account* customer, const double& balance, const string& transactiondescription, const string& transactiondate)
{
	customer->list[customer->transactioncount] = *createtransaction(transactiondate, transactiondescription, balance);
	customer->transactioncount++;

}
*********************************************************************
header files
*********************************************************************
#include <iostream>
#include <iomanip>
#include <string>
#ifndef Custome_h
#define Custome_h
using namespace std;

#define EMPTY 0
#define BLANK ""

struct Custome
{
	
	string customername;
	string userid;
	string pin;
};

Custome* createcustomer(const string& customername = BLANK, const string& userid = BLANK, const string&pin = BLANK);
Custome*createcustomer(const string&customername, const string&userid, const string&pin)
{
	Custome* customer = new Custome();
	customer->customername = customername;
	customer->userid = userid;
	customer->pin = pin;
	cout << "customer is created" << endl;
	
	



	return 0;
}

#endif
****************************************************************
//account.h
#include <iostream>
#include <iomanip>
#include <string>
#include "transaction.h"
#include "Custome.h"
using namespace std;
string transactiondescription;

struct account
{
	string customer;
	string accountno;
	double balance;
	double totaldeposit;
	double totalwitdrawal;
	transaction list[50];
	int transactioncount=0;
};


account*createaccount(const string& customername, const string &accountno, const string &transactiondate,const double & balance);


account*createaccount(const string& customername, const string& accountno, const string&transactiondate, const double& balance)
{
	createtransaction(transactiondate, transactiondescription, balance);
	createcustomer(customername);
	
	return 0;
}

void Display(account*createaccount)
{
	for (int i = 0; i < createaccount->transactioncount; i++) display(createaccount->list[i]);



}
******************************************************************
//transaction.h
#include <iostream>
#include <iomanip>
#include <string>

#ifndef transaction_h
#define transaction_h
#define EMPTY 0
#define BLANK ""
#define DATE 01/01/2014

using namespace std;
struct transaction
{
	int transactioncount = 0;
	string transactiondate;
	string transactiondescription;
	double transactionamount;
};

transaction* createtransaction(const string& transactiondate=DATE, const string& transactiondescription=BLANK, const double& transactionamount=EMPTY);

transaction* createtransaction(const string& transactiondate, const string& transactiondescription, const double& transactionamount)
{
	transaction *createtransaction = new transaction();
	createtransaction->transactiondate = transactiondate;
	createtransaction->transactiondescription = transactiondescription;
	createtransaction->transactionamount = transactionamount;
	createtransaction->transactioncount++;
	cout << "transaction is created" << endl;
	return 0;

}

void display(transaction createtransaction)
{
	cout << createtransaction.transactiondescription << createtransaction.transactiondate;

}

#endif

[fg109]

I have not looked at all of it, but I think the current problem is that you have declared a pointer
account *acc;
and you are trying to do operations without first having it point to an actual account.

[werdem]

l am very confused about the reason, because when i executed it ,l took the error message after l took the "transaction is created " message and I reckon you might be right but l don't know how to fix it. I am quite new in C++ .

[fg109]

Sorry, I'm horrible at teaching so I don't think I can teach you about how pointers work. But I'm sure that someone else will come along soon and either explain them or link you to some material explaining them.

So in order to make this a useful post, some non-code related problems I want to point out:

1. You need to have a list or array of accounts or customers. This is evident from the existence of options 1 and 3 in your menu.
2. You need a search function. This is evident from the fact that you need a list or an array, and the existence of options 4 and 5 in your menu.

[TarikNeaj]

https://www.youtube.com/watch?v=h-HBipu_1P0&list=PLh1KmNlOkSnUiGlmnhspY0fFQ8oGGtfxO&ab_channel=mycodeschool

This playlist will teach ya all 'bout pointers.