why does my while statement return a infinite loop

[zoomer428]

My while statement returns a infinite loop while I want the variables to go down until creatures hp hits 0.

  #include <iostream>
#include <string>

using namespace std;

      string x;
      int herolvl = 1;
      int herohp = herolvl + 19;
      int herostr = herolvl + 4;
      int creaturehp = (herolvl + 4);
      int creaturestr = (herolvl + 4);

    class attack{
          public:
          void match(){
              while(creaturehp > 0){
                  creaturehp - herostr;
                  herohp - creaturestr;
                  cout<<creaturehp << herohp; // just spams a number.
              }
        }
};

[pnoid]

You're not changing the value of creaturehp. If you want to subtract the value of one variable from another you do this:

creaturehp = creaturehp - herostr;

//or use the shorthand way

creaturehp -= herostr;

You should probably avoid making all your variables global too.

[xenovia12]

creaturehp - herostr;
herohp - creaturestr;

these two statements is just a anonymous statements, and never modify the creaturehp and herohp.