Create Lists(Nodes)

[Vandalism]

I want to input nodes and it's on void create() but it won't output on void display()
It gives a message like this:
Unhandled exception at 0x00EC966B in Project12.exe: 0xC0000005: Access violation reading location 0x00000000.
Break continue

How to fix this? Thank you!

  #include<iostream>
using namespace std;

void create();
void addBegin(struct Node**);
//void specific();
//void delBegin();
//void delEnd();
//void delSpecific();
//void reverse();
//void sort();
void display();

struct Node {
	int info;
	struct Node *next;
};

struct Node* initNode(int data){
	struct Node *head = (struct Node*)malloc(sizeof(struct Node));
	head->info = data;
	head->next = NULL;
	return head;
}

struct Node *head;
int input, choice;
char ch;

int main()
{
	int choice;
	cout << "1. Create List \n\n";
	cout << "2. Add at beginning \n\n";
	cout << "3. Add at a specific node \n\n";
	cout << "4. Delete at the beginning \n\n";
	cout << "5. Delete at the end \n\n";
	cout << "6. Delete at a specific node \n\n";
	cout << "7. Reverese \n\n";
	cout << "8. Sort \n\n";
	cout << "9. Display \n\n";
	cout << endl;
	cout << "Enter your choice: ";
	cin >> choice;
	switch (choice)
	{
	case 1:
		create();
		break;
	case 2:
		addBegin(&head);
		break;
	/*case 3:
		specific();*/
	/*	case 4:
		case 5:
		case 6:
		case 7:
		case 8:*/
		case 9:
		display();
	}
	system("pause>0");
	return 0;
}

void create()
{
	Node *p;
	cout << "How many nodes do you want to input? ";
	cin >> input;
	cout << "Insert " << input << " nodes: ";
	for (int i = 0; i < input; i++){
		p = new Node;
		cin >> p->info;
		p->next = NULL;
	}
	cout << "Go back to main menu? [Y/N]";
	cin >> ch;
	if (ch == 'Y' || ch == 'y'){
		system("cls");
		main();
	}
	if (ch == 'N' || ch == 'n')
		create();
}

void addBegin(struct Node **head){
	int data;
	cout << "Insert a node on the beginning: ";
	cin >> data;
	struct Node *NewNode = initNode(data);
	NewNode->next = *head;
	*head = NewNode;
	
	cout << "Go back to main menu? [Y/N]";
	cin >> ch;
	if (ch == 'Y' || ch == 'y'){
		system("cls");
		main();
	}
	//if (ch == 'N' || ch == 'n')
	//	addBegin(&head);
}

void display()
{
	struct Node* cur = head;
	cout << "\n\nList is : " << endl;

	do {
		cout << cur->info << endl;
	} while ((cur = cur->next) != NULL);
	cout << "Go back to main menu? [Y/N]";
	cin >> ch;
	if (ch == 'Y' || ch == 'y'){
		system("cls");
		main();
	}
	if (ch == 'N' || ch == 'n')
		display();
}

//void specific()
//{
//	system("cls");
//	int node;
//	cout << "What number of node: ";
//	cin >> node;
//	cout << "What data? ";
//
//
//} 

[dhayden]

The loop at line 73 creates a node but doesn't actually add it to the list.

This would be better C++ if you made some changes.
- remove initNode() and instead make a constructor for Node:

struct Node {
    Node(int i) : info(i), next(nullptr) {}
     // rest of your code
};

Also, if you make a separate class for the list itself then many of the functions become members of the class:

class List {
private:
    Node *head;
public:
    List() : head(nullptr) {}
    ~List();

    addBegin();
    create();
    display();
};

Why do it this way? For one, it will remove some inconsistency: addBegin() currently takes a pointer to head, but create() uses the global variable called head. Also it means you can have multiple lists.

[Vandalism]

Where should i put this code?

struct Node {
    Node(int i) : info(i), next(nullptr) {}
     // rest of your code
};

[SECMoG1T]

here ...

struct Node 
{
        Node(int i) : info(i), next(nullptr) {}
	int info;
        Node *next;
};