Converting number into words jumping into c++

[koopey]

Hi everyone. The problem is:
"implement source to convert number into words. eg: if input is 454, result is four hundred fifty four.
I spent my entire noon and afternoon in this single problem and finally came up with the this code. Yet I feel that this is too long. Can anyone suggest a more concise code for the same problem.(please note that i only know concept of if,loop, and function.4 days into c++) My code is:

  //works for only upto millionth number

#include <iostream>
using namespace std;
void millionth_function(int x);
void thousandth_function(int x);
void no_th_function(int x);
void millionth_3_digits(int y);
void thousandth_3_digits(int x);
void no_th_3_digits(int x);
void hundredth_number(int x);
void tens_number(int x);
int main()
{
    int number;
    cout<< "enter number: ";
    cin>>number;
    millionth_3_digits(number);
    thousandth_3_digits(number);
    no_th_function(number);
}
void millionth_3_digits(int x)
{
    int three_digits=((x%1000000000)/1000000);
    hundredth_number(three_digits);
    tens_number(three_digits);
    if(three_digits!=0)
    {
        cout<<" million ";
    }
}
void thousandth_3_digits  (int x)
{
    int three_digits=((x%1000000)/1000);
    hundredth_number(three_digits);
    tens_number(three_digits);
    if (three_digits!=0)
    {
        cout<<" thousand";
    }
}
void no_th_function(int x)
{
    int three_digits=(x%1000);
    hundredth_number(three_digits);
    tens_number(three_digits);
    }
void hundredth_number(int x)
{
    int first_number=x/100;
    if (first_number==1)
    {
        cout<<" One hundred ";
    }
    else if (first_number==2)
    {
        cout<<" Two hundred ";
    }
    else if (first_number==3)
    {
        cout<<" Three hundred ";
    }
    else if (first_number==4)
    {
        cout<<" Four hundred ";
    }
    else if (first_number==5)
    {
        cout<<" Five hundred ";
    }
    else if (first_number==6)
    {
        cout<<" Six hundred ";
    }
    else if (first_number==7)
    {
        cout<<" Seven hundred ";
    }
    else if (first_number==8)
    {
        cout<<" Eight hundred ";
    }
    else if (first_number==9)
    {
        cout<<" Nine hundred ";
    }
    }
void tens_number(int x)
{
    int last_two_number=x%100;
    if(last_two_number<20)
    {
        if (last_two_number==1)
        {
            cout<<" One ";
        }
        if (last_two_number==2)
        {
            cout<<" Two ";
        }
        if (last_two_number==3)
        {
            cout<<" Three ";
        }
        if (last_two_number==4)
        {
            cout<<" Four ";
        }
        if (last_two_number==5)
        {
            cout<<" Five ";
        }
        if (last_two_number==6)
        {
            cout<<" Six ";
        }
        if (last_two_number==7)
        {
            cout<<"Seven ";
        }
        if (last_two_number==8)
        {
            cout<<" Eight ";
        }
        if (last_two_number==9)
        {
            cout<<" Nine ";
        }
        if (last_two_number==10)
        {
            cout<<" Ten ";
        }
        if (last_two_number==11)
        {
            cout<<" Eleven ";
        }
        if (last_two_number==12)
        {
            cout<<" Twelve ";
        }
        if (last_two_number==13)
        {
            cout<<" Thirteen ";
        }
        if (last_two_number==14)
        {
            cout<<" Fourteen ";
        }
        if (last_two_number==15)
        {
            cout<<" Fifteen ";
        }
        if (last_two_number==16)
        {
            cout<<" Sixteen ";
        }
        if (last_two_number==17)
        {
            cout<<" Seventeen ";
        }
        if (last_two_number==18)
        {
            cout<<" Eighteen ";
        }
        if (last_two_number==19)
        {
            cout<<" Ninteen ";
        }
        }
        if (last_two_number>19)
        {
            int tens_digit=last_two_number/10;
            if (tens_digit==2)
            {
                cout<<" Twenty ";
            }
            if (tens_digit==3)
            {
                cout<<" Thirty ";
            }
            if (tens_digit==4)
            {
                cout<<" Forty ";
            }
            if (tens_digit==5)
            {
                cout<<" Fifty ";
            }
            if (tens_digit==6)
            {
                cout<<" Sixty ";
            }
            if (tens_digit==7)
            {
                cout<<" Seventy ";
            }
            if (tens_digit==8)
            {
                cout<<" Eighty ";
            }
            if (tens_digit==9)
            {
                cout<<" Ninty ";
            }
            int units_digit=last_two_number%10;
            if (units_digit==1)
            {
                cout<<" One ";
            }
            if (units_digit==2)
            {
                cout<<" Two ";
            }
            if (units_digit==3)
            {
                cout<<" Three ";
            }
            if (units_digit==4)
            {
                cout<<" Four ";
            }
            if (units_digit==5)
            {
                cout<<" Five ";
            }
            if (units_digit==6)
            {
                cout<<" Six ";
            }
            if (units_digit==7)
            {
                cout<<" Seven ";
            }
            if (units_digit==8)
            {
                cout<<" Eight ";
            }
            if (units_digit==9)
            {
                cout<<" Nine ";
            }
            }
}

Any suggestion would be highly appreciated!

[anup30]

there are multiple spaces in your program output, keep only one space.
and,
"123" >> "one hundred twenty-three"
notice where hyphen is used.

[Duthomhas]

notice where hyphen is used.

The hyphen is not necessary.


[edit]
Those ifs can be turned into switches.

Also, when you get to arrays, consider rewriting using an array lookup. Here's a link to my old numbers-to-words challenge:
http://www.cplusplus.com/forum/lounge/74394/
(for more ideas in the future)

Hope this helps.

[anup30]

hmm, very big codes. can it be done less than 100 lines!

[anup30]

@koopey,

if (tens_digit==7)
            {
                cout<<" Seventy ";
            }
if (tens_digit==8)
            {
                cout<<" Eighty ";
            }
if (tens_digit==9)
            {
                cout<<" Ninty ";
            }

if you write following way, it would be much shorter and easier to read:

if (tens_digit==7) cout<<" Seventy ";
if (tens_digit==8) cout<<" Eighty ";
if (tens_digit==9) cout<<" Ninty ";

[Duthomhas]

anup30 wrote:

hmm, very big codes. can it be done less than 100 lines!

Are you being smug about something, or just making an observation about the code in my link?

(Because you'll notice that all the code in my link does it in less than 100 lines, discounting commentary and the requirement of making a fully functioning program. Not to mention that everyone's examples are pretty robust about handling fairly large numbers.)


 Re: compressing vertical whitespace:

if you write following way, it would be much shorter and easier to read:

if (tens_digit==7) cout<<" Seventy ";
if (tens_digit==8) cout<<" Eighty ";
if (tens_digit==9) cout<<" Ninty ";

+ 1

Using arrays to look stuff up would also do that, but it is still a good comment if not using arrays.

[koopey]

Thanks guys for the responses. @duoas I will try and use arrays when I get there. @anup30. just finished reading switches. Thanks again!

[anup30]

@duoas, latter. in fact previously i only glanced there, and it seemed little confusing seeing 100+ lines from experienceds (while OPs code will be under 100 if he formats as suggested, or even shorter if arrays are used.)
you are right, i didn't notice that nearly half of their length were comments.