problem in terminating a for loop containing if else statement

[prajwalsingh]

in the below program the for loop does not get terminated when I enter I,E,i or e.

cin>>b;
for(i=0;i<10;i++)
{if(toupper(b)!='I'||toupper(b)!='E')
{cout<<"enter the correct choice";
cin>>b;}
else if(toupper(b)=='I'||toupper(b)=='E') break;}

[dhayden]

if(toupper(b)!='I'||toupper(b)!='E')
This is true for all values of b, including I and E. When b=='I' toupper(b) != 'E' is true, and when b == 'E', toupper(b) != 'I' is true.

You only need to us the second condition:

for (i = 0; i < 10; i++) {
    cin >> b;
    if (toupper(b) == 'I' || toupper(b) == 'E') {
	break;
    } else {
	cout << "enter the correct choice";
    }
}

[prajwalsingh]

thanks :) got the logic. it worked after making minor changes in the program i had to remove the brackets from the break and else statement.after that your solution worked fine