Error after inputting seven numbers

[deathslice]

This error always occur after I input 7 numbers. What could it be?

#include <iostream>
#include <limits>
#include <vector>

void checkingInput(int &);
void displayNumbers(std::vector<int> &);

int main()
{
    int input = 0;
    std::vector<int> myVector(0);

    std::cout << "Enter a number to find the answer of the universe! ";

    while(input != 42)
    {
        std::cin >> input;
        checkingInput(input);
        if(input == 42)
        {
            break;
        }
        else if(input > 99)
        {
            input = input % 25;
            myVector.push_back(input);
        }
        else
            {
                myVector.push_back(input);
            }
    }

    std::cout << std::endl << std::endl;

    std::cout << "These are the numbers that you inputted: ";

    displayNumbers(myVector);

    std::cout << std::endl;

    return 0;
}

void checkingInput(int &num)
{
    while(!(std::cin) || num < 0)
    {
        std::cin.clear();
        std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
        std::cout << "This is not a number or a positive number. ";
        std::cin >> num;
    }
}

void displayNumbers(std::vector<int> &myVector)
{
    for(unsigned int i=0; i < myVector.size(); i++)
    {
        std::cout << myVector[i] << " ";
    }
}

[deathslice]

I decide to put this program in debug mode to find out what the error was and it turned out to be a segmentation fault at line 44.

[jlb]

The first problems I notice are in the following snippet:

    int numberCounter = 0;
    int numArray[numberCounter];

First array sizes must be at least 1, zero sized arrays are not allowed.

Second array sizes must be compile time constants.

Third, unless you have potential of overrunning your array in your data entry loop. You need to insure you don't try to enter more numbers than your array can hold.

[deathslice]

Well here are a couple of problems. If I change the numberCounter to constant, then I won't be able to increment it. The reason I left it like that was because I don't know how many numbers the user is going to input(it could be 100 or 1000) before quitting. At this point, I think using vectors might be a better option.

[jlb]

At this point, I think using vectors might be a better option.

Vectors are far superior to arrays, IMO, when you don't know how many entries you will get.

[deathslice]

Alright, fixed it with vectors. Hurrah for vectors.