Writing from file to array

[awestey]

Hello,
I need to write from a file to an array. The data in the file is stored as two numbers separated by spaces (tabs). I am having trouble populating the array, but receive no errors so I'm not sure what the deal is. For pieces of the code will Thanks in advance!

 #include <iostream>
#include <fstream>
#include <cmath>
#include <string>

using namespace std;


int main()
{
ifstream inputweather;
inputweather.open ("project4.txt");
int linecounter = 0;

if(!inputweather.fail())

{	
	string line;
	cout << "The file opened, preparing the menu" << endl;
		
	while (inputweather.good())
	{
		linecounter ++;
	}
	char weatherarray[linecounter];
	cout << "Step 1 complete" << endl;
	
	while (inputweather.good())
	{
	int position = 0;
	inputweather >> weatherarray[position];
	position ++;
	}
}
else 
{
	cout << "The file failed to open" << endl;
	
}
return 0;
}

[elite zero]

If you know the size of the file, then it will be easy. Just set the size of the array to the number of positions you need for all of the numbers in the file.

then:

int SIZE = ?; // Whatever size you need for your array
int myArray[SIZE]; // Creating array
int i = 0; // Initialize iterator
string line;

while(getline(fileName, line) // Getting lines as strings
 {
   myArray[i]=stoi(line); // Putting 'line' into array after string to integer conversion
   i++;
 }

[Yanson]

This is an infinite loop.

	while (inputweather.good())
	{
		linecounter ++;
	}

This is illegal it would have to be a dynamic array.
char weatherarray[linecounter];

[awestey]

Thank you for the quick replies!
Unfortunately, stoi does not work (compiler is out of date I guess?).
Yanson, thanks for the tip.

[elite zero]

Nah, stoi seems to not be an ANSI standard.

You can always use a stringstream to convert.