C++

Forum

 
Tic Tac Toe Game help

specter113 (50)
Im having a hard time creating a loop that checks to see if its a win or not.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
 
  #include <iostream>
using namespace std;

char square[10] = { 'o', '1', '2', '3', '4', '5', '6', '7', '8', '9' };

int checkwin(int x);
void board();

int main()
{
	int player = 1, choice, i, x = 0;

	char mark;
	do
	{
		board();
		player = (player % 2) ? 1 : 2;

		cout << "Player " << player << ", enter a number:  ";
		cin >> choice;

		mark = (player == 1) ? 'X' : 'O';

		if (choice == 1 && square[1] == '1')

			square[1] = mark;
		else if (choice == 2 && square[2] == '2')

			square[2] = mark;
		else if (choice == 3 && square[3] == '3')

			square[3] = mark;
		else if (choice == 4 && square[4] == '4')

			square[4] = mark;
		else if (choice == 5 && square[5] == '5')

			square[5] = mark;
		else if (choice == 6 && square[6] == '6')

			square[6] = mark;
		else if (choice == 7 && square[7] == '7')

			square[7] = mark;
		else if (choice == 8 && square[8] == '8')

			square[8] = mark;
		else if (choice == 9 && square[9] == '9')

			square[9] = mark;
		else
		{
			cout << "Invalid move ";

			player--;
			cin.ignore();
			cin.get();
		}
		int x = 0;
		i = checkwin(x);

		player++;
	} while (i==-1);
	board();
	if (i==1)

		cout << "==>\aPlayer " << --player << " win ";
	else
		cout << "==>\aGame draw";

	cin.ignore();
	cin.get();
	return 0;
}

int checkwin(int x)//The issue is within this function here I believe. It works for the first row but after that the game still plays. 
{
	for (x = x+1; x < 10; x++)
	{
		for (int y = x + 1; y < 10; y++)
		{
			int z = y + 1;
			if (square[x] == square[y] && square[y] == square[z])
			{
				return 1;
			}
			else (x = x + 3);
		}
	}
	for (x = x + 1; x < 10; x++)
	{
		for (int y = x + 3; y < 10; y++)
		{
			int z = y + 3;
			if (square[x] == square[y] && square[y] == square[z])
			{
				return 1;
			}
			if (square[1] == square[5] && square[5] == square[9])

				return 1;
			if (square[3] == square[5] && square[5] == square[7])

				return 1;
		}
	}
	if (square[1] != '1' && square[2] != '2' && square[3] != '3'
		&& square[4] != '4' && square[5] != '5' && square[6] != '6'
		&& square[7] != '7' && square[8] != '8' && square[9] != '9')

		return 0;
	else
		return -1;
}

void board()
{
	system("cls");
	cout << "Tic Tac Toe\n";

	cout << "Player 1 (X)  -  Player 2 (O)" << endl << endl;
	cout << endl;

	cout << "     |     |     " << endl;
	cout << "  " << square[1] << "  |  " << square[2] << "  |  " << square[3] << endl;

	cout << "_____|_____|_____" << endl;
	cout << "     |     |     " << endl;

	cout << "  " << square[4] << "  |  " << square[5] << "  |  " << square[6] << endl;

	cout << "_____|_____|_____" << endl;
	cout << "     |     |     " << endl;

	cout << "  " << square[7] << "  |  " << square[8] << "  |  " << square[9] << endl;

	cout << "     |     |     " << endl << endl;
}
Last edited on
specter113 (50)
Alright, I gave up on trying to make this code short with loops. I have an assembly back ground too and yes I did enjoy putting that jump in this program lol. Heres the new code that I put together with help from various tutorials and others questions. Any tips or hints on how to condense this monster would be great..

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
 
#include <iostream>
using namespace std;

char square[10] = {'0','1', '2', '3', '4', '5', '6', '7', '8', '9' };

int checkwin();
void board();

int main()
{
	int player = 1, i, choice, p1count = 0, p2count = 0, dcount = 0, x = 0;
	char mark;

lable:
	square[1] = '1';
	square[2] = '2';
	square[3] = '3';
	square[4] = '4';
	square[5] = '5';
	square[6] = '6';
	square[7] = '7';
	square[8] = '8';
	square[9] = '9';
	do
	{
		board();
		player = (player % 2) ? 1 : 2;

		cout << "Player " << player << ", Choose a box:  ";
		cin >> choice;
		
		mark = (player == 1) ? 'X' : 'O';

		if (choice == choice && square[choice] == square[choice])
		{
			square[choice] = mark;
		}
			
		
		i = checkwin();

		player++;
	} 
	while (i == -1);
	board();
	if (i == 1)
	{
		if (--player==1)
		{
			p1count++;
			cout << "Player 1" << " " << "Wins" << " " << p1count << endl;
			cout << "Player 2" << " " << "Wins" << " " << p2count << endl;
			cout << "Draw" << " " << dcount << endl;
			cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
			cin >> x;
			if (x == 1) goto lable;
			
			return 0;
		}
		else
			p2count++;
			cout << "Player 1" << " " << "Wins" << " " << p1count << endl;
			cout << "Player 2" << " " << "Wins" << " " << p2count << endl;
			cout << "Draw" << " " << dcount << endl;
			cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
			cin >> x;
			if (x == 1) goto lable;
		
			return 0;
		
	}
	else
		dcount++;
		cout << "Player 1" << " "<<"Wins"<<" "<< p1count << endl;
		cout << "Player 2" <<" "<<"Wins"<<" "<<p2count << endl;
		cout << "Draw" << " "<< dcount <<endl;
		cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
		cin >> x;
		if (x == 1) goto lable;
		cin.ignore();
		cin.get();

		return 0;
}

int checkwin()
{
	if (square[1] == square[2] && square[2] == square[3])

		return 1;
	else if (square[4] == square[5] && square[5] == square[6])

		return 1;
	else if (square[7] == square[8] && square[8] == square[9])

		return 1;
	else if (square[1] == square[4] && square[4] == square[7])

		return 1;
	else if (square[2] == square[5] && square[5] == square[8])

		return 1;
	else if (square[3] == square[6] && square[6] == square[9])

		return 1;
	else if (square[1] == square[5] && square[5] == square[9])

		return 1;
	else if (square[3] == square[5] && square[5] == square[7])

		return 1;
	else if (square[1] != '1' && square[2] != '2' && square[3] != '3'
		&& square[4] != '4' && square[5] != '5' && square[6] != '6'
		&& square[7] != '7' && square[8] != '8' && square[9] != '9')
	
		return 0;
	else
		return -1;
}

void board()
{
	system("cls");
	cout << "Tic Tac Toe\n" << endl;

	cout << "Player 1 (X)    Player 2 (O)" << endl << endl;

	cout << "_________________" << endl;
	cout << "     |     |     " << endl;
	cout << "  " << square[1] << "  |  " << square[2] << "  |  " << square[3] << endl;

	cout << "_____|_____|_____" << endl;
	cout << "     |     |     " << endl;

	cout << "  " << square[4] << "  |  " << square[5] << "  |  " << square[6] << endl;

	cout << "_____|_____|_____" << endl;
	cout << "     |     |     " << endl;

	cout << "  " << square[7] << "  |  " << square[8] << "  |  " << square[9] << endl;

	cout << "_____|_____|_____" << endl << endl;
}
RadWayne (97)
That's not that huge. I made a TicTacToe Game a while back. I just went and checked it and its ~550 lines.

Scrolled through yours and all that immediately comes to mind is to put more stuff inside of functions to clean things up a little.

As an example. My main function is 1 line that initializes the class below:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
 
class TicTacToe
{
	vector<char> board;
	char player;
	char comp;
	int boardSize;
	bool toggleGrid;
	bool gameState;
	int randomSpot();

	void initialize();
	int getSize();
	void printBoard();

	void playerTurn();
	void compTurn();
	bool checkWin();
	
	void nextTurn();
	public:

	TicTacToe() : board(getSize(),' '),
				gameState(true) {initialize();}

};
Last edited on
RadWayne (97)
After looking through it a little more I noticed a couple things.

The if statement on line 34 will always return true.
1
2
3
4
 
if (choice == choice && square[choice] == square[choice])
		{
			square[choice] = mark;
		}


And instead of using a goto statement you could put the whole thing inside of a while loop have it check against a bool that you set to false if the user chooses not to play anymore at the end.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
 
while(playing)
{
	square[1] = '1';
	square[2] = '2';
	square[3] = '3';
	square[4] = '4';
	square[5] = '5';
	square[6] = '6';
	square[7] = '7';
	square[8] = '8';
	square[9] = '9';
	do
	{
		board();
		player = (player % 2) ? 1 : 2;

		cout << "Player " << player << ", Choose a box:  ";
		cin >> choice;
		
		mark = (player == 1) ? 'X' : 'O';

		square[choice] = mark;
				
		i = checkwin();

		player++;
	} 
	while (i == -1);
	board();
	if (i == 1)
	{
		if (--player==1)
		{
			p1count++;
			cout << "Player 1" << " " << "Wins" << " " << p1count << endl;
			cout << "Player 2" << " " << "Wins" << " " << p2count << endl;
			cout << "Draw" << " " << dcount << endl;
			cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
			cin >> x;
			if (x != 1) playing=false;
			
			return 0;
		}
		else
			p2count++;
			cout << "Player 1" << " " << "Wins" << " " << p1count << endl;
			cout << "Player 2" << " " << "Wins" << " " << p2count << endl;
			cout << "Draw" << " " << dcount << endl;
			cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
			cin >> x;
			if (x != 1) playing=false;
		
			return 0;
		
	}
	else
		dcount++;
		cout << "Player 1" << " "<<"Wins"<<" "<< p1count << endl;
		cout << "Player 2" <<" "<<"Wins"<<" "<<p2count << endl;
		cout << "Draw" << " "<< dcount <<endl;
		cout << "Do you wish to continue playing?" << " "<<"Enter 1 for Yes and 2 for No" << endl;
		cin >> x;
		if (x != 1) playing=false;
		cin.ignore();
		cin.get();

		return 0;
}
Last edited on
Topic archived. No new replies allowed.